test: remove pre-condition that snapshot do not exists #37203
Merged
+0
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to migration that runs on cluster bootstrap, sometimes we may have snapshot after startup. So the pre-condition for this test that a snapshot does not exist might not always satisfy. Since the snapshot at position 0 do not actually have the state changes from StreamProcessor, this test still has value. So we keep the test to cover such cases, but only remove the pre-condition.
3cf09cb to
c0d0edb
Compare
|
I will port it to 8.7 and main as well. |
npepinpe
approved these changes
Aug 26, 2025
| @@ -46,7 +46,6 @@ void update( | |||
| state.withNetwork(network).withOldBroker().start(true); | |||
| final long processInstanceKey = testCase.setUp(state.client()); | |||
| final long key = testCase.runBefore(state); | |||
| assertThat(state).hasNoSnapshotAvailable(1); | |||
There was a problem hiding this comment.
🤔 Should we assert it's at position 0? 🤷
There was a problem hiding this comment.
I did that initially - 751d68c
But I think we don't need to be that strict. If you want, I can bring those changes back.
|
I guess this has to be forward ported to 8.7 and 8.8 and main? |
|
Successfully created backport PR for |
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Due to migration that runs on cluster bootstrap, sometimes we may have snapshot after startup. So the pre-condition for this test that a snapshot does not exist might not always satisfy.
Since the snapshot at position 0 do not actually have the state changes from StreamProcessor, this test still has value. So we keep the test to cover such cases, but only remove the pre-condition.
Alternately, we can verify that if the snapshot exists it is at position 0. But I think we don't need to be that strict for this test.
Context: slack thread
Checklist