fix: make Tasklist and Operate updateSchemaSettings default to false #37132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cf961dd to
8867640
Compare
8867640 to
8de264b
Compare
8de264b to
1499f10
Compare
panagiotisgts
approved these changes
Aug 25, 2025
tasklist/qa/integration-tests/src/test/java/io/camunda/tasklist/os/SchemaCreationIT.java
Show resolved
Hide resolved
tasklist/qa/integration-tests/src/test/java/io/camunda/tasklist/es/SchemaCreationIT.java
Show resolved
Hide resolved
ChrisKujawa
approved these changes
Aug 25, 2025
There was a problem hiding this comment.
Thanks @houssain-barouni just smaller suggestions and questions, looks good 👍🏼
operate/common/src/main/java/io/camunda/operate/property/ElasticsearchProperties.java
Outdated
Show resolved
Hide resolved
operate/common/src/main/java/io/camunda/operate/property/OpensearchProperties.java
Outdated
Show resolved
Hide resolved
operate/qa/integration-tests/src/test/java/io/camunda/operate/schema/SchemaStartupIT.java
Show resolved
Hide resolved
tasklist/common/src/main/java/io/camunda/tasklist/property/ElasticsearchProperties.java
Outdated
Show resolved
Hide resolved
tasklist/qa/integration-tests/src/test/java/io/camunda/tasklist/es/SchemaCreationIT.java
Show resolved
Hide resolved
.../qa/integration-tests/src/test/java/io/camunda/tasklist/os/OpenSearchSchemaManagementIT.java
Show resolved
Hide resolved
| @@ -135,4 +143,89 @@ public void shouldFailIfSchemaNotUpdateable() { | |||
| .isInstanceOf(OperateRuntimeException.class) | |||
| .hasMessageContaining("Not supported index changes are introduced"); | |||
| } | |||
|
|
|||
| @Test | |||
| public void shouldUpdateIndexSettingsWhenUpdateSchemaSettingsIsEnabled() | |||
There was a problem hiding this comment.
🔧 What I actually would like to see is to have some default behavior tests, in all tests we explicitly set the value. When I now change the default value again, none of the tests would fail, which might be a problem.
There was a problem hiding this comment.
I made the test parameterized, to use the default value or not
|
Successfully created backport PR for |
Merged
11 tasks
houssain-barouni
added a commit
that referenced
this pull request
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Slack discussion
The fix for #32872 is included in patch versions 8.6 and 8.7. Upgrading to these versions may introduce a breaking change by undeseriably updating schema settings for SM customers. To make the fix as an opt-in option, the default value for updateSchemaSettings will be set to false. For SaaS customers, the setting will be enabled (set to true).
Also added some integration tests, and did some clean-up on the existing ones
Checklist
Related issues
relates to #32872, #31238