feat: add support for deleting exporter from runtime in broker #36986
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When exporter is deleted, it is removed from the runtime state by the ExporterDirector. Concurrent changes during transition are handled by ExporterDirectorTransitionStep already. Since disable and delete behaves similar with in ExporterDirector, the method is renamed to "removeExporter". Co-authored-by: giampaolo <giampaorr@gmail.com>
|
I have already reviewed the original PR. The only difference is - i reverted the changes in ExporterDirectorTransitionStep to handle concurrent deletion. The existing code already handles this case. So the changes were redundant. |
npepinpe
approved these changes
Aug 20, 2025
|
/backport |
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When exporter is deleted, it is removed from the runtime state by the ExporterDirector. Concurrent changes during transition are handled by ExporterDirectorTransitionStep already. Since disable and delete behaves similar with in ExporterDirector, the method is renamed to "removeExporter".
The original PR for this feature is #36516 by @giampa91
Checklist
Related issues
closes #35324
closes #35323