update tasklist component template with configured number of shards and replicas #36569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f596d17 to
99bbffe
Compare
898ad7b to
05f68b1
Compare
985513c to
3a9acef
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
3a9acef to
10c263c
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR updates tasklist component template with configured number of shards and replicas, enabling better control over index configuration settings.
- Updates schema management to use configurable shards and replicas per index
- Adds index settings update functionality to both ElasticSearch and OpenSearch schema managers
- Introduces comprehensive test coverage for component template settings updates
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
ReindexOpenSearchIT.java |
Minor cleanup removing blank lines and updating method signatures |
OpenSearchSchemaManagementIT.java |
Added comprehensive tests for component template settings updates |
ElasticSearchSchemaManagementIT.java |
Added comprehensive tests for component template settings updates with ES-specific imports |
OpenSearchSchemaManagerTest.java |
Updated test to use index-specific configuration methods |
SchemaManager.java |
Added updateIndexSettings() method to interface |
OpenSearchSchemaManager.java |
Implemented index settings update functionality and component template management |
ElasticsearchSchemaManager.java |
Implemented index settings update functionality for ElasticSearch |
SchemaStartup.java |
Added call to update index settings during schema initialization |
IndexSchemaValidator.java |
Removed unused newerVersionsForIndex method |
RetryOpenSearchClient.java |
Added methods for component template settings and alias management |
IndexSchemaValidatorOpenSearch.java |
Simplified schema validation logic |
RetryElasticsearchClient.java |
Added component template settings methods for ElasticSearch |
IndexSchemaValidatorElasticSearch.java |
Simplified schema validation logic |
TasklistOpenSearchProperties.java |
Added index-specific getter methods for shards and replicas |
TasklistElasticsearchProperties.java |
Added index-specific getter methods for shards and replicas |
...ist/els-schema/src/main/java/io/camunda/tasklist/schema/manager/OpenSearchSchemaManager.java
Show resolved
Hide resolved
.../els-schema/src/main/java/io/camunda/tasklist/schema/manager/ElasticsearchSchemaManager.java
Show resolved
Hide resolved
panagiotisgts
approved these changes
Aug 12, 2025
tasklist/els-schema/src/main/java/io/camunda/tasklist/schema/SchemaStartup.java
Outdated
Show resolved
Hide resolved
...ist/els-schema/src/main/java/io/camunda/tasklist/schema/manager/OpenSearchSchemaManager.java
Outdated
Show resolved
Hide resolved
...ist/els-schema/src/main/java/io/camunda/tasklist/schema/manager/OpenSearchSchemaManager.java
Outdated
Show resolved
Hide resolved
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors and simplifies the index settings management in Tasklist.
The main focus is was extracting the index settings update logic out of the
createSchemathat handles creating missing indices, templates and aliasesNow it is part of
updateIndexSettingsthat makes sure that the number of replicas (for indices and component template) and shards (only in component template) are dynamically updated with the values from the configurationIf fixes 2 things:
Description
Checklist
Related issues
closes #31238
relates to #32872