Skip to content

Prevent finished instances operations #36305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 7, 2025
Merged

Prevent finished instances operations #36305

merged 5 commits into from
Aug 7, 2025

Conversation

vitorwtavares
Copy link
Contributor

Description

  • Prevents finished instances to allow operations like Canceling and Retrying (disabled buttons on batch modifications);
  • Handles a selection of mixed running and finished instances to only perform the desired operations on running instances;
  • Adds disclaimer that finished process instances will be ignored for the purposes of the selected operation on the Apply Operation modal.

Checklist

Related issues

closes #32971

@vitorwtavares vitorwtavares self-assigned this Jul 31, 2025
@vitorwtavares vitorwtavares added kind/bug Categorizes an issue or PR as a bug component/operate Related to the Operate component/team component/frontend Related to a frontend component labels Jul 31, 2025
@vitorwtavares vitorwtavares requested a review from pedesen July 31, 2025 22:21
@vitorwtavares vitorwtavares changed the title 32971 prevent finished instances operations Prevent finished instances operations Jul 31, 2025
@vitorwtavares vitorwtavares force-pushed the 32971-prevent-finished-instances-operations branch from a72f7a1 to 8e461b5 Compare August 5, 2025 23:49
pedesen
pedesen requested changes Aug 6, 2025
View reviewed changes
Copy link
Contributor

@pedesen pedesen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, there is just one issue about the runningInstancesCount (see comment).

@vitorwtavares vitorwtavares force-pushed the 32971-prevent-finished-instances-operations branch from 8e461b5 to 3099c4e Compare August 6, 2025 19:19
@vitorwtavares vitorwtavares requested a review from pedesen August 6, 2025 19:29
pedesen
pedesen approved these changes Aug 7, 2025
View reviewed changes
@vitorwtavares vitorwtavares added this pull request to the merge queue Aug 7, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 7, 2025
@vitorwtavares vitorwtavares added this pull request to the merge queue Aug 7, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 7, 2025
@vitorwtavares vitorwtavares force-pushed the 32971-prevent-finished-instances-operations branch from 3099c4e to d1a22f4 Compare August 7, 2025 18:25
@vitorwtavares vitorwtavares enabled auto-merge August 7, 2025 18:33
@vitorwtavares vitorwtavares added this pull request to the merge queue Aug 7, 2025
Merged via the queue into main with commit dccc9b4 Aug 7, 2025
83 checks passed
@vitorwtavares vitorwtavares deleted the 32971-prevent-finished-instances-operations branch August 7, 2025 19:00
@vitorwtavares vitorwtavares added backport stable/operate-8.5 backport stable/8.6 Backport a pull request to stable/8.6 backport stable/8.7 Backport a pull request to stable/8.7 labels Aug 8, 2025
@vitorwtavares
Copy link
Contributor Author

/backport

@backport-action
Copy link
Collaborator

Created backport PR for stable/operate-8.5:

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-36305-to-stable/operate-8.5
git worktree add --checkout .worktree/backport-36305-to-stable/operate-8.5 backport-36305-to-stable/operate-8.5
cd .worktree/backport-36305-to-stable/operate-8.5
git reset --hard HEAD^
git cherry-pick -x 93c123c8d4a6e45c941f3fbcee5119c6fbadd077 95c73d5e03b9a3521bf7f0d8e02863e3e988a31b 6f054a5dafb19b76ed862a750a7f9b01eaa00395 39688f7c62c38948dc3a5b97ad87451d1cea2e76 d1a22f48e9c458807b888a7837cadbbe7ab30bbf
git push --force-with-lease

This was referenced Aug 8, 2025
Closed
Closed
@backport-action
Copy link
Collaborator

Created backport PR for stable/8.6:

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-36305-to-stable/8.6
git worktree add --checkout .worktree/backport-36305-to-stable/8.6 backport-36305-to-stable/8.6
cd .worktree/backport-36305-to-stable/8.6
git reset --hard HEAD^
git cherry-pick -x 93c123c8d4a6e45c941f3fbcee5119c6fbadd077 95c73d5e03b9a3521bf7f0d8e02863e3e988a31b 6f054a5dafb19b76ed862a750a7f9b01eaa00395 39688f7c62c38948dc3a5b97ad87451d1cea2e76 d1a22f48e9c458807b888a7837cadbbe7ab30bbf
git push --force-with-lease

@backport-action
Copy link
Collaborator

Created backport PR for stable/8.7:

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-36305-to-stable/8.7
git worktree add --checkout .worktree/backport-36305-to-stable/8.7 backport-36305-to-stable/8.7
cd .worktree/backport-36305-to-stable/8.7
git reset --hard HEAD^
git cherry-pick -x 93c123c8d4a6e45c941f3fbcee5119c6fbadd077 95c73d5e03b9a3521bf7f0d8e02863e3e988a31b 6f054a5dafb19b76ed862a750a7f9b01eaa00395 39688f7c62c38948dc3a5b97ad87451d1cea2e76 d1a22f48e9c458807b888a7837cadbbe7ab30bbf
git push --force-with-lease

@backport-action backport-action mentioned this pull request Aug 8, 2025
Closed
This was referenced Aug 8, 2025
Merged
Merged
Merged
github-merge-queue bot pushed a commit that referenced this pull request Aug 13, 2025
@vitorwtavares
feat: backport changes from 36305 to stable 8.7 (#36633)
a209ba6 
## Description

backport #36305 to 8.7

## Checklist

<!--- Please delete options that are not relevant. Boxes should be
checked by reviewer. -->
- [ ] Enable backports when necessary (fex. [for bug
fixes](https://github.com/camunda/camunda/blob/main/CONTRIBUTING.md#backporting-changes)
or [for CI
changes](https://github.com/camunda/camunda/wiki/CI-&-Automation#when-to-backport-ci-changes)).

## Related issues

backport for #36305
vitorwtavares added a commit that referenced this pull request Aug 13, 2025
@vitorwtavares
feat: backport changes from 36305 to stable operate-8.5 (#36637)
337b62d 
## Description

backport #36305 to operate-8.5

## Checklist

<!--- Please delete options that are not relevant. Boxes should be
checked by reviewer. -->
- [ ] Enable backports when necessary (fex. [for bug
fixes](https://github.com/camunda/camunda/blob/main/CONTRIBUTING.md#backporting-changes)
or [for CI
changes](https://github.com/camunda/camunda/wiki/CI-&-Automation#when-to-backport-ci-changes)).

## Related issues

backport for #36305
github-merge-queue bot pushed a commit that referenced this pull request Aug 13, 2025
@vitorwtavares
feat: backport changes from 36305 to stable 8.6 (#36634)
f6bf543 
## Description

backport #36305 to 8.6

## Checklist

<!--- Please delete options that are not relevant. Boxes should be
checked by reviewer. -->
- [ ] Enable backports when necessary (fex. [for bug
fixes](https://github.com/camunda/camunda/blob/main/CONTRIBUTING.md#backporting-changes)
or [for CI
changes](https://github.com/camunda/camunda/wiki/CI-&-Automation#when-to-backport-ci-changes)).

## Related issues

backport for #36305
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedesen pedesen pedesen approved these changes

Assignees

@vitorwtavares vitorwtavares

Labels
backport stable/operate-8.5 backport stable/8.6 Backport a pull request to stable/8.6 backport stable/8.7 Backport a pull request to stable/8.7 component/frontend Related to a frontend component component/operate Related to the Operate component/team kind/bug Categorizes an issue or PR as a bug version:8.7.11
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Retry and cancel options can apply in all the processes via the operations menu.
3 participants
@vitorwtavares @backport-action @pedesen