Fixes InvalidArgumentException (#16362) #18763
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…able in a loadInto call
markstory
reviewed
Jun 27, 2025
Comment on lines
+6382
to
+6383
| $expected = $table->get(2, contain: ['Articles.Authors']); | ||
| $this->assertEquals($expected, $entity); |
There was a problem hiding this comment.
Should we also have an assertion on the contained associations being present in both results?
|
shoudln't this go into 4.x and get merged upstream or will this be backported to 4.x? |
|
If it exists in main, we usually always fix first there, and then backport where needed. |
markstory
pushed a commit
that referenced
this pull request
Jul 4, 2025
* Fixes InvalidArgumentException when joining and containing the same table in a loadInto call * Fix phpcs Errors * Add assertions on article and author in TableTest::testloadBelongsToDoubleJoin --------- Co-authored-by: Erik Nagelkerke <erik.nagelkerke@centerdata.nl>
markstory
added a commit
that referenced
this pull request
Jul 7, 2025
* Fixes InvalidArgumentException (#16362) (#18763) * Fixes InvalidArgumentException when joining and containing the same table in a loadInto call * Fix phpcs Errors * Add assertions on article and author in TableTest::testloadBelongsToDoubleJoin --------- Co-authored-by: Erik Nagelkerke <erik.nagelkerke@centerdata.nl> * Fix finder syntax --------- Co-authored-by: Eriknag <inirva@gmail.com> Co-authored-by: Erik Nagelkerke <erik.nagelkerke@centerdata.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also came across the issue described in #16362
The error happens when you contain a table that was joined earlier on.
In my case the join was added in the findAll method and performed a check on deleted items.
E.g. When an article is set to deleted I want to prevent it's comments from being loaded as well.
And later on, when I used loadInto, it gave the exception.
It also happens when you add a join in the contain options, so that's how I decided to test it.