feat: add support to filter commit msgs by prefixes #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some teams do not expect a version bump when a README gets updated with a docs prefix commit or a style change. To allow that flexibility, this commit introduces a commit-prefix flag that can take multiple values to filter out commit logs before being used to calculate the next semver
|
@caarlos0 Please see if you want to merge this :) |
|
@caarlos0 Checking in again. Would you be interested to merge this ? |
|
sorry, totally missed this |
|
thanks for the pr! |
caarlos0
reviewed
Nov 19, 2021
| @@ -40,3 +41,29 @@ func FindNext(current *semver.Version, forcePatchIncrement bool, log string) sem | |||
|
|
|||
| return *current | |||
| } | |||
|
|
|||
| func FilterCommits(log string, prefixes []string) string { | |||
| lines := strings.Split(log, "\n") | |||
There was a problem hiding this comment.
this doesn't really work, as commit msgs are multi-lined 🤔
hbk619
added a commit
to hbk619/svu
that referenced
this pull request
Oct 25, 2022
Svu searches across the entire git log for commits which is inconvenient when there are multiple packages in one repo (a monorepo). There are a few ways we could handle this: * We could filter commit messages by a specific prefix, which requires users to use the prefix in their commits and as commits are multiple lines[1] is more complicated to implement than first seems * We could add the files to the commit log and search through that, but again is more complicated than it seems * Use git logs ability to filter by directory (this commit) * some other idea I've not thought of [1] caarlos0#45
hbk619
added a commit
to hbk619/svu
that referenced
this pull request
Oct 26, 2022
Svu searches across the entire git log for commits which is inconvenient when there are multiple packages in one repo (a monorepo). There are a few ways we could handle this: * We could filter commit messages by a specific prefix, which requires users to use the prefix in their commits and as commits are multiple lines[1] is more complicated to implement than first seems * We could add the files to the commit log and search through that, but again is more complicated than it seems * Use git logs ability to filter by directory (this commit) * some other idea I've not thought of [1] caarlos0#45
hbk619
added a commit
to hbk619/svu
that referenced
this pull request
May 10, 2023
Svu searches across the entire git log for commits which is inconvenient when there are multiple packages in one repo (a monorepo). There are a few ways we could handle this: * We could filter commit messages by a specific prefix, which requires users to use the prefix in their commits and as commits are multiple lines[1] is more complicated to implement than first seems * We could add the files to the commit log and search through that, but again is more complicated than it seems * Use git logs ability to filter by directory (this commit) * some other idea I've not thought of [1] caarlos0#45
caarlos0
pushed a commit
that referenced
this pull request
May 10, 2023
Svu searches across the entire git log for commits which is inconvenient when there are multiple packages in one repo (a monorepo). There are a few ways we could handle this: * We could filter commit messages by a specific prefix, which requires users to use the prefix in their commits and as commits are multiple lines[1] is more complicated to implement than first seems * We could add the files to the commit log and search through that, but again is more complicated than it seems * Use git logs ability to filter by directory (this commit) * some other idea I've not thought of [1] #45
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some teams do not expect a version bump when a README gets updated with a docs prefix commit or a style change.
To allow that flexibility, this commit introduces a commit-prefix flag that can take multiple values to filter out commit logs before being used to calculate the next semver