Do not warn for "cache" option #1476
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wouldn't that require changing https://github.com/jdemeyer/cython/blob/a712a4904e4836a49caf56317a67284942417acb/Cython/Build/Dependencies.py#L883 as well? |
I don't see why because it also goes through |
|
I was thinking that it could be set, but equal to None. But looks like we have a special case for this at cython/Cython/Compiler/Main.py Line 573 in ed0f978 |
sageb0t
pushed a commit
to sagemath/sage-archive-2023-02-01
that referenced
this pull request
Oct 21, 2016
In `src/setup.py`, we should not run `cythonize()` manually. It would be better to use a custom `build_ext` command for that. This is inspired by the `build_ext` from Cython 0.25: https://github.com /cython/cython/blob/master/Cython/Distutils/build_ext.py Unfortunately, we cannot really use that since it doesn't allow to pass options to `cythonize()`. Due to a [cython/cython#1476 Cython bug], this warning gets displayed even though the `cache` option is valid: {{{UserWarning: got unknown compilation option, please remove: cache}}}. URL: https://trac.sagemath.org/21600 Reported by: jdemeyer Ticket author(s): Jeroen Demeyer Reviewer(s): Matthias Koeppe, Erik Bray
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get rid of the warning
when calling
cythonize(..., cache=something).