Clarify performance hint wording #5883
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm getting the impression that it this performance hint isn't sufficiently clear about what it wants you to modify.
matusvalo
reviewed
Nov 30, 2023
Co-authored-by: Matus Valo <matusvalo@users.noreply.github.com>
matusvalo
approved these changes
Nov 30, 2023
scoder
reviewed
Nov 30, 2023
scoder
reviewed
Nov 30, 2023
Cython/Compiler/PyrexTypes.py
Outdated
| on_what = "on '%s' " % function_name if function_name else "" | ||
| def write_noexcept_performance_hint(pos, env, function_name=None, void_return=False, is_call=False): | ||
| if is_call: | ||
| on_what = "after calling '%s' " % (function_name or 'function') |
There was a problem hiding this comment.
Hmm, this now says "after calling 'function'". :-/ However, since we need the same kind of string below again, it seems best to quote the function name once and then just use it further down.
da-woods
added a commit
that referenced
this pull request
Dec 1, 2023
* Clarify performance hint wording I'm getting the impression that it this performance hint isn't sufficiently clear about what it wants you to modify. * Update Cython/Compiler/PyrexTypes.py Co-authored-by: Matus Valo <matusvalo@users.noreply.github.com> * Simpify implementation * Fiddle with escaping of function_name
|
In 3.0.x as 1db67b9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm getting the impression that it this performance hint isn't sufficiently clear about what it wants you to modify.
(e.g. h5py/h5py#2268 (comment), but I've also seen other people confused by it too)