Fix conflicting enum to_py function with multiple modules #5887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix conflicting names of cpdef enum to_py functions when the an enum with the name name exists in multiple modules. Instead use the cname to name the to_py function since we have already ensured that it is unique and mangled with the module name. Possibly fixes cython#5860 (it definitely fixes a real bug, but that project has far too many dependencies for me to test, so who knows if it fixes *that* bug).
scoder
reviewed
Dec 11, 2023
scoder
reviewed
Dec 11, 2023
da-woods
added a commit
that referenced
this pull request
Dec 11, 2023
Fix conflicting names of cpdef enum to_py functions when the an enum with the name name exists in multiple modules. Instead use the cname to name the to_py function since we have already ensured that it is unique and mangled with the module name. Possibly fixes #5860 (it definitely fixes a real bug, but that project has far too many dependencies for me to test, so who knows if it fixes *that* bug).
|
3.0.x commit e6490a6 |
rinarakaki
pushed a commit
to rinarakaki/cython
that referenced
this pull request
Sep 25, 2024
Fix conflicting names of cpdef enum to_py functions when the an enum with the name name exists in multiple modules. Instead use the cname to name the to_py function since we have already ensured that it is unique and mangled with the module name. Possibly fixes cython#5860 (it definitely fixes a real bug, but that project has far too many dependencies for me to test, so who knows if it fixes *that* bug).
rinarakaki
pushed a commit
to rinarakaki/cython
that referenced
this pull request
Sep 25, 2024
Fix conflicting names of cpdef enum to_py functions when the an enum with the name name exists in multiple modules. Instead use the cname to name the to_py function since we have already ensured that it is unique and mangled with the module name. Possibly fixes cython#5860 (it definitely fixes a real bug, but that project has far too many dependencies for me to test, so who knows if it fixes *that* bug).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix conflicting names of cpdef enum to_py functions when the an enum with the name name exists in multiple modules. Instead use the cname to name the to_py function since we have already ensured that it is unique and mangled with the module name.
Possibly fixes #5860 (it definitely fixes a real bug, but that project has far too many dependencies for me to test, so who knows if it fixes that bug).