Avoid writing non-latin1 module names in the file #5874
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
da-woods
commented
Nov 26, 2023
| @@ -57,19 +48,27 @@ cdef struct S: | |||
| int x | |||
|
|
|||
| cdef public api void cdef_func() # just to test generation of headers | |||
|
|
|||
| ############ 测试.py ############# | |||
There was a problem hiding this comment.
Google translate tells me this translates as "test"
I want to backport this PR so they aren't useful right now
|
We should change the I/O encoding used in EndToEnd tests to UTF-8: |
scoder
pushed a commit
that referenced
this pull request
Nov 28, 2023
… and avoid potentially failing to do so. Closes #5873
|
3.0.x commit: a6fecd0 |
scoder
added a commit
that referenced
this pull request
Nov 28, 2023
This reverts commit a6fecd0. Reverted due to missing changes that are currently only available in Cython 3.1.
|
Could we pick the fix but not the test into 3.0.x? I think it's only writing the test output that's the problem and there's no reason not to have the fix? |
scoder
added a commit
that referenced
this pull request
Nov 29, 2023
…ils in the stable 3.0 branch for other reasons). Closes #5873
Done in 6ec1291 |
clrpackages
pushed a commit
to clearlinux-pkgs/pypi-cython
that referenced
this pull request
Dec 22, 2023
…on 3.0.7
Stefan Behnel (10):
Set the encoding used in EndToEnd tests to UTF-8 on all platforms since we read it from a pipe anyway and don't want to care about platform specific encoding issues.
Revert "Avoid writing non-latin1 module names in the file (GH-5874)"
Revert "Set the encoding used in EndToEnd tests to UTF-8 on all platforms since we read it from a pipe anyway and don't want to care about platform specific encoding issues."
Manually apply the safe fix from cython/cython#5874 but without the test (which fails in the stable 3.0 branch for other reasons).
Fix a set usage bug in Errors.warn_once().
Update changelog.
Update changelog.
Update changelog.
Prepare release of 3.0.7.
Update changelog.
da-woods (6):
Avoid writing non-latin1 module names in the file (GH-5874)
Clarify performance hint wording (#5883)
Fix an issue trying list.index indexing in FusedNode (#5896)
Fix some exceptions in the unicode cimports (#5902)
Fix conflicting enum to_py function with multiple modules (#5887)
Fix await/yield/yield from in genexpression iteration (GH-5898)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5873