Use static const for next/prior from C++11 #77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trying to form next/prior in constant evaluation may be ill-formed; see boostorg#69
| @@ -56,7 +56,8 @@ struct AUX_WRAPPER_NAME | |||
| // have to #ifdef here: some compilers don't like the 'N + 1' form (MSVC), | |||
| // while some other don't like 'value + 1' (Borland), and some don't like | |||
| // either | |||
| #if BOOST_WORKAROUND(__EDG_VERSION__, <= 243) | |||
| #if BOOST_WORKAROUND(__EDG_VERSION__, <= 243) \ | |||
| || __cplusplus >= 201703L | |||
There was a problem hiding this comment.
I believe the warning is active from C++11 and onwards.
There was a problem hiding this comment.
Changed, thanks. I was following someone's comment here llvm/llvm-project#50055 (comment) ;)
There was a problem hiding this comment.
Yep, technically this has moved from "unspecified behavior" in <=C++14 to "undefined behavior" in C++17 onwards. But the LLVM implementation warns starting on C++11. Not sure what the correct behavior would be (is there any?), but that's how it works today :)
Apply change since C++11
Merged
10 tasks
7 tasks
This was referenced Aug 16, 2024
ktrushin
pushed a commit
to percona/percona-server-mongodb
that referenced
this pull request
Nov 2, 2024
Trying to form next/prior in constant evaluation may be ill-formed; see boostorg/mpl#69 Note: the patch source is boostorg/mpl#77 Please also see boostorg/mpl#69
ktrushin
pushed a commit
to percona/percona-server-mongodb
that referenced
this pull request
Nov 4, 2024
Trying to form next/prior in constant evaluation may be ill-formed; see boostorg/mpl#69 Note: the patch source is boostorg/mpl#77 Please also see boostorg/mpl#69
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to form next/prior in constant evaluation may be ill-formed. Fixes #69.