-
Notifications
You must be signed in to change notification settings - Fork 37.7k
Workaround Travis-side CI issues #7487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Currently Travis's wget fails fetching qrencode: Fetching qrencode... ERROR: no certificate subject alternative name matches requested host name `fukuchi.org'. To connect to fukuchi.org insecurely, use `--no-check-certificate'. OpenSSL: error:14077438:SSL routines:SSL23_GET_SERVER_HELLO:tlsv1 alert internal error Unable to establish SSL connection. make: *** [/home/travis/build/luke-jr/bitcoin/depends/sources/download-stamps/.stamp_fetched-qrencode-qrencode-3.4.4.tar.bz2.hash] Error 4
What wonders me most is why it won't try the fallback URL |
Not sure, but even if it did, it would fail. Note the second commit I had to add for the OSX SDK on bitcoincore.org :/ |
Why is the MacOSX SDK download broken too? I don't think I understand what is the issue here. Is that site irrevocably broken, or is there some certificate issue? (e.g. missing ca-certificates package?) But in that case you'd expect any tool to fail. Switching to another tool is possible but I'd like to know what is wrong first. It seems like a heavy-handed solution. @theuni any idea? |
Seems to be a wget bug in the ancient 12.02 Ubuntu that Travis uses. But I could be wrong. |
Bleh. We need 14.04 support for other reasons too (e.g. c++11). |
It looks like 14.04 is possible, but... only be losing IPv6 localhost support [again]. :/ |
concept ACK |
Note: curl needs -L to follow redirects. |
…[on HTTP error response] with curl
This fixes the Travis-side CI issues: https://travis-ci.org/luke-jr/bitcoin/builds/108146026 |
utACK, agree on using curl |
@@ -1,2 +1,2 @@ | |||
build_linux_SHA256SUM = sha256sum | |||
build_linux_DOWNLOAD = wget --timeout=$(DOWNLOAD_CONNECT_TIMEOUT) --tries=$(DOWNLOAD_RETRIES) -nv -O | |||
build_linux_DOWNLOAD = curl --location --fail --connect-timeout $(DOWNLOAD_CONNECT_TIMEOUT) --retry $(DOWNLOAD_RETRIES) -L -o |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it required to set --location
and -L
?
utACK c01f08d |
149641e Travis: Use Blue Box VMs for IPv6 loopback support (Luke Dashjr) c01f08d Bugfix: depends/Travis: Use --location (follow redirects) and --fail [on HTTP error response] with curl (Luke Dashjr) 5d1148c Travis: Use curl rather than wget for Mac SDK (Luke Dashjr) 1ecbb3b depends: Use curl for fetching on Linux (Luke Dashjr)
Github-Pull: bitcoin#7487 Rebased-From: 149641e c01f08d 5d1148c 1ecbb3b
Github-Pull: bitcoin#7487 Rebased-From: 149641e c01f08d 5d1148c 1ecbb3b
Github-Pull: bitcoin#7487 Rebased-From: 149641e c01f08d 5d1148c 1ecbb3b --- Removed sudo, dist and group, because we are on a different box.
* Fix url in .travis.yml Github-Pull: bitcoin#7136 Rebased-From: 9999cb0 * Workaround Travis-side CI issues Github-Pull: bitcoin#7487 Rebased-From: 149641e c01f08d 5d1148c 1ecbb3b * [depends] builders: No need to set -L and --location for curl Github-Pull: bitcoin#7606 Rebased-From: fa7a5c5 * Bugfix: gitian: Add curl to packages (now needed for depends) Conflicts: contrib/gitian-descriptors/gitian-osx.yml Github-Pull: bitcoin#7614 Rebased-From: 5c70a6d
Darwin build fixes Includes fixes cherry-picked from the following upstream PRs: - bitcoin/bitcoin#7136 - Only the third commit (to avoid a merge conflict) - bitcoin/bitcoin#7302 - Excluding the first commit, which is unnecessary (we use Boost 1.62) - bitcoin/bitcoin#7487 - bitcoin/bitcoin#7606 - bitcoin/bitcoin#7711 - bitcoin/bitcoin#7165 - bitcoin/bitcoin#8002 - bitcoin/bitcoin#8210 - Only the second commit - bitcoin/bitcoin#9114
Darwin build fixes Includes fixes cherry-picked from the following upstream PRs: - bitcoin/bitcoin#7136 - Only the third commit (to avoid a merge conflict) - bitcoin/bitcoin#7302 - Excluding the first commit, which is unnecessary (we use Boost 1.62) - bitcoin/bitcoin#7487 - bitcoin/bitcoin#7606 - bitcoin/bitcoin#7711 - bitcoin/bitcoin#7165 - bitcoin/bitcoin#8002 - bitcoin/bitcoin#8210 - Only the second commit - bitcoin/bitcoin#9114
Darwin build fixes Includes fixes cherry-picked from the following upstream PRs: - bitcoin/bitcoin#7136 - Only the third commit (to avoid a merge conflict) - bitcoin/bitcoin#7302 - Excluding the first commit, which is unnecessary (we use Boost 1.62) - bitcoin/bitcoin#7487 - bitcoin/bitcoin#7606 - bitcoin/bitcoin#7711 - bitcoin/bitcoin#7165 - bitcoin/bitcoin#8002 - bitcoin/bitcoin#8210 - Only the second commit - bitcoin/bitcoin#9114
Currently Travis's wget fails fetching qrencode: