Skip to content

Conversation

luke-jr
Copy link
Member

@luke-jr luke-jr commented Feb 9, 2016

Currently Travis's wget fails fetching qrencode:

Fetching qrencode...
ERROR: no certificate subject alternative name matches
    requested host name `fukuchi.org'.
To connect to fukuchi.org insecurely, use `--no-check-certificate'.
OpenSSL: error:14077438:SSL routines:SSL23_GET_SERVER_HELLO:tlsv1 alert internal error
Unable to establish SSL connection.
make: *** [/home/travis/build/luke-jr/bitcoin/depends/sources/download-stamps/.stamp_fetched-qrencode-qrencode-3.4.4.tar.bz2.hash] Error 4

Currently Travis's wget fails fetching qrencode:

Fetching qrencode...
ERROR: no certificate subject alternative name matches
	requested host name `fukuchi.org'.
To connect to fukuchi.org insecurely, use `--no-check-certificate'.
OpenSSL: error:14077438:SSL routines:SSL23_GET_SERVER_HELLO:tlsv1 alert internal error
Unable to establish SSL connection.
make: *** [/home/travis/build/luke-jr/bitcoin/depends/sources/download-stamps/.stamp_fetched-qrencode-qrencode-3.4.4.tar.bz2.hash] Error 4
@laanwj
Copy link
Member

laanwj commented Feb 9, 2016

What wonders me most is why it won't try the fallback URL

@luke-jr
Copy link
Member Author

luke-jr commented Feb 9, 2016

Not sure, but even if it did, it would fail. Note the second commit I had to add for the OSX SDK on bitcoincore.org :/

@laanwj
Copy link
Member

laanwj commented Feb 9, 2016

Why is the MacOSX SDK download broken too?

I don't think I understand what is the issue here. Is that site irrevocably broken, or is there some certificate issue? (e.g. missing ca-certificates package?) But in that case you'd expect any tool to fail.

Switching to another tool is possible but I'd like to know what is wrong first. It seems like a heavy-handed solution.

@theuni any idea?

@luke-jr
Copy link
Member Author

luke-jr commented Feb 9, 2016

Seems to be a wget bug in the ancient 12.02 Ubuntu that Travis uses. But I could be wrong.

@laanwj
Copy link
Member

laanwj commented Feb 9, 2016

Bleh. We need 14.04 support for other reasons too (e.g. c++11).

@luke-jr
Copy link
Member Author

luke-jr commented Feb 9, 2016

It looks like 14.04 is possible, but... only be losing IPv6 localhost support [again]. :/

@dcousens
Copy link
Contributor

dcousens commented Feb 9, 2016

concept ACK

@luke-jr
Copy link
Member Author

luke-jr commented Feb 9, 2016

Note: curl needs -L to follow redirects.

@luke-jr
Copy link
Member Author

luke-jr commented Feb 10, 2016

This fixes the Travis-side CI issues: https://travis-ci.org/luke-jr/bitcoin/builds/108146026

@luke-jr luke-jr changed the title depends: Use curl for fetching on Linux Workaround Travis-side CI issues Feb 10, 2016
@btcdrak
Copy link
Contributor

btcdrak commented Feb 10, 2016

utACK, agree on using curl

@@ -1,2 +1,2 @@
build_linux_SHA256SUM = sha256sum
build_linux_DOWNLOAD = wget --timeout=$(DOWNLOAD_CONNECT_TIMEOUT) --tries=$(DOWNLOAD_RETRIES) -nv -O
build_linux_DOWNLOAD = curl --location --fail --connect-timeout $(DOWNLOAD_CONNECT_TIMEOUT) --retry $(DOWNLOAD_RETRIES) -L -o
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it required to set --location and -L?

@maflcko
Copy link
Member

maflcko commented Feb 13, 2016

utACK c01f08d

@laanwj laanwj merged commit 149641e into bitcoin:master Feb 15, 2016
laanwj added a commit that referenced this pull request Feb 15, 2016
149641e Travis: Use Blue Box VMs for IPv6 loopback support (Luke Dashjr)
c01f08d Bugfix: depends/Travis: Use --location (follow redirects) and --fail [on HTTP error response] with curl (Luke Dashjr)
5d1148c Travis: Use curl rather than wget for Mac SDK (Luke Dashjr)
1ecbb3b depends: Use curl for fetching on Linux (Luke Dashjr)
maflcko pushed a commit to maflcko/bitcoin-core that referenced this pull request Feb 26, 2016
laanwj pushed a commit that referenced this pull request Mar 1, 2016
laanwj pushed a commit that referenced this pull request Mar 1, 2016
schinzelh pushed a commit to dashpay/dash that referenced this pull request Mar 7, 2016
dexX7 pushed a commit to dexX7/bitcoin that referenced this pull request Apr 24, 2016
Github-Pull: bitcoin#7487
Rebased-From: 149641e c01f08d 5d1148c 1ecbb3b

---

Removed sudo, dist and group, because we are on a different box.
braydonf pushed a commit to braydonf/bitcoin that referenced this pull request May 12, 2016
braydonf pushed a commit to braydonf/bitcoin that referenced this pull request Jun 2, 2016
luke-jr added a commit to bitcoinknots/bitcoin that referenced this pull request Jun 18, 2016
braydonf pushed a commit to braydonf/bitcoin that referenced this pull request Oct 4, 2016
nomnombtc pushed a commit to nomnombtc/bitcoin that referenced this pull request Nov 22, 2016
tempgit9 pushed a commit to tempgit9/bitcoin that referenced this pull request Jan 16, 2017
* Fix url in .travis.yml

Github-Pull: bitcoin#7136
Rebased-From: 9999cb0

* Workaround Travis-side CI issues

Github-Pull: bitcoin#7487
Rebased-From: 149641e c01f08d 5d1148c 1ecbb3b

* [depends] builders: No need to set -L and --location for curl

Github-Pull: bitcoin#7606
Rebased-From: fa7a5c5

* Bugfix: gitian: Add curl to packages (now needed for depends)

Conflicts:
	contrib/gitian-descriptors/gitian-osx.yml
Github-Pull: bitcoin#7614
Rebased-From: 5c70a6d
zkbot added a commit to zcash/zcash that referenced this pull request Nov 30, 2017
Darwin build fixes

Includes fixes cherry-picked from the following upstream PRs:

- bitcoin/bitcoin#7136
  - Only the third commit (to avoid a merge conflict)
- bitcoin/bitcoin#7302
  - Excluding the first commit, which is unnecessary (we use Boost 1.62)
- bitcoin/bitcoin#7487
- bitcoin/bitcoin#7606
- bitcoin/bitcoin#7711
- bitcoin/bitcoin#7165
- bitcoin/bitcoin#8002
- bitcoin/bitcoin#8210
  - Only the second commit
- bitcoin/bitcoin#9114
zkbot added a commit to zcash/zcash that referenced this pull request Nov 30, 2017
Darwin build fixes

Includes fixes cherry-picked from the following upstream PRs:

- bitcoin/bitcoin#7136
  - Only the third commit (to avoid a merge conflict)
- bitcoin/bitcoin#7302
  - Excluding the first commit, which is unnecessary (we use Boost 1.62)
- bitcoin/bitcoin#7487
- bitcoin/bitcoin#7606
- bitcoin/bitcoin#7711
- bitcoin/bitcoin#7165
- bitcoin/bitcoin#8002
- bitcoin/bitcoin#8210
  - Only the second commit
- bitcoin/bitcoin#9114
zkbot added a commit to zcash/zcash that referenced this pull request Nov 30, 2017
Darwin build fixes

Includes fixes cherry-picked from the following upstream PRs:

- bitcoin/bitcoin#7136
  - Only the third commit (to avoid a merge conflict)
- bitcoin/bitcoin#7302
  - Excluding the first commit, which is unnecessary (we use Boost 1.62)
- bitcoin/bitcoin#7487
- bitcoin/bitcoin#7606
- bitcoin/bitcoin#7711
- bitcoin/bitcoin#7165
- bitcoin/bitcoin#8002
- bitcoin/bitcoin#8210
  - Only the second commit
- bitcoin/bitcoin#9114
reddink pushed a commit to reddcoin-project/reddcoin-3.10 that referenced this pull request May 27, 2020
Github-Pull: bitcoin#7487
Rebased-From: 149641e c01f08d 5d1148c 1ecbb3b
(cherry picked from commit 6bf4884)
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants