fix -maxconnections #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s twice when calculating the number of slots left for incoming connections.
msgilligan
pushed a commit
to msgilligan/omnicore
that referenced
this pull request
Jul 17, 2014
Fix TMSC DEx payments
rdponticelli
pushed a commit
to Criptomonedas/bitcoin
that referenced
this pull request
Nov 26, 2014
Update README.md : Travis status
tempgit9
pushed a commit
to tempgit9/bitcoin
that referenced
this pull request
Jan 16, 2017
* Fix url in .travis.yml Github-Pull: bitcoin#7136 Rebased-From: 9999cb0 * Workaround Travis-side CI issues Github-Pull: bitcoin#7487 Rebased-From: 149641e c01f08d 5d1148c 1ecbb3b * [depends] builders: No need to set -L and --location for curl Github-Pull: bitcoin#7606 Rebased-From: fa7a5c5 * Bugfix: gitian: Add curl to packages (now needed for depends) Conflicts: contrib/gitian-descriptors/gitian-osx.yml Github-Pull: bitcoin#7614 Rebased-From: 5c70a6d
yes-maxheart
referenced
this pull request
in xpc-wg/xpchain
Dec 16, 2018
Update translation source & ja translation
Warchant
referenced
this pull request
in VeriBlock/vbk-ri-btc
Dec 31, 2019
* update popservice methods * update submodule * small change
velesnetwork
referenced
this pull request
in velescore/veles
Jan 12, 2020
The Veles Core 0.18.0 "Blockchain Barracuda"
maflcko
pushed a commit
that referenced
this pull request
Nov 18, 2020
…::Decrypt 4146a31 qt, wallet: Drop unused parameter in WalletModel::setWalletEncrypted (Hennadii Stepanov) f886a20 qt, wallet: Drop unused parameter in Wallet{Frame|View}::encryptWallet (Hennadii Stepanov) 6e95011 qt, wallet: Remove unused AskPassphraseDialog::Decrypt (Hennadii Stepanov) Pull request description: Grabbed from #42 with an additional commit. Fix #1. ACKs for top commit: MarcoFalke: ACK 4146a31 promag: Code review ACK 4146a31. Tree-SHA512: 6070d8995525af826ad972cf1b8988ff98af0528eef285a07ec7ba0e2e92a7a6173a19dc371de94d4b437fa10f7921166e45a081de6ed2f4306e6502aafc94ee
maflcko
referenced
this pull request
in maflcko/bitcoin-core
Dec 8, 2020
b5ef9be675 Merge #1: Merge changes from upstream 9e7f512430 Merge remote-tracking branch 'origin/master' into bitcoin-fork 1f85030246 Add support for ARM64 darwin (#43) 3bb959c982 Remove unnecessary reinterpret_cast (#42) 2e97ab26b1 Fix (unused) ReadUint64LE for BE machines (#41) 47b40d2209 Bump dependencies. (#40) ba74185625 Move CI to Visual Studio 2019. efa301a7e5 Allow different C/C++ standards when this is used as a subproject. cc6d71465e CMake: Use configure_package_config_file() git-subtree-dir: src/crc32c git-subtree-split: b5ef9be6755a2e61e2988bb238f13d1c0ee1fa0a
satindergrewal
pushed a commit
to chips-blockchain/chipschain
that referenced
this pull request
Jun 22, 2021
update build script
rajarshimaitra
pushed a commit
to rajarshimaitra/bitcoin
that referenced
this pull request
Aug 5, 2021
* Fix typo * Better fix
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The -maxconnections=N command line argument is meant to limit the total number of connections to N. It reserves 8 (or less, if N<8) slots for outgoing connections, and is meant to allow N-8 incoming connections. But the calculation is slightly wrong, and the existing outgoing connections are counted twice.
This fixes it.