typofix - https://github.com/vlajos/misspell_fixer #6539
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
utACK, looks simple and a good bit of cleanup |
| @@ -870,7 +870,7 @@ HTML_FILE_EXTENSION = .html | |||
| # standard header. Note that when using a custom header you are responsible | |||
| # for the proper inclusion of any scripts and style sheets that doxygen | |||
| # needs, which is dependent on the configuration options used. | |||
| # It is adviced to generate a default header using "doxygen -w html | |||
| # It is advised to generate a default header using "doxygen -w html | |||
There was a problem hiding this comment.
Don't change this, it will be fixed if/when we update the Doxyfile.
e02430e to
66d9378
Compare
|
Done.. I have just reverted doc/release-notes and doc/Doxyfile. |
| @@ -225,7 +225,7 @@ QT_TRANSLATE_NOOP("bitcoin-core", "Error loading wallet.dat: Wallet requires new | |||
| QT_TRANSLATE_NOOP("bitcoin-core", "Error opening block database"), | |||
| QT_TRANSLATE_NOOP("bitcoin-core", "Error reading from database, shutting down."), | |||
| QT_TRANSLATE_NOOP("bitcoin-core", "Error"), | |||
| QT_TRANSLATE_NOOP("bitcoin-core", "Error: A fatal internal error occured, see debug.log for details"), | |||
| QT_TRANSLATE_NOOP("bitcoin-core", "Error: A fatal internal error occurred, see debug.log for details"), | |||
There was a problem hiding this comment.
This won't work as bitcoinstrings.cpp is generated during build. You need to fix the spelling just in the "normal" source.
66d9378 to
a1f066e
Compare
| @@ -71,7 +71,7 @@ | |||
|
|
|||
| #if defined(OS_ANDROID) && __ANDROID_API__ < 9 | |||
| // fdatasync() was only introduced in API level 9 on Android. Use fsync() | |||
| // when targetting older platforms. | |||
There was a problem hiding this comment.
Please don't change the files inside src/leveldb - they come verbatim from upstream, merging this change would make it harder to keep the subtree up to date
There was a problem hiding this comment.
OK. I have removed these 2 changes.
|
Looks good to me, apart form leveldb nit |
a1f066e to
ed4f03c
Compare
|
Also please remove the URL from the commit message. |
ed4f03c to
9f68ed6
Compare
|
I have removed the URL. |
|
ACK |
|
ACK |
1 similar comment
|
ACK |
laanwj
added a commit
that referenced
this pull request
Aug 19, 2015
9f68ed6 typofixes (found by misspell_fixer) (Veres Lajos)
luke-jr
pushed a commit
to luke-jr/bitcoin
that referenced
this pull request
Sep 21, 2015
Upstream: 9f68ed6 (PR bitcoin#6539)
luke-jr
pushed a commit
to luke-jr/bitcoin
that referenced
this pull request
Sep 22, 2015
Upstream: 9f68ed6 (PR bitcoin#6539)
luke-jr
pushed a commit
to luke-jr/bitcoin
that referenced
this pull request
Oct 15, 2015
Upstream: 9f68ed6 (PR bitcoin#6539)
luke-jr
pushed a commit
to luke-jr/bitcoin
that referenced
this pull request
Oct 15, 2015
Upstream: 9f68ed6 (PR bitcoin#6539)
luke-jr
pushed a commit
to luke-jr/bitcoin
that referenced
this pull request
Jan 9, 2016
Github-Pull: bitcoin#6539 Rebased-From: 9f68ed6
luke-jr
pushed a commit
to luke-jr/bitcoin
that referenced
this pull request
Jan 10, 2016
Github-Pull: bitcoin#6539 Rebased-From: 9f68ed6
schinzelh
referenced
this pull request
in schinzelh/dash
Jan 16, 2016
Upstream: 9f68ed6 (PR dashpay#6539)
braydonf
added a commit
to braydonf/bcoin
that referenced
this pull request
Feb 2, 2019
References: - bitcoin/bitcoin#11423 - bitcoin/bitcoin#12600 - bitcoin/bitcoin#12082 Trivial References: - bitcoin/bitcoin#12393 - bitcoin/bitcoin#6539 - bitcoin/bitcoin#10742 - bitcoin/bitcoin@ecb11f5
braydonf
added a commit
to braydonf/bcoin
that referenced
this pull request
Feb 2, 2019
References: - bitcoin/bitcoin#11423 - bitcoin/bitcoin#12600 - bitcoin/bitcoin#12082 Trivial References: - bitcoin/bitcoin#12393 - bitcoin/bitcoin#6539 - bitcoin/bitcoin#10742 - bitcoin/bitcoin@ecb11f5
tuxcanfly
pushed a commit
to tuxcanfly/bcoin
that referenced
this pull request
Apr 19, 2019
References: - bitcoin/bitcoin#11423 - bitcoin/bitcoin#12600 - bitcoin/bitcoin#12082 Trivial References: - bitcoin/bitcoin#12393 - bitcoin/bitcoin#6539 - bitcoin/bitcoin#10742 - bitcoin/bitcoin@ecb11f5
reddink
pushed a commit
to reddcoin-project/reddcoin-3.10
that referenced
this pull request
May 27, 2020
Upstream: 9f68ed6 (PR bitcoin#6539) (cherry picked from commit ceba0f8)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.