Skip to content

Adding test case for SINGLE|ANYONECANPAY hash type in tx_valid.json #12082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 11, 2018
Merged

Adding test case for SINGLE|ANYONECANPAY hash type in tx_valid.json #12082

merged 1 commit into from
Jan 11, 2018

Conversation

Christewart
Copy link
Contributor

We are missing a test vector for SINGLE|ANYONECANPAY inside of tx_valid.json. This addresses the issue #12060

@Christewart
Copy link
Contributor Author

Seems like the travis failure is unrelated?

@jnewbery
Copy link
Contributor

jnewbery commented Jan 3, 2018

Seems like the travis failure is unrelated?

Yes, looks like another instance of #11777. I've restarted the job.

@fanquake fanquake added the Tests label Jan 4, 2018
@practicalswift
Copy link
Contributor

Concept ACK! 👍

TheBlueMatt
TheBlueMatt reviewed Jan 11, 2018
View reviewed changes
Copy link
Contributor

@TheBlueMatt TheBlueMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK. At least the signatures decode as [SINGLE|ANYONECANPAY] so no reason not to have more tests.

@maflcko maflcko merged commit 18be3ab into bitcoin:master Jan 11, 2018
maflcko pushed a commit that referenced this pull request Jan 11, 2018
Merge #12082: Adding test case for SINGLE|ANYONECANPAY hash type in t…
0910cbe 
…x_valid.json

18be3ab Adding test case for SINGLE|ANYONECANPAY hash type in tx_valid.json (Chris Stewart)

Pull request description:

  We are missing a test vector for SINGLE|ANYONECANPAY inside of tx_valid.json. This addresses the issue #12060

Tree-SHA512: e3526113477dbf575c4a844cf489dcfa2c037c6d928af6f97413edc1a8d29cdf2143da96471cdfd3de08bf5ed178117ed67926fd70fd42ca391ac0bb0d08f3fd
@maflcko
Copy link
Member

maflcko commented Jan 11, 2018 

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

utACK 18be3ab13964ebdc0bbaf739b2b29aa34de53dc5
-----BEGIN PGP SIGNATURE-----

iQIcBAEBCgAGBQJaV6JTAAoJENLqSFDnUoslIRoP/3NB6Vq1FnCksrUlEoO1ZEVm
+9Ju7o/v7Sz73qeJ6ynOZgrNSQMCsq7V6e2mnWGJj6hG3rhBUdRguqmR06iabt5b
pbsHGghX3g7+E7pI4bbpF4yLf6Bd0FpOWo9YDvCOkLe4QV7XLRBkLY2d2LTYSc57
JV2WQvdfx6UPPpzLJK3gztSLjBy/m18Ij1Edij1THVbpjinObhO5t/1Rs/2QPe8v
9c3CTnF+TaWuWe44U9Ej75mUQWCDm1g2WG+tkKbnUx1C48KC2unx7PdxatDdEs0N
CErqdszTnwF/6XkKDseL5F9bB91As8iJ4c5HDR7ThVxko+ew4M3/mxepkRBOaQZx
1lzx8c070VuBhQghTIUEqFkTVaQFdvtBjcCW2DYOkvrlaPf4nOfIjC11HDUhEZo6
OkJ2Nm+HiFktDW9nG9WnYjr9Wv44k+jLPcjyObpLmIbAPTZ2gzXrqP0XZoBlp0K7
0eWWxX2aPQg+y7oL8GBSiMmRKnVTF/T5pSMB+H/2d3kZurLw5/QyY5GcVUWwrqXx
/Ud106jSIpl/W6qCPKe5WNGeX+Ez0mjC510GbfVyfO2ZnYuoEpRgz5qh+PL0ZCir
WW/YQgrOs47MFm01EJhH68NbLLF2dyehiFudC7s6raIsJzVTdV90+JOJVcYAVvkF
GLCOf83Bx+0MbZ01tINp
=1EnU
-----END PGP SIGNATURE-----

azuchi pushed a commit to chaintope/bitcoinrb that referenced this pull request Jan 12, 2018
Add test case for SINGLE|ANYONECANPAY hash type
c4c91f2 
bitcoin/bitcoin#12082
braydonf added a commit to braydonf/bcoin that referenced this pull request Feb 2, 2019
@braydonf
script: update tx standardness rules and more tx tests
e866da8 
References:
- bitcoin/bitcoin#11423
- bitcoin/bitcoin#12600
- bitcoin/bitcoin#12082

Trivial References:
- bitcoin/bitcoin#12393
- bitcoin/bitcoin#6539
- bitcoin/bitcoin#10742
- bitcoin/bitcoin@ecb11f5
braydonf added a commit to braydonf/bcoin that referenced this pull request Feb 2, 2019
@braydonf
script: update tx standardness rules and more tx tests
efa7810 
References:
- bitcoin/bitcoin#11423
- bitcoin/bitcoin#12600
- bitcoin/bitcoin#12082

Trivial References:
- bitcoin/bitcoin#12393
- bitcoin/bitcoin#6539
- bitcoin/bitcoin#10742
- bitcoin/bitcoin@ecb11f5
@braydonf braydonf mentioned this pull request Feb 2, 2019
Merged
tuxcanfly pushed a commit to tuxcanfly/bcoin that referenced this pull request Apr 19, 2019
@braydonf @tuxcanfly
script: update tx standardness rules and more tx tests
586fef8 
References:
- bitcoin/bitcoin#11423
- bitcoin/bitcoin#12600
- bitcoin/bitcoin#12082

Trivial References:
- bitcoin/bitcoin#12393
- bitcoin/bitcoin#6539
- bitcoin/bitcoin#10742
- bitcoin/bitcoin@ecb11f5
jasonbcox pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this pull request Sep 27, 2019
@Christewart @fpelliccioni
Adding test case for SINGLE|ANYONECANPAY hash type in tx_valid.json
74a94f4 
Summary:
We are missing a test vector for SINGLE|ANYONECANPAY inside of tx_valid.json. This addresses the issue #12060

Backport of Bitcoin Core PR12082
bitcoin/bitcoin#12082

Test Plan:
```
make check-all
```

Reviewers: Fabien, #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D4062
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@TheBlueMatt TheBlueMatt TheBlueMatt left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Christewart @jnewbery @practicalswift @maflcko @TheBlueMatt @fanquake