Move rounding #51
Closed
Move rounding #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! I'd like to make this part of a set of changes for the 0.3.21 release to deal with sub-bitcent amounts consistently across all the RPC methods and in the GUI. |
|
Would it be possible to pull it in for 0.3.20 ? Also is there a way to manually fiddle with account balances other than moving bitcoins around until achievement of desired accounts statuses ? |
|
See: #79 |
|
I pulled the more generic rounding patch. |
kac-
pushed a commit
to kac-/peercoin-ce
that referenced
this pull request
Jun 10, 2014
Update transaction fee text in the "options" dialog
rdponticelli
pushed a commit
to Criptomonedas/bitcoin
that referenced
this pull request
Nov 26, 2014
364fde6 fix unsigned warning in num_gmp_impl.h (caktux)
ptschip
pushed a commit
to ptschip/bitcoin
that referenced
this pull request
Jul 22, 2016
Fix for Debug UI
CryptAxe
pushed a commit
to CryptAxe/bitcoin
that referenced
this pull request
Nov 15, 2017
* changing valid sidechain array to a c++ std::array * remove trailing commas * fixed improper spacing
CryptAxe
pushed a commit
to CryptAxe/bitcoin
that referenced
this pull request
Dec 28, 2017
* changing valid sidechain array to a c++ std::array * remove trailing commas * fixed improper spacing
classesjack
pushed a commit
to classesjack/bitcoin
that referenced
this pull request
Jan 2, 2018
Difficulty update
effectsToCause
added a commit
to vericoin/vericoin
that referenced
this pull request
Jun 22, 2018
Fix key parsing for salvage
satindergrewal
pushed a commit
to chips-blockchain/chipschain
that referenced
this pull request
Jun 22, 2021
check ref. notarization in disconnect tip
rajarshimaitra
pushed a commit
to rajarshimaitra/bitcoin
that referenced
this pull request
Aug 5, 2021
* Stylistic change to Meni Rosenfeld paragraph. Propose to change the word order and a few words to make it easier to read. * removed the word and to make the text shorter
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it's important that the "move" command handles subcent transactions without silently rounding amounts at two decimal places.
It is common in a lot of cases to handle these small amounts (bitcoin central for example).
I want to keep using it as a second security level on bitcoin central, but right now it's not possible because the DB-tracked accounts slowly get out of sync with the bitcoin ones, and at some points transaction get rolled back because some bitcoin account does not have enough funds whereas the DB-tracked one has enough credit to complete the transaction.
If I try to move 0.001 BTC between two accounts I get a "true" returned even though I should have gotten an "Invalid amount" with the previous round-everything approach since nothing would have changed.
With this, rounding is only disabled for the "move" command.