Skip to content

Conversation

fanquake
Copy link
Member

Fixes:

/distsrc-base/distsrc-d3b8a54a8120-x86_64-linux-gnu/build/bin/bitcoind: symbol __divmodti4 from unsupported version GCC_7.0.0(14)
/distsrc-base/distsrc-d3b8a54a8120-x86_64-linux-gnu/build/bin/bitcoind: failed IMPORTED_SYMBOLS

which is occuring after #32750. I can't see any supported distro that is shipping a new enough glibc (2.31), but a GCC older than 7.0.

Fixes #33177.

Fixes:
```bash
/distsrc-base/distsrc-d3b8a54a8120-x86_64-linux-gnu/build/bin/bitcoind: symbol __divmodti4 from unsupported version GCC_7.0.0(14)
/distsrc-base/distsrc-d3b8a54a8120-x86_64-linux-gnu/build/bin/bitcoind: failed IMPORTED_SYMBOLS
```

which is occuring after bitcoin#32750. I can't see any supported distro that is
shipping a new enough glibc (2.31), but a GCC older than 7.0.
@DrahtBot
Copy link
Contributor

DrahtBot commented Aug 12, 2025

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33178.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK hebasto

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

@sipa
Copy link
Member

sipa commented Aug 12, 2025

Makes sense, GCC 7 is from 2017, Glibc 2.31 is from 2020.

@bitcoin bitcoin deleted a comment from Thisdick69 Aug 12, 2025
@fanquake
Copy link
Member Author

Guix Build:

6c40d925b16cf05dad6933cce25c5fd86800b0cb4f947e5cf86f271d028267ae  guix-build-776a16337416/output/aarch64-linux-gnu/SHA256SUMS.part
17b90d50a6f9eb9ca9d5282f3bd85e01d91bcf92ff4980b437df3b98b14ef1a7  guix-build-776a16337416/output/aarch64-linux-gnu/bitcoin-776a16337416-aarch64-linux-gnu-debug.tar.gz
4fcdcad6b02d63b68e213c03552828bd59fd84f86f1d886aeac6b5413170b67e  guix-build-776a16337416/output/aarch64-linux-gnu/bitcoin-776a16337416-aarch64-linux-gnu.tar.gz
7ddf096c6d23c2e1bd9baf845bd36a7da4fcb164f5ca612a86dcc51fb04c56d5  guix-build-776a16337416/output/arm-linux-gnueabihf/SHA256SUMS.part
1513ff292c3bc48e3195fd03a23beba28eebc39c3d58a9efab733bf29b01b940  guix-build-776a16337416/output/arm-linux-gnueabihf/bitcoin-776a16337416-arm-linux-gnueabihf-debug.tar.gz
d4f669abb67e4a393aee37040cd7e67c4eee2db1b4c5a2e04bc71b3176fd528f  guix-build-776a16337416/output/arm-linux-gnueabihf/bitcoin-776a16337416-arm-linux-gnueabihf.tar.gz
d9056c22887d06066de4f6dae3bc547d4ea6e01c1e56576b507a28b6d51f49fb  guix-build-776a16337416/output/arm64-apple-darwin/SHA256SUMS.part
a1cf279bc8fd41c691c68fa27eef5835807df74bfcb12ad04a6ab82261d33f4e  guix-build-776a16337416/output/arm64-apple-darwin/bitcoin-776a16337416-arm64-apple-darwin-codesigning.tar.gz
92d3e3fc63d49f442c62e35318a71390311459f6a77792ee198b387e16c9ada4  guix-build-776a16337416/output/arm64-apple-darwin/bitcoin-776a16337416-arm64-apple-darwin-unsigned.tar.gz
1601fb3c4fc4fbc3068fd86451fdfcd773c6b80b5c2a1ee4fb202099b13b6455  guix-build-776a16337416/output/arm64-apple-darwin/bitcoin-776a16337416-arm64-apple-darwin-unsigned.zip
134539b3596d9252c41ede17c6455423b46be7db06a592b3dd33ec21d4c4ba0b  guix-build-776a16337416/output/dist-archive/bitcoin-776a16337416.tar.gz
8a969c87ab993543f959df482424e05cb3d865d7b347b60c29beb184fa4ea125  guix-build-776a16337416/output/powerpc64-linux-gnu/SHA256SUMS.part
79daf29c9982cfdcda42989aa7a518bb4f8d5a00dc26061e8a54c76fab2f159f  guix-build-776a16337416/output/powerpc64-linux-gnu/bitcoin-776a16337416-powerpc64-linux-gnu-debug.tar.gz
e03c5f6d02267fdfb00b77f6f21aeb1f6811c61dba06fa545028148db80a2226  guix-build-776a16337416/output/powerpc64-linux-gnu/bitcoin-776a16337416-powerpc64-linux-gnu.tar.gz
93a11e8f68543339ae56ee9a91fda8c2e7255b9bbab6b5490d2c17b620d0f8c8  guix-build-776a16337416/output/riscv64-linux-gnu/SHA256SUMS.part
f9a15a01f9d18db7107603196da371b8683c17bd9e5fa610b6f5d2661555e504  guix-build-776a16337416/output/riscv64-linux-gnu/bitcoin-776a16337416-riscv64-linux-gnu-debug.tar.gz
4e737781d4bef661c6beca109fac72e3e9a40860fa2d7532acf09a4a5365e6cb  guix-build-776a16337416/output/riscv64-linux-gnu/bitcoin-776a16337416-riscv64-linux-gnu.tar.gz
13cfaef707a3d1cc2ea288e75cb9c9fa4bfa14f2c29c6c9d166879c914986c20  guix-build-776a16337416/output/x86_64-apple-darwin/SHA256SUMS.part
a4c2b1fed6be581ab46c1c6e75a594cbdee01ee8fd9c045cc2bdbcdce47c43d3  guix-build-776a16337416/output/x86_64-apple-darwin/bitcoin-776a16337416-x86_64-apple-darwin-codesigning.tar.gz
dc0570f403075ac09f79686772b6be87c2627ef98079810e58b727958ca39264  guix-build-776a16337416/output/x86_64-apple-darwin/bitcoin-776a16337416-x86_64-apple-darwin-unsigned.tar.gz
971c7c807838dcce4b8d5c446dd37dce59f5513498a969cc47f56c29941e230a  guix-build-776a16337416/output/x86_64-apple-darwin/bitcoin-776a16337416-x86_64-apple-darwin-unsigned.zip
7f4d0446ca52b2da4e135ab217b51c7b5a89b0e9bc79b3f83fd3fe84cf56e234  guix-build-776a16337416/output/x86_64-linux-gnu/SHA256SUMS.part
8fc616f36098a2a53ebf8eb6aaec1f240ddbc2030914d0b09ab6e34fa2996ed1  guix-build-776a16337416/output/x86_64-linux-gnu/bitcoin-776a16337416-x86_64-linux-gnu-debug.tar.gz
b45c28dd227ab5b86ec661074e1a110aa6fbd7578452ccb6b2828a4a4efdf614  guix-build-776a16337416/output/x86_64-linux-gnu/bitcoin-776a16337416-x86_64-linux-gnu.tar.gz
19bac66e5624c0144af2f5f6753eec834bf1dbc1ac07042b21ffa046d84f53a6  guix-build-776a16337416/output/x86_64-w64-mingw32/SHA256SUMS.part
7b172c5d9874a089c55645989ee552cb43847e38df09f03f1eb9e26cdb963f39  guix-build-776a16337416/output/x86_64-w64-mingw32/bitcoin-776a16337416-win64-codesigning.tar.gz
57f712741682507739b22cad7f7bf925769aa1db03cbca0ab7ca6d80b5df39ff  guix-build-776a16337416/output/x86_64-w64-mingw32/bitcoin-776a16337416-win64-debug.zip
65d462bf3b237c36d71766c0c80cc9aceebb75a531c075040c325205bf178d55  guix-build-776a16337416/output/x86_64-w64-mingw32/bitcoin-776a16337416-win64-setup-unsigned.exe
dd77058d02c4a52fc3928973f567c8ec849f55f20d0821faf7af62f2b747a250  guix-build-776a16337416/output/x86_64-w64-mingw32/bitcoin-776a16337416-win64-unsigned.zip

Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My Guix build:

aarch64
6c40d925b16cf05dad6933cce25c5fd86800b0cb4f947e5cf86f271d028267ae  guix-build-776a16337416/output/aarch64-linux-gnu/SHA256SUMS.part
17b90d50a6f9eb9ca9d5282f3bd85e01d91bcf92ff4980b437df3b98b14ef1a7  guix-build-776a16337416/output/aarch64-linux-gnu/bitcoin-776a16337416-aarch64-linux-gnu-debug.tar.gz
4fcdcad6b02d63b68e213c03552828bd59fd84f86f1d886aeac6b5413170b67e  guix-build-776a16337416/output/aarch64-linux-gnu/bitcoin-776a16337416-aarch64-linux-gnu.tar.gz
7ddf096c6d23c2e1bd9baf845bd36a7da4fcb164f5ca612a86dcc51fb04c56d5  guix-build-776a16337416/output/arm-linux-gnueabihf/SHA256SUMS.part
1513ff292c3bc48e3195fd03a23beba28eebc39c3d58a9efab733bf29b01b940  guix-build-776a16337416/output/arm-linux-gnueabihf/bitcoin-776a16337416-arm-linux-gnueabihf-debug.tar.gz
d4f669abb67e4a393aee37040cd7e67c4eee2db1b4c5a2e04bc71b3176fd528f  guix-build-776a16337416/output/arm-linux-gnueabihf/bitcoin-776a16337416-arm-linux-gnueabihf.tar.gz
d9056c22887d06066de4f6dae3bc547d4ea6e01c1e56576b507a28b6d51f49fb  guix-build-776a16337416/output/arm64-apple-darwin/SHA256SUMS.part
a1cf279bc8fd41c691c68fa27eef5835807df74bfcb12ad04a6ab82261d33f4e  guix-build-776a16337416/output/arm64-apple-darwin/bitcoin-776a16337416-arm64-apple-darwin-codesigning.tar.gz
92d3e3fc63d49f442c62e35318a71390311459f6a77792ee198b387e16c9ada4  guix-build-776a16337416/output/arm64-apple-darwin/bitcoin-776a16337416-arm64-apple-darwin-unsigned.tar.gz
1601fb3c4fc4fbc3068fd86451fdfcd773c6b80b5c2a1ee4fb202099b13b6455  guix-build-776a16337416/output/arm64-apple-darwin/bitcoin-776a16337416-arm64-apple-darwin-unsigned.zip
134539b3596d9252c41ede17c6455423b46be7db06a592b3dd33ec21d4c4ba0b  guix-build-776a16337416/output/dist-archive/bitcoin-776a16337416.tar.gz
8a969c87ab993543f959df482424e05cb3d865d7b347b60c29beb184fa4ea125  guix-build-776a16337416/output/powerpc64-linux-gnu/SHA256SUMS.part
79daf29c9982cfdcda42989aa7a518bb4f8d5a00dc26061e8a54c76fab2f159f  guix-build-776a16337416/output/powerpc64-linux-gnu/bitcoin-776a16337416-powerpc64-linux-gnu-debug.tar.gz
e03c5f6d02267fdfb00b77f6f21aeb1f6811c61dba06fa545028148db80a2226  guix-build-776a16337416/output/powerpc64-linux-gnu/bitcoin-776a16337416-powerpc64-linux-gnu.tar.gz
93a11e8f68543339ae56ee9a91fda8c2e7255b9bbab6b5490d2c17b620d0f8c8  guix-build-776a16337416/output/riscv64-linux-gnu/SHA256SUMS.part
f9a15a01f9d18db7107603196da371b8683c17bd9e5fa610b6f5d2661555e504  guix-build-776a16337416/output/riscv64-linux-gnu/bitcoin-776a16337416-riscv64-linux-gnu-debug.tar.gz
4e737781d4bef661c6beca109fac72e3e9a40860fa2d7532acf09a4a5365e6cb  guix-build-776a16337416/output/riscv64-linux-gnu/bitcoin-776a16337416-riscv64-linux-gnu.tar.gz
13cfaef707a3d1cc2ea288e75cb9c9fa4bfa14f2c29c6c9d166879c914986c20  guix-build-776a16337416/output/x86_64-apple-darwin/SHA256SUMS.part
a4c2b1fed6be581ab46c1c6e75a594cbdee01ee8fd9c045cc2bdbcdce47c43d3  guix-build-776a16337416/output/x86_64-apple-darwin/bitcoin-776a16337416-x86_64-apple-darwin-codesigning.tar.gz
dc0570f403075ac09f79686772b6be87c2627ef98079810e58b727958ca39264  guix-build-776a16337416/output/x86_64-apple-darwin/bitcoin-776a16337416-x86_64-apple-darwin-unsigned.tar.gz
971c7c807838dcce4b8d5c446dd37dce59f5513498a969cc47f56c29941e230a  guix-build-776a16337416/output/x86_64-apple-darwin/bitcoin-776a16337416-x86_64-apple-darwin-unsigned.zip
7f4d0446ca52b2da4e135ab217b51c7b5a89b0e9bc79b3f83fd3fe84cf56e234  guix-build-776a16337416/output/x86_64-linux-gnu/SHA256SUMS.part
8fc616f36098a2a53ebf8eb6aaec1f240ddbc2030914d0b09ab6e34fa2996ed1  guix-build-776a16337416/output/x86_64-linux-gnu/bitcoin-776a16337416-x86_64-linux-gnu-debug.tar.gz
b45c28dd227ab5b86ec661074e1a110aa6fbd7578452ccb6b2828a4a4efdf614  guix-build-776a16337416/output/x86_64-linux-gnu/bitcoin-776a16337416-x86_64-linux-gnu.tar.gz
19bac66e5624c0144af2f5f6753eec834bf1dbc1ac07042b21ffa046d84f53a6  guix-build-776a16337416/output/x86_64-w64-mingw32/SHA256SUMS.part
7b172c5d9874a089c55645989ee552cb43847e38df09f03f1eb9e26cdb963f39  guix-build-776a16337416/output/x86_64-w64-mingw32/bitcoin-776a16337416-win64-codesigning.tar.gz
57f712741682507739b22cad7f7bf925769aa1db03cbca0ab7ca6d80b5df39ff  guix-build-776a16337416/output/x86_64-w64-mingw32/bitcoin-776a16337416-win64-debug.zip
65d462bf3b237c36d71766c0c80cc9aceebb75a531c075040c325205bf178d55  guix-build-776a16337416/output/x86_64-w64-mingw32/bitcoin-776a16337416-win64-setup-unsigned.exe
dd77058d02c4a52fc3928973f567c8ec849f55f20d0821faf7af62f2b747a250  guix-build-776a16337416/output/x86_64-w64-mingw32/bitcoin-776a16337416-win64-unsigned.zip

Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 776a163.

@Sjors
Copy link
Member

Sjors commented Aug 12, 2025

6c40d925b16cf05dad6933cce25c5fd86800b0cb4f947e5cf86f271d028267ae  guix-build-776a16337416/output/aarch64-linux-gnu/SHA256SUMS.part
17b90d50a6f9eb9ca9d5282f3bd85e01d91bcf92ff4980b437df3b98b14ef1a7  guix-build-776a16337416/output/aarch64-linux-gnu/bitcoin-776a16337416-aarch64-linux-gnu-debug.tar.gz
4fcdcad6b02d63b68e213c03552828bd59fd84f86f1d886aeac6b5413170b67e  guix-build-776a16337416/output/aarch64-linux-gnu/bitcoin-776a16337416-aarch64-linux-gnu.tar.gz
7ddf096c6d23c2e1bd9baf845bd36a7da4fcb164f5ca612a86dcc51fb04c56d5  guix-build-776a16337416/output/arm-linux-gnueabihf/SHA256SUMS.part
1513ff292c3bc48e3195fd03a23beba28eebc39c3d58a9efab733bf29b01b940  guix-build-776a16337416/output/arm-linux-gnueabihf/bitcoin-776a16337416-arm-linux-gnueabihf-debug.tar.gz
d4f669abb67e4a393aee37040cd7e67c4eee2db1b4c5a2e04bc71b3176fd528f  guix-build-776a16337416/output/arm-linux-gnueabihf/bitcoin-776a16337416-arm-linux-gnueabihf.tar.gz
d9056c22887d06066de4f6dae3bc547d4ea6e01c1e56576b507a28b6d51f49fb  guix-build-776a16337416/output/arm64-apple-darwin/SHA256SUMS.part
a1cf279bc8fd41c691c68fa27eef5835807df74bfcb12ad04a6ab82261d33f4e  guix-build-776a16337416/output/arm64-apple-darwin/bitcoin-776a16337416-arm64-apple-darwin-codesigning.tar.gz
92d3e3fc63d49f442c62e35318a71390311459f6a77792ee198b387e16c9ada4  guix-build-776a16337416/output/arm64-apple-darwin/bitcoin-776a16337416-arm64-apple-darwin-unsigned.tar.gz
1601fb3c4fc4fbc3068fd86451fdfcd773c6b80b5c2a1ee4fb202099b13b6455  guix-build-776a16337416/output/arm64-apple-darwin/bitcoin-776a16337416-arm64-apple-darwin-unsigned.zip
134539b3596d9252c41ede17c6455423b46be7db06a592b3dd33ec21d4c4ba0b  guix-build-776a16337416/output/dist-archive/bitcoin-776a16337416.tar.gz
8a969c87ab993543f959df482424e05cb3d865d7b347b60c29beb184fa4ea125  guix-build-776a16337416/output/powerpc64-linux-gnu/SHA256SUMS.part
79daf29c9982cfdcda42989aa7a518bb4f8d5a00dc26061e8a54c76fab2f159f  guix-build-776a16337416/output/powerpc64-linux-gnu/bitcoin-776a16337416-powerpc64-linux-gnu-debug.tar.gz
e03c5f6d02267fdfb00b77f6f21aeb1f6811c61dba06fa545028148db80a2226  guix-build-776a16337416/output/powerpc64-linux-gnu/bitcoin-776a16337416-powerpc64-linux-gnu.tar.gz
93a11e8f68543339ae56ee9a91fda8c2e7255b9bbab6b5490d2c17b620d0f8c8  guix-build-776a16337416/output/riscv64-linux-gnu/SHA256SUMS.part
f9a15a01f9d18db7107603196da371b8683c17bd9e5fa610b6f5d2661555e504  guix-build-776a16337416/output/riscv64-linux-gnu/bitcoin-776a16337416-riscv64-linux-gnu-debug.tar.gz
4e737781d4bef661c6beca109fac72e3e9a40860fa2d7532acf09a4a5365e6cb  guix-build-776a16337416/output/riscv64-linux-gnu/bitcoin-776a16337416-riscv64-linux-gnu.tar.gz
13cfaef707a3d1cc2ea288e75cb9c9fa4bfa14f2c29c6c9d166879c914986c20  guix-build-776a16337416/output/x86_64-apple-darwin/SHA256SUMS.part
a4c2b1fed6be581ab46c1c6e75a594cbdee01ee8fd9c045cc2bdbcdce47c43d3  guix-build-776a16337416/output/x86_64-apple-darwin/bitcoin-776a16337416-x86_64-apple-darwin-codesigning.tar.gz
dc0570f403075ac09f79686772b6be87c2627ef98079810e58b727958ca39264  guix-build-776a16337416/output/x86_64-apple-darwin/bitcoin-776a16337416-x86_64-apple-darwin-unsigned.tar.gz
971c7c807838dcce4b8d5c446dd37dce59f5513498a969cc47f56c29941e230a  guix-build-776a16337416/output/x86_64-apple-darwin/bitcoin-776a16337416-x86_64-apple-darwin-unsigned.zip
7f4d0446ca52b2da4e135ab217b51c7b5a89b0e9bc79b3f83fd3fe84cf56e234  guix-build-776a16337416/output/x86_64-linux-gnu/SHA256SUMS.part
8fc616f36098a2a53ebf8eb6aaec1f240ddbc2030914d0b09ab6e34fa2996ed1  guix-build-776a16337416/output/x86_64-linux-gnu/bitcoin-776a16337416-x86_64-linux-gnu-debug.tar.gz
b45c28dd227ab5b86ec661074e1a110aa6fbd7578452ccb6b2828a4a4efdf614  guix-build-776a16337416/output/x86_64-linux-gnu/bitcoin-776a16337416-x86_64-linux-gnu.tar.gz
19bac66e5624c0144af2f5f6753eec834bf1dbc1ac07042b21ffa046d84f53a6  guix-build-776a16337416/output/x86_64-w64-mingw32/SHA256SUMS.part
7b172c5d9874a089c55645989ee552cb43847e38df09f03f1eb9e26cdb963f39  guix-build-776a16337416/output/x86_64-w64-mingw32/bitcoin-776a16337416-win64-codesigning.tar.gz
57f712741682507739b22cad7f7bf925769aa1db03cbca0ab7ca6d80b5df39ff  guix-build-776a16337416/output/x86_64-w64-mingw32/bitcoin-776a16337416-win64-debug.zip
65d462bf3b237c36d71766c0c80cc9aceebb75a531c075040c325205bf178d55  guix-build-776a16337416/output/x86_64-w64-mingw32/bitcoin-776a16337416-win64-setup-unsigned.exe
dd77058d02c4a52fc3928973f567c8ec849f55f20d0821faf7af62f2b747a250  guix-build-776a16337416/output/x86_64-w64-mingw32/bitcoin-776a16337416-win64-unsigned.zip

@DrahtBot
Copy link
Contributor

Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]

File commit 273e600
(master)
commit ef4abd6
(pull/33178/merge)
*-aarch64-linux-gnu-debug.tar.gz 3f175c0131c6163a...
*-aarch64-linux-gnu.tar.gz 9140b316e0ccc7ad...
*-arm-linux-gnueabihf-debug.tar.gz 5fe2c0f4382959e9...
*-arm-linux-gnueabihf.tar.gz 7ea6ca51a3fcf902...
*-arm64-apple-darwin-codesigning.tar.gz 2cf2fa5d358db6b4...
*-arm64-apple-darwin-unsigned.tar.gz 3dc375bfaaf67853...
*-arm64-apple-darwin-unsigned.zip 76b983a06bb46fd4...
*-powerpc64-linux-gnu-debug.tar.gz 86794c94a449e109...
*-powerpc64-linux-gnu.tar.gz e0222436a698a037...
*-riscv64-linux-gnu-debug.tar.gz aa773e1e429cd130...
*-riscv64-linux-gnu.tar.gz 9bf764d8e477b6c1...
*-x86_64-apple-darwin-codesigning.tar.gz 063f2b45b218eed2...
*-x86_64-apple-darwin-unsigned.tar.gz 018732a3a85184fe...
*-x86_64-apple-darwin-unsigned.zip 700b0f6bbdd56b23...
*-x86_64-linux-gnu-debug.tar.gz 42437cfe08850b56...
*-x86_64-linux-gnu.tar.gz ef42fb24a9a2b543...
*.tar.gz d39fe80ecf7f0cf3... 8b83292527157533...
SHA256SUMS.part 1fd34e26b80d215b...
guix_build.log 88bc352044af2ee8... 8c3fadc9da0d39ca...
guix_build.log.diff 0126e49c5dd85c7f...

@fanquake fanquake merged commit d6887f0 into bitcoin:master Aug 13, 2025
19 checks passed
@fanquake fanquake deleted the sym_check_gcc_7 branch August 13, 2025 08:14
alexanderwiederin added a commit to alexanderwiederin/rust-bitcoinkernel that referenced this pull request Aug 21, 2025
…88ae28a

bce88ae28a kernel: Fix bitcoin-chainstate for windows
3a7e9f0eaf kernel: Add Purpose section to header documentation
5bae79ace5 kernel: Allowing reducing exports
d0308a2489 kernel: Add pure kernel bitcoin-chainstate
05a569070c kernel: Add functions to get the block hash from a block
8566ec6e83 kernel: Add block index utility functions to C header
b4d0e80f84 kernel: Add function to read block undo data from disk to C header
488999ac77 kernel: Add functions to read block from disk to C header
3dc76bb7f7 kernel: Add function for copying block data to C header
6151b45a42 kernel: Add functions for the block validation state to C header
5d00432f27 kernel: Add validation interface to C header
facf209aee kernel: Add interrupt function to C header
129f553e4e kernel: Add import blocks function to C header
f7ed7b944d kernel: Add chainstate load options for in-memory dbs in C header
67d9f53a98 kernel: Add options for reindexing in C header
ebc826319f kernel: Add block validation to C header
511a1c8a78 kernel: Add chainstate loading when instantiating a ChainstateManager
aad295899e kernel: Add chainstate manager option for setting worker threads
c701cb2405 kernel: Add chainstate manager object to C header
1df8b87602 kernel: Add notifications context option to C header
571c1a2acb kernel: Add chain params context option to C header
a2cab9f1cd kernel: Add kernel library context object
944ef6b630 kernel: Add logging to kernel library C header
d0cb841fba kernel: Introduce initial kernel C header API
04c115dfde Merge bitcoin/bitcoin#33078: kernel: improve BlockChecked ownership semantics
bc797d2271 Merge bitcoin/bitcoin#33154: test: use local `CBlockIndex` in block read hash mismatch check
d3c58a5be9 Merge bitcoin/bitcoin#33193: Release: Prepare "Translation string freeze" step
9cf7b3d90c Merge bitcoin/bitcoin#33211: test: modify logging_filesize_rate_limit params
f5f853d952 Merge bitcoin/bitcoin#32878: index: fix wrong assert of current_tip == m_best_block_index
5dda364c4b test: modify logging_filesize_rate_limit params
0df2c3c42e qt: Update `src/qt/locale/bitcoin_en.xlf` translation source file
22e689587a Merge bitcoin/bitcoin#33209: cmake: Drop python dependency for translate
be356fc49b Merge bitcoin/bitcoin#32896: wallet, rpc: add v3 transaction creation and wallet support
3c4a109aa8 cmake: Drop python dependency for translate
f58de8749e Merge bitcoin/bitcoin#32345: ipc: Handle unclean shutdowns better
d31dc8f818 Merge bitcoin/bitcoin#33200: cmake: Introduce translate.cmake script for translate target
05255d5d1e cmake: Drop dependency on sed for translate target
d5054beca5 cmake: Introduce translate.cmake script for translate target
57e8f34fe2 Merge bitcoin/bitcoin#32977: wallet: Remove wallet version and several legacy related functions
97593c1fd3 Merge bitcoin/bitcoin#32975: assumevalid: log every script validation state change
5c8bf7b39e doc: add release notes for version 3 transactions
4ef8065a5e test: add truc wallet tests
5d932e14db test: extract `bulk_vout` from `bulk_tx` so it can be used by wallet tests
2cb473d9f2 rpc: Support version 3 transaction creation
4c20343b4d rpc: Add transaction min standard version parameter
c5a2d08011 wallet: don't return utxos from multiple truc txs in AvailableCoins
da8748ad62 wallet: limit v3 tx weight in coin selection
85c5410615 wallet: mark unconfirmed v3 siblings as mempool conflicts
0804fc3cb1 wallet: throw error at conflicting tx versions in pre-selected inputs
cc155226fe wallet: set m_version in coin control to default value
2e9617664e  wallet: don't include unconfirmed v3 txs with children in available coins
ec2676becd wallet: unconfirmed ancestors and descendants are always truc
7b4a1350df Merge bitcoin/bitcoin#33183: validation: rename block script verification error from "mandatory" to "block"
c99f5c5e1b Merge bitcoin/bitcoin#33106: policy: lower the default blockmintxfee, incrementalrelayfee, minrelaytxfee
578b512bdd Merge bitcoin/bitcoin#33011: log: rate limiting followups
8405fdb06e Merge bitcoin/bitcoin#33169: interfaces, chain, refactor: Remove unused getTipLocator and incaccurate getActiveChainLocator
c0d91fc69c Add release note for #33050 and #33183 error string changes
e17b5da0d6 Merge bitcoin/bitcoin#33179: doc: update wallet build instruction
9b1a7c3e8d Merge bitcoin/bitcoin#33116: refactor: Convert uint256 to Txid
b3f781a0ef contrib: adapt max reject string size in tracing demo
9a04635432 scripted-diff: validation: rename mandatory errors into block errors
dbf8b0980b Merge bitcoin/bitcoin#33171: ci: Update `actions/checkout` version
d6887f0cec Merge bitcoin/bitcoin#33178: guix: increase maximum allowed (runtime) GCC to 7
2b00030af8 interfaces, chain, refactor: Remove inaccurate getActiveChainLocator
110a0f405c interfaces, chain, refactor: Remove unused getTipLocator
dadf15f88c Merge bitcoin/bitcoin#33050: net, validation: don't punish peers for consensus-invalid txs
cb173b8e93 test: use local `CBlockIndex` in block read hash mismatch test to avoid data race
73972d5617 Merge bitcoin/bitcoin#31296: wallet: Translate [default wallet] string in progress messages
67e186deb0 doc: update wallet build instruction
5c74a0b397 config: add DEBUG_ONLY -logratelimit
9f3b017bcc test: logging_filesize_rate_limit improvements
350193e5e2 test: don't leak log category mask across tests
05d7c22479 test: add ReadDebugLogLines helper function
3d630c2544 log: make m_limiter a shared_ptr
ec484bd5ce Merge bitcoin/bitcoin#31453: util: detect and warn when using exFAT on MacOS
776a163374 guix: increase maximum allowed (runtime) GCC to 7
ba84a25dee [doc] update mempool-replacements.md for incremental relay feerate change
273e600e65 Merge bitcoin/bitcoin#33021: test/refactor: revive test verifying that `GetCoinsCacheSizeState` switches from OK→LARGE→CRITICAL
18720bc5d5 [doc] release note for min feerate changes
6da5de58ca [policy] lower default minrelaytxfee and incrementalrelayfee to 100sat/kvB
2e515d2897 [prep/test] make wallet_fundrawtransaction's minrelaytxfee assumption explicit
457cfb61b5 [prep/util] help MockMempoolMinFee handle more precise feerates
3eab8b7240 [prep/test] replace magic number 1000 with respective feerate vars
5f2df0ef78 [miner] lower default -blockmintxfee to 1sat/kvB
d6213d6aa1 [doc] assert that default min relay feerate and incremental are the same
1fbee5d7b6 [test] explicitly check default -minrelaytxfee and -incrementalrelayfee
72dc18467d [test] RBF rule 4 for various incrementalrelayfee settings
85f498893f [test] check bypass of minrelay for various minrelaytxfee settings
e5f896bb1f [test] check miner doesn't select 0fee transactions
de0675f9de refactor: Move `transaction_identifier.h` to primitives
6f068f65de Remove implicit uint256 conversion and comparison
9c24cda72e refactor: Convert remaining instances from uint256 to Txid
d2ecd6815d policy, refactor: Convert uint256 to Txid
f6c0d1d231 mempool, refactor: Convert uint256 to Txid
aeb0f78330 refactor: Convert `mini_miner` from uint256 to Txid
326f244724 refactor: Convert RPCs and `merkleblock` from uint256 to Txid
41642d43b3 Merge bitcoin/bitcoin#33162: test: fix scripts in `blockfilter_basic_test`
f83c01d882 ci: Update `actions/checkout` version
a27430e259 Merge bitcoin/bitcoin#32473: Introduce per-txin sighash midstate cache for legacy/p2sh/segwitv0 scripts
34b366fa2c Merge bitcoin/bitcoin#33155: contrib: drop `bitcoin-util` exception from FORTIFY check
ca64b71ed5 test: fix scripts in `blockfilter_basic_test`
fab2980bdc assumevalid: log every script validation state change
e8f9c37a3b log: clean up LogPrintStr_ and Reset, prefix all logs with "[*]" when there are suppressions
3c7cae49b6 log: change LogLimitStats to struct LogRateLimiter::Stats
876dbdfb47 tests: drop expect_disconnect behaviour for tx relay
b29ae9efdf validation: only check input scripts once
266dd0e10d net_processing: drop MaybePunishNodeForTx
db3228042b util: detect and warn when using exFAT on macOS
4bff4ce561 contrib: drop bitcoin-util exception from FORTIFY check
83950275ed qa: unit test sighash caching
b221aa80a0 qa: simple differential fuzzing for sighash with/without caching
92af9f74d7 script: (optimization) introduce sighash midstate caching
8f3ddb0bcc script: (refactor) prepare for introducing sighash midstate cache
9014d4016a tests: add sighash caching tests to feature_taproot
49b3d3a92a Clean up `FindTxForGetData`
2581258ec2 ipc: Handle bitcoin-wallet disconnections
2160995916 ipc: Add Ctrl-C handler for spawned subprocesses
0c28068ceb doc: Improve IPC interface comments
7f65aac78b ipc: Avoid waiting for clients to disconnect when shutting down
6eb09fd614 test: Add unit test coverage for Init and Shutdown code
9a9fb19536 ipc: Use EventLoopRef instead of addClient/removeClient
5c45bc989b Merge commit 'e886c65b6b37aaaf5d22ca68bc14e55d8ec78212' into pr/ipc-stop-base
e886c65b6b Squashed 'src/ipc/libmultiprocess/' changes from 27c7e8e5a581..b4120d34bad2
3aef38f44b test: exercise index reorg assertion failure
acf50233cd index: fix wrong assert of current_tip == m_best_block_index
1d9f1cb4bd kernel: improve BlockChecked ownership semantics
554befd873 test: revive `getcoinscachesizestate`
64ed0fa6b7 refactor: modernize `LargeCoinsCacheThreshold`
1b40dc02a6 refactor: extract `LargeCoinsCacheThreshold` from `GetCoinsCacheSizeState`
8319a13468 log: clarify RATELIMIT_MAX_BYTES comment, use RATELIMIT_WINDOW
5f70bc80df log: remove const qualifier from arguments in LogPrintFormatInternal
b8e92fb3d4 log: avoid double hashing in SourceLocationHasher
616bc22f13 test: remove noexcept(false) comment in ~DebugLogHelper
9ba1fff29e kernel: refactor: ConnectTip to pass block pointer by value
60d1042b9a wallet: Remove unused `WalletFeature` enums
66de58208a wallet: Remove `CWallet::nWalletVersion` and related functions
7cda3d0f5b wallet: Remove `IsFeatureSupported()` and `CanSupportFeature()`
ba01585229 wallet: `MigrateToDescriptor` no longer calls `CanSupportFeature`
63acee2797 wallet: Remove `GetClosestWalletFeature()`
e27da3150b wallet: Remove `GetVersion()`
db225cea56 wallet, refactor: Replace GetDisplayName() with LogName()
01737883b3 wallet: Translate [default wallet] string in progress messages
REVERT: 35fced5df7 kernel: Fix bitcoin-chainstate for windows
REVERT: c164264fd8 kernel: Add Purpose section to header documentation
REVERT: 9096c35c05 kernel: Allowing reducing exports
REVERT: 6d0d4b2507 kernel: Add pure kernel bitcoin-chainstate
REVERT: ccd85f0333 kernel: Add functions to get the block hash from a block
REVERT: 925f21c37b kernel: Add block index utility functions to C header
REVERT: b7441841c9 kernel: Add function to read block undo data from disk to C header
REVERT: bc0e6f098e kernel: Add functions to read block from disk to C header
REVERT: 5120302f96 kernel: Add function for copying block data to C header
REVERT: 718ccee732 kernel: Add functions for the block validation state to C header
REVERT: eb363ab30e kernel: Add validation interface to C header
REVERT: 246886c6ea kernel: Add interrupt function to C header
REVERT: f3b34ca457 kernel: Add import blocks function to C header
REVERT: fe08857d52 kernel: Add chainstate load options for in-memory dbs in C header
REVERT: f93f171e01 kernel: Add options for reindexing in C header
REVERT: dca7b4c26e kernel: Add block validation to C header
REVERT: f031e9ce03 kernel: Add chainstate loading when instantiating a ChainstateManager
REVERT: 3cb99f73ec kernel: Add chainstate manager option for setting worker threads
REVERT: 9454ad8512 kernel: Add chainstate manager object to C header
REVERT: 3bead9ebdd kernel: Add notifications context option to C header
REVERT: dda805dfb6 kernel: Add chain params context option to C header
REVERT: ea5334925d kernel: Add kernel library context object
REVERT: 36fafbaef9 kernel: Add logging to kernel library C header
REVERT: d28eef5cf2 kernel: Introduce initial kernel C header API

git-subtree-dir: libbitcoinkernel-sys/bitcoin
git-subtree-split: bce88ae28ab2cd12f32aead1fbf47153c50c3b05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Guix builds are broken
5 participants