rpc: use anti-fee-sniping in send, sendall and walletcreatefundedpsbt #32892
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code Coverage & BenchmarksFor details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32892. ReviewsSee the guideline for information on the review process. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
If the user does not specify 'locktime' for send and walletcreatefundedpsbt, enable anti-fee-sniping. This matches sendtoaddress RPC behavior and the GUI wallet.
Rename and refactor DiscourageFeeSniping such that it can determine by itself whether to apply anti fee sniping. This makes it easier to use outside of CreateTransactionInternal.
|
Expanded the existing |
|
Any chance this is a duplicate of #28944? |
|
@glozow thanks, I hadn't seen that one. Will take a look. |
|
Ok, so #28944 uses a completely different approach. It already has a lot of review, so I'll add mine there. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Github-Pull: bitcoin#32892 Rebased-From: c8a73f3
Github-Pull: bitcoin#32892 Rebased-From: 4bc0858 (tests only)
If the user does not specify
locktimeforsend,sendallandwalletcreatefundedpsbt, enable anti-fee-sniping. Previously we would setnLockTimeto 0.This behavior matches the
sendtoaddressRPC and the GUI wallet.Because
sendalldoesn't useCreateTransactionInternalthis PR refactors (and renames)DiscourageFeeSnipingso that it checks inputnSequencevalues and nLockTime by itself, and brings its ownFastRandomContext. A subsequent commit then calls this from thesendallRPC.