ci: Temporarily revert "Drop bench -priority-level in win cross CI" #32302
Conversation
This reverts commit 27f1121.
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code Coverage & BenchmarksFor details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32302. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
|
ACK fadccd9 Build passes now, we will have to rebase a few PRs after this so it makes sense to merge it ASAP. |
|
Can we add a different change, to continue running all benchmarks (I guess just not Windows), so we aren't back to the same state that allowed #32277 to happen? |
An alternative has been suggested in #32306. |
|
May this be closed in favour of #32306? |
Yes, happy to follow-up next week, as explained in #32288 (comment)
No strong opinion, I think either is equally fine. Closing this one for now, because it has less acks. |
18a0351 ci: Temporarily disable `WalletMigration` benchmark (Hennadii Stepanov) Pull request description: The `WalletMigration` benchmark is currently failing on CI. This PR temporarily disables it until the issue is resolved. An alternative to #32302. ACKs for top commit: maflcko: lgtm ACK 18a0351 TheCharlatan: ACK 18a0351 Tree-SHA512: bb1451fd0743a2955216a6d06916e411420a76bfed8b69ffcfadf99d0996d8f3b89ed72f855f25269f943ca4c3b4422065fde2374a1bf76c8bb64f14ab883092
This reverts commit 27f1121.
The commit was nice and useful. However, CI doesn't pass, see #32291. Temporarily revert it, so that it can be enabled again along with the issue fixed.