doc: update unix build doc with build flags #32269
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code Coverage & BenchmarksFor details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32269. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
|
As mentioned, what you're adding is already present in this file, so if you're re-ordering things, you'll need to remove the second occurence. |
|
@fanquake Just did that! |
|
Thanks. You'll need to squash your commits. |
d5c9c73 to
be6e4c4
Compare
|
Done |
| @@ -7,8 +7,15 @@ Some notes on how to build Bitcoin Core in Unix. | |||
| To Build | |||
| --------------------- | |||
|
|
|||
| ### 1. Configuration | |||
There was a problem hiding this comment.
nit: Not sure we want to manually number the sections. The order should already be clear
There was a problem hiding this comment.
I do agree but that's consistent with most doc/build*.md files (doc/build-freebsd.md, doc/build-netbsd.md, doc/build-openbsd.md, doc/build-osx.md).
|
🐙 This pull request conflicts with the target branch and needs rebase. |
|
Rebased this is in #33088. |
6757052 doc: move `cmake -B build -LH` up in Unix build docs (Bufo) Pull request description: #32269 rebased. > I had trouble building bitcoin core the way I wanted since now more features require a flag while building. IMO it makes sense to make it a bit more prominent in the build docs how to get the needed flags. > Related issue: #32258 ACKs for top commit: maflcko: lgtm ACK 6757052 stickies-v: ACK 6757052 janb84: ACK 6757052 Tree-SHA512: 8e6dc1e432c067f862560776176112d5c24c4009bdf8e9a4e8d1ea3328b88732188fc4d8a7cd29f8a9ed8a1809a7a8a86d63b7ae3ec4ebae74be466727c8d730
I had trouble building bitcoin core the way I wanted since now more features require a flag while building. IMO it makes sense to make it a bit more prominent in the build docs how to get the needed flags.
Related issue: #32258