-
Notifications
You must be signed in to change notification settings - Fork 37.7k
cmake: Revamp FindLibevent
module
#31181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code Coverage & BenchmarksFor details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31181. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
666de80
to
b67100b
Compare
🚧 At least one of the CI tasks failed. HintsTry to run the tests locally, according to the documentation. However, a CI failure may still
Leave a comment here, if you need help tracking down a confusing failure. |
Concept ACK - we don't have to restrict CMake usage to |
Concept ACK |
Can you rebase this. |
b67100b
to
a6a3cab
Compare
Sure. Rebased. |
My Guix build:
|
Guix build: c448a9c8d6d436350846ccb998e6a5e2bb66ac519e3539188c4792c6a88f4a1c guix-build-a6a3cab235cf/output/aarch64-linux-gnu/SHA256SUMS.part
613ef63f92fdf0422179fdedad230a7b8c5eb1530c892745bd2d5e76e8fb580c guix-build-a6a3cab235cf/output/aarch64-linux-gnu/bitcoin-a6a3cab235cf-aarch64-linux-gnu-debug.tar.gz
2d77932ce9f8808f9673420320faaf9b20d910595f3d3d65687b5cbc55cb84dd guix-build-a6a3cab235cf/output/aarch64-linux-gnu/bitcoin-a6a3cab235cf-aarch64-linux-gnu.tar.gz
73019d4fb0f4e54828f70383c769d578112e85c028892ae9bcffa64e0a744a98 guix-build-a6a3cab235cf/output/arm-linux-gnueabihf/SHA256SUMS.part
cb1d13753ef47508cfd8b06c95668580c6c17cc64c852f05379eb0523fbfbf5e guix-build-a6a3cab235cf/output/arm-linux-gnueabihf/bitcoin-a6a3cab235cf-arm-linux-gnueabihf-debug.tar.gz
47d5a87c465dbfbf1ebc94ac45ad54b8ce12bced200ed8e9d1a3a0b9e10029d3 guix-build-a6a3cab235cf/output/arm-linux-gnueabihf/bitcoin-a6a3cab235cf-arm-linux-gnueabihf.tar.gz
2bcd4e7933c0a2492714b336d1a71abfef159663e0be24df62513841bdd1e8dc guix-build-a6a3cab235cf/output/arm64-apple-darwin/SHA256SUMS.part
c2ea0008a1eec8d321d9fe1d3444a1c94168e26925b4f9aeb602e781d2f277c4 guix-build-a6a3cab235cf/output/arm64-apple-darwin/bitcoin-a6a3cab235cf-arm64-apple-darwin-unsigned.tar.gz
296f22f2abd6b87aebe37957073adf6527e92349ef76c973a0015455cb645738 guix-build-a6a3cab235cf/output/arm64-apple-darwin/bitcoin-a6a3cab235cf-arm64-apple-darwin-unsigned.zip
9c53fe999e9c8cb392273cec4052e6ba0e1a4d926058ffb1dfb2f79d96f9f61a guix-build-a6a3cab235cf/output/arm64-apple-darwin/bitcoin-a6a3cab235cf-arm64-apple-darwin.tar.gz
7ac751b56e8820478c17c7701ed46a9291a642317d7dc5226712f14037442681 guix-build-a6a3cab235cf/output/dist-archive/bitcoin-a6a3cab235cf.tar.gz
5bc0ce74d6baaed0b9a71edd2142c12c51af50e49e4a3e561ca574630c15c1f7 guix-build-a6a3cab235cf/output/powerpc64-linux-gnu/SHA256SUMS.part
08bee7dc7a9b3afe0e8cd277b9647056b39bec94e868265f935b41b2c8bdad54 guix-build-a6a3cab235cf/output/powerpc64-linux-gnu/bitcoin-a6a3cab235cf-powerpc64-linux-gnu-debug.tar.gz
29595c9dfe155009ffaf6e5d4701e52c6e735f6bb8dbe7f1a939604ea1c0d72d guix-build-a6a3cab235cf/output/powerpc64-linux-gnu/bitcoin-a6a3cab235cf-powerpc64-linux-gnu.tar.gz
9177685189978221038172865d0d7560ebee5f8a856908d7e955e2c4016fdffb guix-build-a6a3cab235cf/output/riscv64-linux-gnu/SHA256SUMS.part
80ed63afed14e7183e11ae6d214288ded481853f1c25377986145a6aa9a8ea29 guix-build-a6a3cab235cf/output/riscv64-linux-gnu/bitcoin-a6a3cab235cf-riscv64-linux-gnu-debug.tar.gz
e3415ba90273004c8c0faf11cf96570b838d2b4aa04e5c3e2e74b85e1507bfc3 guix-build-a6a3cab235cf/output/riscv64-linux-gnu/bitcoin-a6a3cab235cf-riscv64-linux-gnu.tar.gz
07ae8d18a95806e8061aa9e29151c8c6f786a8c9e0ee2c8c3f91c88fafb54d65 guix-build-a6a3cab235cf/output/x86_64-apple-darwin/SHA256SUMS.part
f39dd6779d72b4054a6467c2c5cd88d7e9971604a851501c2a5d809b531a2f11 guix-build-a6a3cab235cf/output/x86_64-apple-darwin/bitcoin-a6a3cab235cf-x86_64-apple-darwin-unsigned.tar.gz
891e34c0d16b538d5817fc71e50746b0a09aa083f7edc5d3a744a668f582fb2a guix-build-a6a3cab235cf/output/x86_64-apple-darwin/bitcoin-a6a3cab235cf-x86_64-apple-darwin-unsigned.zip
dab234ff1e2838a50a08b78d53a5542d535890603737cf41a7946709591aba74 guix-build-a6a3cab235cf/output/x86_64-apple-darwin/bitcoin-a6a3cab235cf-x86_64-apple-darwin.tar.gz
1786396653240ff3cf1125f8c50ddf606135717514bf1a8a612de04483df5854 guix-build-a6a3cab235cf/output/x86_64-linux-gnu/SHA256SUMS.part
945a49f969ad8da9efbf86c2c5f228c4872eebff3dd494f9712c074eba2003dd guix-build-a6a3cab235cf/output/x86_64-linux-gnu/bitcoin-a6a3cab235cf-x86_64-linux-gnu-debug.tar.gz
461c91b543a1590a492249c3f72f9317ece3c31545c04b8b5f6f184c1155c5f9 guix-build-a6a3cab235cf/output/x86_64-linux-gnu/bitcoin-a6a3cab235cf-x86_64-linux-gnu.tar.gz
a0f23a0bd73f6a8a101613296b7a0d60151fe5333904658c13f70d8ce611d663 guix-build-a6a3cab235cf/output/x86_64-w64-mingw32/SHA256SUMS.part
22e92eb5929864f666940ac3342b3eef5ee11b9b96adc45397f8c2708903e0a5 guix-build-a6a3cab235cf/output/x86_64-w64-mingw32/bitcoin-a6a3cab235cf-win64-debug.zip
df3e31e1c644fc027cc884171b2f4454a895b09917df89b02357c9a6e1da99b3 guix-build-a6a3cab235cf/output/x86_64-w64-mingw32/bitcoin-a6a3cab235cf-win64-setup-unsigned.exe
77b454372ccec46833b7be52c240a21b3e694cf05e7f6d23a37d95d12369e05f guix-build-a6a3cab235cf/output/x86_64-w64-mingw32/bitcoin-a6a3cab235cf-win64-unsigned.tar.gz
05b1385a21d2c1b48cb80e9c97c0c221fca5e341dd4838f03f8abe4fdb7b7b0b guix-build-a6a3cab235cf/output/x86_64-w64-mingw32/bitcoin-a6a3cab235cf-win64.zip |
Tested on Arch, which is one of the few distros that ship CMake config files for diff --git a/doc/build-unix.md b/doc/build-unix.md
index a5ad4df11d..4f04b4fd9f 100644
--- a/doc/build-unix.md
+++ b/doc/build-unix.md
@@ -182,7 +182,7 @@ Setup and Build Example: Arch Linux
-----------------------------------
This example lists the steps necessary to setup and build a command line only distribution of the latest changes on Arch Linux:
- pacman --sync --needed cmake boost gcc git libevent make pkgconf python sqlite
+ pacman --sync --needed cmake boost gcc git libevent make python sqlite
git clone https://github.com/bitcoin/bitcoin.git
cd bitcoin/
cmake -B build |
This change generalizes the use of `find_package` / `pkg_check_modules`, prioritizing the former.
a6a3cab
to
5a96767
Compare
Thanks! Updated. |
My Guix build:
|
Guix Build b526b46943f39780cb2a204cd64159f7dd4f502e482256ba78371c82d717a591 guix-build-5a96767e3f53/output/aarch64-linux-gnu/SHA256SUMS.part
77714a2034b96c572598342da2147a638abd626b29e4ccecfe786f53dbf72a4e guix-build-5a96767e3f53/output/aarch64-linux-gnu/bitcoin-5a96767e3f53-aarch64-linux-gnu-debug.tar.gz
a32ce8d85863ec00f75b37ab7b10bfc37e85efd3a1016ed66ce6cbd0024d018a guix-build-5a96767e3f53/output/aarch64-linux-gnu/bitcoin-5a96767e3f53-aarch64-linux-gnu.tar.gz
751eba9ba4c9c2432018854a9064bcc24a7cde4236247da7ecf0c09d6ad4d998 guix-build-5a96767e3f53/output/arm-linux-gnueabihf/SHA256SUMS.part
e5c5d79fe4da7183009207e4c229a0da6d10da8b293c7309ff45b99b2d18dd78 guix-build-5a96767e3f53/output/arm-linux-gnueabihf/bitcoin-5a96767e3f53-arm-linux-gnueabihf-debug.tar.gz
258f63b89ef5cb5f425fd3c1e979e355608ab40272304fd04314acdf1f07397d guix-build-5a96767e3f53/output/arm-linux-gnueabihf/bitcoin-5a96767e3f53-arm-linux-gnueabihf.tar.gz
6b79c89ce6e36cc46db4a50e1635e42751e2323227ae3b0b2f4012ce8fa40489 guix-build-5a96767e3f53/output/arm64-apple-darwin/SHA256SUMS.part
e8bd0927f1986eda76ff8da3ac966b8df5a847936fe15f6fe1ad2565ccf81de7 guix-build-5a96767e3f53/output/arm64-apple-darwin/bitcoin-5a96767e3f53-arm64-apple-darwin-unsigned.tar.gz
6705d70f0318d146aa4e264dd561eda53166d6ebacc60602f96a02549b0f8971 guix-build-5a96767e3f53/output/arm64-apple-darwin/bitcoin-5a96767e3f53-arm64-apple-darwin-unsigned.zip
a5feee710b316d2f2f6b43bfd55d4712d3513e5f56dd80d823b63fb90e74e52f guix-build-5a96767e3f53/output/arm64-apple-darwin/bitcoin-5a96767e3f53-arm64-apple-darwin.tar.gz
e2d8c8b6f14bc44086cc6e152d80dd7fe9af4f501038dcffefded43f60c0c78b guix-build-5a96767e3f53/output/dist-archive/bitcoin-5a96767e3f53.tar.gz
3e87fe8a89bd6ed809ca4ab77308999f84a3eb4cc4aa97a3de67925e93f193de guix-build-5a96767e3f53/output/powerpc64-linux-gnu/SHA256SUMS.part
5de169c0431a5dd1efab9ea88dd5fc87c5f985adf1a87c796e6eaa154d241fdb guix-build-5a96767e3f53/output/powerpc64-linux-gnu/bitcoin-5a96767e3f53-powerpc64-linux-gnu-debug.tar.gz
78333296ce7fc88882a71b1a2b03d8544ee9413516f322aa685e2e3c9c47abbe guix-build-5a96767e3f53/output/powerpc64-linux-gnu/bitcoin-5a96767e3f53-powerpc64-linux-gnu.tar.gz
02e5ec367182a54814509f2c640cb8951341b63a7a510e2fe12f3c98f5829f8e guix-build-5a96767e3f53/output/riscv64-linux-gnu/SHA256SUMS.part
239329403da2775bb5b3b8b73bd1fa9613a19852b30801e819cb39e5700ce495 guix-build-5a96767e3f53/output/riscv64-linux-gnu/bitcoin-5a96767e3f53-riscv64-linux-gnu-debug.tar.gz
7d9bf2f6c19455bfe8a94770ad10d71d73cabe3833e511b84e4da2b2bec9fa4d guix-build-5a96767e3f53/output/riscv64-linux-gnu/bitcoin-5a96767e3f53-riscv64-linux-gnu.tar.gz
ba16d9bbbbafe29f39d8b733fe090725c24ae8a095a6454bfaaea8be2103025d guix-build-5a96767e3f53/output/x86_64-apple-darwin/SHA256SUMS.part
a8907b52a882730062f2312e349c52e399215b76c6cff231ad550214ae52b807 guix-build-5a96767e3f53/output/x86_64-apple-darwin/bitcoin-5a96767e3f53-x86_64-apple-darwin-unsigned.tar.gz
e963cd3623bee1e79e7de260cc5347d203926a5a7da51dab97650ef8f3597f49 guix-build-5a96767e3f53/output/x86_64-apple-darwin/bitcoin-5a96767e3f53-x86_64-apple-darwin-unsigned.zip
6e6194b28563fb4bfa2840265ee783e282684df08b773919d4b78cd88e37ce78 guix-build-5a96767e3f53/output/x86_64-apple-darwin/bitcoin-5a96767e3f53-x86_64-apple-darwin.tar.gz
f84f236918aaae68c7a036bfcc4cd6e643b449ace6812f8fcb2ad3e6aa60fd89 guix-build-5a96767e3f53/output/x86_64-linux-gnu/SHA256SUMS.part
a35b69c56c97b8aa308a2893471712200646ec4b0d469828506059668044e05d guix-build-5a96767e3f53/output/x86_64-linux-gnu/bitcoin-5a96767e3f53-x86_64-linux-gnu-debug.tar.gz
d8daf3cb7bf4e6a18e1312bedc0383b5a1676c16c723330f187c1cf2cccdf4e1 guix-build-5a96767e3f53/output/x86_64-linux-gnu/bitcoin-5a96767e3f53-x86_64-linux-gnu.tar.gz
4b7790e70a57d5d9c8dd167ebde956be0e8fd8819ff3374866869619fad5deea guix-build-5a96767e3f53/output/x86_64-w64-mingw32/SHA256SUMS.part
1c051bbe9f6958f2cd91cb20e47fc0778a8e3877f034fd97b37b6a78f22b64ea guix-build-5a96767e3f53/output/x86_64-w64-mingw32/bitcoin-5a96767e3f53-win64-debug.zip
b00ef4ad4fcad2da810b7900834256d8b56a575705f6a5ee5e124075ee9ce3ec guix-build-5a96767e3f53/output/x86_64-w64-mingw32/bitcoin-5a96767e3f53-win64-setup-unsigned.exe
7f6bb43d931a8a62a5cfdd3d7a55b46bace525441e973563dacc71c34fc0aa10 guix-build-5a96767e3f53/output/x86_64-w64-mingw32/bitcoin-5a96767e3f53-win64-unsigned.tar.gz
122fb77cbc223ca67bfecdeef3709dbac291e1df0bbf082d87d94777292d9399 guix-build-5a96767e3f53/output/x86_64-w64-mingw32/bitcoin-5a96767e3f53-win64.zip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 5a96767
Arch is one of the few distros that ships cmake config files for libevent, meaning that post bitcoin/bitcoin#31181, the system libs build should work without pkg-config. So drop the dep here. Probably worth having one job testing this, as we head further in that direction, i.e: bitcoin/bitcoin#31276.
…158303fe2 48158303fe2 kernel: Add pure kernel bitcoin-chainstate bf80d2f5009 kernel: Add block index utility functions to C header a6ab5345e3b kernel: Add function to read block undo data from disk to C header 845b824d6c7 kernel: Add functions to read block from disk to C header 9324c8c4f67 kernel: Add function for copying block data to C header 368fc93fd80 kernel: Add functions for the block validation state to C header eb6e25ac007 kernel: Add validation interface to C header cdce4484005 kernel: Add interrupt function to C header 7e47ec78768 kernel: Add import blocks function to C header 2b803d50747 kernel: Add chainstate load options for in-memory dbs in C header ea92eb13c4a kernel: Add options for reindexing in C header 8254f2035a7 kernel: Add block validation to C header ad7b880346e Kernel: Add chainstate loading to kernel C header 583820c4487 kernel: Add chainstate manager object to C header ec137a086a0 kernel: Add notifications context option to C header 62a89689266 kerenl: Add chain params context option to C header bb482dcbd30 kernel: Add kernel library context object d114ccfdf8a kernel: Add logging to kernel library C header 44c65c46c43 kernel: Introduce initial kernel C header API 69c03134440 Merge bitcoin/bitcoin#31269: validation: Remove RECENT_CONSENSUS_CHANGE validation result 42282592943 Merge bitcoin/bitcoin#31000: bench: add support for custom data directory 36f5effa178 Merge bitcoin/bitcoin#31235: addrman: cap the `max_pct` to not exceed the maximum number of addresses 98ad249b69f Merge bitcoin/bitcoin#31277: doc: mention `descriptorprocesspsbt` in psbt.md b0222bbb494 Merge bitcoin/bitcoin#30239: Ephemeral Dust 1dda1892b6b Merge bitcoin/bitcoin#31037: test: enhance p2p_orphan_handling 5c2e291060c bench: Add basic CheckEphemeralSpends benchmark 3f6559fa581 Add release note for ephemeral dust 71a6ab4b33d test: unit test for CheckEphemeralSpends 21d28b2f362 fuzz: add ephemeral_package_eval harness 127719f516a test: Add CheckMempoolEphemeralInvariants e2e30e89ba4 functional test: Add ephemeral dust tests 4e68f901390 rpc: disallow in-mempool prioritisation of dusty tx e1d3e81ab4d policy: Allow dust in transactions, spent in-mempool 04b2714fbbc functional test: Add new -dustrelayfee=0 test case ebb6cd82baf doc: mention `descriptorprocesspsbt` in psbt.md 2b33322169b Merge bitcoin/bitcoin#31249: test: Add combinerawtransaction test to rpc_createmultisig 3fb6229dcfd Merge bitcoin/bitcoin#31271: doc: correct typos fa66e0887ca bench: add support for custom data directory ad9c2cceda9 test, bench: specialize working directory name 9c5775c331e addrman: cap the `max_pct` to not exceed the maximum number of addresses 8d340be9247 Merge bitcoin/bitcoin#31181: cmake: Revamp `FindLibevent` module 9a8e5adb161 Merge bitcoin/bitcoin#31267: refactor: Drop deprecated space in operator""_mst 726cbee9553 doc: correct typos 9fdfb73ca84 doc: fix typos af6088701a2 Merge bitcoin/bitcoin#31237: doc: Add missing 'blank=true' option in offline-signing-tutorial.md 7a526653022 Merge bitcoin/bitcoin#31239: test: clarify log messages when handling SOCKS5 proxy connections 900b17239fb Merge bitcoin/bitcoin#31259: doc: Fix missing comma in JSON example in REST-interface.md faf21625652 refactor: Drop deprecated space in operator""_mst c889890e4a3 Merge bitcoin/bitcoin#31264: doc: Fixup bitcoin-wallet manpage chain selection args 0f6d20e43f2 Merge bitcoin/bitcoin#31163: scripted-diff: get rid of remaining "command" terminology in protocol.{h,cpp} 5acd5e7f874 Merge bitcoin/bitcoin#31257: ci: make ctest stop on failure 19f277711eb Merge bitcoin/bitcoin#26593: tracing: Only prepare tracepoint arguments when actually tracing e80e4c6ff91 validation: Remove RECENT_CONSENSUS_CHANGE validation result fa729ab4a27 doc: Fixup bitcoin-wallet manpage chain selection args 5e3b444022c doc: Fix missing comma in JSON example in REST-interface.md 0903ce8dbc2 Merge bitcoin/bitcoin#30592: Remove mempoolfullrbf f842d0801e1 Merge bitcoin/bitcoin#29686: Update manpage descriptions 36a22e56833 ci: make ctest stop on failure 83fab3212c9 test: Add combinerawtransaction test to rpc_createmultisig 018e5fcc462 Merge bitcoin/bitcoin#31190: TxDownloadManager followups 3a5f6027e16 Merge bitcoin/bitcoin#31171: depends: Specify CMake generator explicitly 99d9a093cf6 test: clarify log messages when handling SOCKS5 proxy connections c9e67e214f0 Merge bitcoin/bitcoin#31238: fuzz: Limit wallet_notifications iterations 564238aabf1 Merge bitcoin/bitcoin#31164: net: Use actual memory size in receive buffer accounting fa461d7a43a fuzz: Limit wallet_notifications iterations ec375de39ff doc: Add missing 'blank=true' option in offline-signing-tutorial.md 5a96767e3f5 depends, libevent: Do not install *.pc files and remove patches for them ffda355b5a2 cmake, refactor: Move `HAVE_EVHTTP_...` to `libevent` interface b619bdc3303 cmake: Revamp `FindLibevent` module 2c90f8e08c4 Merge bitcoin/bitcoin#31232: ci: `add second_deadlock_stack=1` to TSAN options 5dc94d13d41 fuzz fix: assert MAX_PEER_TX_ANNOUNCEMENTS is not exceeded 45e2f8f87d8 Merge bitcoin/bitcoin#31173: cmake: Add `FindQRencode` module and enable `libqrencode` package for MSVC 80cb630bd94 Merge bitcoin/bitcoin#31216: Update secp256k1 subtree to v0.6.0 5161c2618cd ci: add second_deadlock_stack=1 to TSAN options 85224f92d52 Merge bitcoin/bitcoin#30811: build: Unify `-logsourcelocations` format 9719d373dc2 Merge bitcoin/bitcoin#30634: ci: Use clang-19 from apt.llvm.org 97235c446e9 build: Disable secp256k1 musig module 9e5089dbb02 build, msvc: Enable `libqrencode` vcpkg package 30089b0cb61 cmake: Add `FindQRencode` module 65b19419366 Merge bitcoin/bitcoin#31186: msvc: Update vcpkg manifest d3388720837 Merge bitcoin/bitcoin#31206: doc: Use relative hyperlinks in release-process.md ffc05fca6f7 Merge bitcoin/bitcoin#31220: doc: Fix word order in developer-notes.md 9f2c8287a24 Merge bitcoin/bitcoin#31192: depends, doc: List packages required to build `qt` package separately 03cff2c1421 Merge bitcoin/bitcoin#31191: build: Make G_FUZZING constexpr, require -DBUILD_FOR_FUZZING=ON to fuzz 44939e5de1b doc: Fix word order in developer-notes.md b934954ad10 Merge bitcoin/bitcoin#30670: doc: Extend developer-notes with file-name-only debugging fix 05aebe3790f Merge bitcoin/bitcoin#30930: netinfo: add peer services column and outbound-only option 0ba680d41b4 Update secp256k1 subtree to v0.6.0 2d46a89386d Squashed 'src/secp256k1/' changes from 2f2ccc46954..0cdc758a563 d22a234ed27 net: Use actual memory size in receive buffer accounting 047b5e2af1f streams: add DataStream::GetMemoryUsage c3a6722f34a net: Use DynamicUsage(m_type) in CSerializedNetMsg::GetMemoryUsage c6594c0b142 memusage: Add DynamicUsage for std::string 7596282a556 memusage: Allow counting usage of vectors with different allocators 6463117a292 Merge bitcoin/bitcoin#31208: doc: archive release notes for v27.2 788c1324f3d build: Unify `-logsourcelocations` format 4747f030956 depends, doc: List packages required to build `qt` package separately 1a05c86ae47 doc: archive release notes for v27.2 9f71cff6ab3 doc: Use relative hyperlinks in release-process.md f1bcf3edc50 Merge bitcoin/bitcoin#31139: test: added test to assert TX decode rpc error on submitpackage rpc 975b115e1a2 Merge bitcoin/bitcoin#31198: init: warn, don't error, when '-upnp' is set 4a0251c05dd Merge bitcoin/bitcoin#31187: ci: Do not error on unused-member-function in test each commit e001dc3dc6e Merge bitcoin/bitcoin#31203: fuzz: fix `implicit-integer-sign-change` in wallet_create_transaction 5a26cf7773e fuzz: fix `implicit-integer-sign-change` in wallet_create_transaction a1b3ccae4be init: warn, don't error, when '-upnp' is set c189eec848e doc: release note for mempoolrullrbf removal d47297c6aab rpc: Mark fullrbf and bip125-replaceable as deprecated 04a5dcee8ab docs: remove requirement to signal bip125 fafbf8acf41 Make G_FUZZING constexpr, require -DBUILD_FOR_FUZZING=ON to execute a fuzz target fae3cf0ffa6 ci: Temporarily disable macOS/Windows fuzz step f6577b71741 build, msvc: Update vcpkg manifest baseline 16e16013bfa build, msvc: Document `libevent` version pinning ec47cd2b508 build, msvc: Drop no longer needed `liblzma` version pinning 9a0734df5f1 build, msvc: Reorder keys in `vcpkg.json` 8351562bec6 [fuzz] allow negative time jumps in txdownloadman_impl 917ab810d93 [doc] comment fixups from n30110 f07a533dfcb Merge bitcoin/bitcoin#24214: Fix unsigned integer overflows in interpreter 62516105536 Merge bitcoin/bitcoin#31015: build: have "make test" depend on "make all" 4a31f8ccc9d Merge bitcoin/bitcoin#31156: test: Don't enforce BIP94 on regtest unless specified by arg 02be3dced71 Merge bitcoin/bitcoin#31166: key: clear out secret data in `DecodeExtKey` 54d07dd37d5 ci: Do not error on unused-member-function in test each commit 47f50c7af55 doc: add bitcoin-qt man description 40b82e3ab0a doc: add bitcoin-util man description a7bf80f3a2d doc: add bitcoin-tx man description 3f9a5168323 doc: add bitcoin-wallet man description d8c0bb23ef8 doc: add bitcoin-cli man description 09abccfa772 doc: add bitcoind man description 97b790e844a Merge bitcoin/bitcoin#29420: test: extend the SOCKS5 Python proxy to actually connect to a destination 6b73eb9a1a2 Merge bitcoin/bitcoin#31064: init: Correct coins db cache size setting 27d12cf17f2 Merge bitcoin/bitcoin#31043: rpc: getorphantxs follow-up 7b66815b16b Merge bitcoin/bitcoin#30110: refactor: TxDownloadManager + fuzzing dc97e7f6dba Merge bitcoin/bitcoin#30903: cmake: Add `FindZeroMQ` module 1b0b9b4c787 Extend possible debugging fixes with file-name-only da10e0bab4a Merge bitcoin/bitcoin#30942: test: Remove dead code from interface_zmq test 111a23d9b36 Remove -mempoolfullrbf option e96ffa98b04 Merge bitcoin/bitcoin#31142: test: fix intermittent failure in p2p_seednode.py, don't connect to random IPs 54c4b09f083 Merge bitcoin/bitcoin#31042: build: Rename `PACKAGE_*` variables to `CLIENT_*` e60cecc8115 doc: add release note for 31156 fc7dfb3df5b test: Don't enforce BIP94 on regtest unless specified by arg fabe90c8242 ci: Use clang-19 from apt.llvm.org 0de3e96e333 tracing: use bitcoind pid in bcc tracing examples 411c6cfc6c2 tracing: only prepare tracepoint args if attached d524c1ec066 tracing: dedup TRACE macros & rename to TRACEPOINT 70713303b63 scripted-diff: Rename `PACKAGE_*` variables to `CLIENT_*` 332655cb52c build: Rename `PACKAGE_*` variables to `CLIENT_*` e6e29e3c94c scripted-diff: Clarify "user agent" variable name e2ba8236715 depends: Specify CMake generator explicitly 1c7ca6e64de Merge bitcoin/bitcoin#31093: Introduce `g_fuzzing` global for fuzzing checks 6e21dedbf2b Merge bitcoin/bitcoin#31130: Drop miniupnp dependency d7fd766feb2 test: added test to assert TX decode rpc error on submitpackage rpc 559a8dd9c0a key: clear out secret data in `DecodeExtKey` 4120c7543ee scripted-diff: get rid of remaining "command" terminology in protocol.{h,cpp} 2a52718d734 Merge bitcoin/bitcoin#31152: functional test: Additional package evaluation coverage 9de9c858d5a test: enhance p2p_orphan_handling 33af14b62e4 test: reduce assert_debug_log reliance 0ea84bc362f test: explicitly check boolean verbosity is disallowed 7a2e6b68cd9 doc: add rpc guidance for boolean verbosity avoidance 698f302df8b rpc: disallow boolean verbosity in getorphantxs 63f5e6ec795 test: add entry and expiration time checks 808a708107e rpc: add entry time to getorphantxs 56bf3027144 refactor: rename rpc_getorphantxs to rpc_orphans 7824f6b0770 test: check that getorphantxs is hidden ac68fcca701 rpc: disallow undefined verbosity in getorphantxs 25dacae9c7f Merge bitcoin/bitcoin#31040: test: Assert that when we add the max orphan amount that we cannot add anymore and that a random orphan gets dropped 40e5f26a3ff mapport: remove dead code in DispatchMapPort 38fdf7c1fb1 mapport: drop outdated comments 915640e191b depends: zeromq: don't install .pc files and remove patches for them 6b8a74463b5 cmake: Add `FindZeroMQ` module 9a7206a34e3 Merge bitcoin/bitcoin#29536: fuzz: fuzz connman with non-empty addrman + ASMap d4abaf8c9d9 Merge bitcoin/bitcoin#29608: optimization: Preallocate addresses in GetAddr based on nNodes b7b24352906 doc: add release note for #31130 1b6dec98da3 depends: drop miniupnpc 953533d0214 doc: remove mentions of UPnP 94ad614482f ci: remove UPnP options f32c34d0c3d functional test: Additional package evaluation coverage 87532fe5585 netinfo: allow setting an outbound-only peer list 9f243cd7fa6 Introduce `g_fuzzing` global for fuzzing checks b95adf057a4 Merge bitcoin/bitcoin#31150: util: Treat Assume as Assert when evaluating at compile-time 8f24e492e20 Merge bitcoin/bitcoin#29991: depends: sqlite 3.46.1 2ef5004f78c Merge bitcoin/bitcoin#31146: ci: Temporary workaround for old CCACHE_DIR cirrus env 8c12fe828de Merge bitcoin/bitcoin#29936: fuzz: wallet: add target for `CreateTransaction` 5c299ecafe6 test: Assert that when we add the max orphan amount that we cannot add anymore and that a random orphan gets dropped 0f4bc635854 [fuzz] txdownloadman and txdownload_impl 699643f23a1 [unit test] MempoolRejectedTx fa584cbe727 [p2p] add TxDownloadOptions bool to make TxRequestTracker deterministic f803c8ce8dd [p2p] filter 1p1c for child txid in recent rejects 5269d57e6d7 [p2p] don't process orphan if in recent rejects 2266eba43a9 [p2p] don't find 1p1cs for reconsiderable txns that are AlreadyHaveTx fa7027d0fc1 [refactor] add CheckIsEmpty and GetOrphanTransactions, remove access to TxDownloadMan internals 969b07237b9 [refactor] wrap {Have,Get}TxToReconsider in txdownload f150fb94e7d [refactor] make AlreadyHaveTx and Find1P1CPackage private to TxDownloadImpl 1e08195135b [refactor] move new tx logic to txdownload 257568eab5b [refactor] move invalid package processing to TxDownload c4ce0c1218d [refactor] move invalid tx processing to TxDownload c6b21749ca0 [refactor] move valid tx processing to TxDownload a8cf3b6e845 [refactor] move Find1P1CPackage to txdownload f497414ce76 [refactor] put peerman tasks at the end of ProcessInvalidTx 6797bc42a76 [p2p] restrict RecursiveDynamicUsage of orphans added to vExtraTxnForCompact 798cc8f5aac [refactor] move Find1P1CPackage into ProcessInvalidTx 416fbc952b2 [refactor] move new orphan handling to ProcessInvalidTx c8e67b9169b [refactor] move ProcessInvalidTx and ProcessValidTx definitions down 3a41926d1b5 [refactor] move notfound processing to txdownload 042a97ce7fc [refactor] move tx inv/getdata handling to txdownload 58e09f244b4 [p2p] don't log tx invs when in IBD 288865338f5 [refactor] rename maybe_add_extra_compact_tx to first_time_failure f48d36cd97e [refactor] move peer (dis)connection logic to TxDownload f61d9e4b4b8 [refactor] move AlreadyHaveTx to TxDownload 84e4ef843db [txdownload] add read-only reference to mempool af918349de5 [refactor] move ValidationInterface functions to TxDownloadManager f6c860efb12 [doc] fix typo in m_lazy_recent_confirmed_transactions doc 5f9004e1550 [refactor] add TxDownloadManager wrapping TxOrphanage, TxRequestTracker, and bloom filters 947f2925d55 Merge bitcoin/bitcoin#31124: util: Remove RandAddSeedPerfmon 7640cfdd624 Merge bitcoin/bitcoin#31118: doc: replace `-?` with `-h` and `-help` 74fb19317ae Merge bitcoin/bitcoin#30849: refactor: migrate `bool GetCoin` to return `optional<Coin>` c16e909b3e2 Merge bitcoin/bitcoin#28574: wallet: optimize migration process, batch db transactions a9598e5eaab build: drop miniupnpc dependency a5fcfb7385c interfaces: remove now unused 'use_upnp' arg from 'mapPort' 038bbe7b200 daemon: remove UPnP support 844770b05eb qt: remove UPnP settings dd92911732d Merge bitcoin/bitcoin#31148: ci: display logs of failed unit tests automatically fa69a5f4b76 util: Treat Assume as Assert when evaluating at compile-time 0c79c343a9f Merge bitcoin/bitcoin#31147: cmake, qt, test: Remove problematic code 8523d8c0fc8 ci: display logs of failed tests automatically 2f40e453ccd Merge bitcoin/bitcoin#29450: build: replace custom `MAC_OSX` macro with existing `__APPLE__` cb7c5ca824e Add gdb and lldb links to debugging troubleshooting 6c6b2442eda build: Replace MAC_OSX macro with existing __APPLE__ fb46d57d4e7 cmake, qt, test: Remove problematic code fa9747a8961 ci: Temporary workaround for old CCACHE_DIR cirrus env 6c9fe7b73ea test: Prevent connection attempts to random IPs in p2p_seednodes.py bb97b1ffa9f test: fix intermittent timeout in p2p_seednodes.py 57529ac4dbb test: set P2PConnection.p2p_connected_to_node in peer_connect_helper() 22cd0e888c7 test: support WTX INVs from P2PDataStore and fix a comment ebe42c00aa4 test: extend the SOCKS5 Python proxy to actually connect to a destination 9bb92c0e7ff util: Remove RandAddSeedPerfmon c98fc36d094 wallet: migration, consolidate external wallets db writes 7c9076a2d2e wallet: migration, consolidate main wallet db writes 9ef20e86d7f wallet: provide WalletBatch to 'SetupDescriptorScriptPubKeyMans' 34bf0795fc0 wallet: refactor ApplyMigrationData to return util::Result<void> aacaaaa0d3a wallet: provide WalletBatch to 'RemoveTxs' 57249ff6697 wallet: introduce active db txn listeners 91e065ec175 wallet: remove post-migration signals connection 055c0532fc8 wallet: provide WalletBatch to 'DeleteRecords' 122d103ca22 wallet: introduce 'SetWalletFlagWithDB' 6052c7891dc wallet: decouple default descriptors creation from external signer setup f2541d09e13 wallet: batch MigrateToDescriptor() db transactions 66c9936455f bench: add coverage for wallet migration process 33a28e252a7 Change default help arg to `-help` and mention `-h` and `-?` as alternatives f0130ab1a1e doc: replace `-?` with `-h` for bench_bitcoin help 681ebcceca7 netinfo: rename and hoist max level constant to use in top-level help e7d307ce8cf netinfo: clarify relaytxes and addr_relay_enabled help docs eef2a9d4062 netinfo: add peer services column 3a4a788ee0d init: Correct coins db cache size setting 2957ca96119 build: have "make test" depend on "make all" bbbbaa0d9ac Fix unsigned integer overflows in interpreter c4dc81f9c69 test: Remove dead code from interface_zmq c495731a316 fuzz: wallet: add target for `CreateTransaction` 3db68e29ec6 wallet: move `ImportDescriptors`/`FuzzedWallet` to util 552cae243a1 fuzz: cover `ASMapHealthCheck` in connman target 33b0f3ae966 fuzz: use `ConsumeNetGroupManager` in connman target 18c8a0945bd fuzz: move `ConsumeNetGroupManager` to util fe624631aeb fuzz: fuzz `connman` with a non-empty addrman 0a12cff2a8e fuzz: move `AddrManDeterministic` to util 4feaa287284 refactor: Rely on returned value of GetCoin instead of parameter 46dfbf169b4 refactor: Return optional of Coin in GetCoin e31bfb26c21 refactor: Remove unrealistic simulation state ba621ffb9cb test: improve debug log message from P2PConnection::connection_made() def6dd0c597 depends: sqlite 3.46.1 66082ca3488 Preallocate addresses in GetAddr based on nNodes REVERT: 1047757ea3b kernel: Add pure kernel bitcoin-chainstate REVERT: c568fdf75fd kernel: Add block index utility functions to C header REVERT: 0f1da1dcba5 kernel: Add function to read block undo data from disk to C header REVERT: 45af559c9f6 kernel: Add functions to read block from disk to C header REVERT: 2a7f8a8240c kernel: Add function for copying block data to C header REVERT: b19f5336c03 kernel: Add functions for the block validation state to C header REVERT: 9c0ffa913f4 kernel: Add validation interface to C header REVERT: a93318c6152 kernel: Add interrupt function to C header REVERT: 51053f33720 kernel: Add import blocks function to C header REVERT: 6b0ada2af42 kernel: Add chainstate load options for in-memory dbs in C header REVERT: 34427bfa9c7 kernel: Add options for reindexing in C header REVERT: ca57311c969 kernel: Add block validation to C header REVERT: 44156d84838 Kernel: Add chainstate loading to kernel C header REVERT: 2cee46cdcc1 kernel: Add chainstate manager object to C header REVERT: 7102c7ae45e kernel: Add notifications context option to C header REVERT: ed628a2a3c4 kerenl: Add chain params context option to C header REVERT: 27643297ff7 kernel: Add kernel library context object REVERT: 2ba22cf3f90 kernel: Add logging to kernel library C header REVERT: 873874c03e9 kernel: Introduce initial kernel C header API git-subtree-dir: libbitcoinkernel-sys/bitcoin git-subtree-split: 48158303fe276cb2f8fbc53ff31a4162d8f55c84
bcd82b1 Remove pkgconfig from toolchain file (TheCharlatan) 319a4e8 depends: drop sqlite pkgconfig file (fanquake) a8fe1fd depends: better cleanup after fontconfig (fanquake) 17e79c9 depends: fully remove libtool archives from Qt build (fanquake) 8ca8565 guix: move pkg-config to Linux builds (fanquake) e3e648c depends: drop pkg-config option from Qt build (fanquake) 0d185bd doc: update depends doc to prefer .cmake outputs (fanquake) Pull request description: After #31181, `pkg-config` is no-longer needed for macOS or Windows Guix builds. It's still needed for Linux, as it's used by a Qt subdependency (fontconfig to find freetype). However we should also no-longer need it for Qt itself, when building using depends. ACKs for top commit: TheCharlatan: ACK bcd82b1 Tree-SHA512: 89ae68281030d43fcb6c5c96429cd038a21f13a8ca19ea828ada47e8f9f0aa7407854a67c9003652817e47ab9565573b7028342e3e11bb1cca1d823c483081cd
This PR generalizes the use of
find_package
/pkg_check_modules
, prioritizing the former.Addresses #30903 (comment):
Similar to #30903.