rpc: Remove submitblock pre-checks #31175

TheCharlatan · 2024-10-29T11:05:05Z

With the introduction of a mining ipc interface and the potential future introduction of a kernel library API it becomes increasingly important to offer common behaviour between them. An example of this is ProcessNewBlock, which is used by ipc, rpc, net_processing and (potentially) the kernel library. Having divergent behaviour on suggested pre-checks and checks for these functions is confusing to both developers and users and is a maintenance burden.

The rpc interface for ProcessNewBlock (submitblock) currently pre-checks if the block has a coinbase transaction and whether it has been processed before. While the current example binary for how to use the kernel library, bitcoin-chainstate, imitates these checks, the other interfaces do not.

The coinbase check is repeated again early during ProcessNewBlock. Pre-checking it may also shadow more fundamental problems with a block. In most cases the block header is checked first, before validating the transactions. Checking the coinbase first therefore masks potential issues with the header. Fix this by removing the pre-check.

Similary the duplicate checks are repeated early in the contextual checks of ProcessNewBlock. If duplicate blocks are detected much of their validation is skipped. Depending on the constitution of the block, validating the merkle root of the block is part of the more intensive workload when validating a block. This could be an argument for moving the pre-checks into block processing. In net_processing this would have a smaller effect however, since the block mutation check, which also validates the merkle root, is done before.

Testing spamming a node with valid, but duplicate unrequested blocks seems to exhaust a CPU thread, but does not seem to significantly impact keeping up with the tip. The benefits of adding these checks to net_processing are questionable, especially since there are other ways to trigger the more CPU-intensive checks without submitting a duplicate block. Since these DOS concerns apply even less to the RPC interface, which does not have banning mechanics built in, remove them too.

Finally, also remove the pre-checks from bitcoin-chainstate.cpp.

This PR is part of the libbitcoinkernel project.

DrahtBot · 2024-10-29T11:05:08Z

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31175.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	Sjors, instagibbs, mzumsande, achow101

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#31384 (mining: bugfix: Fix duplicate coinbase tx weight reservation by ismaelsadeeq)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

mzumsande

Haven't looked deeply yet, just wanted to mention #10146, which introduced the coinbase check and was even backported (see also #10190 for a regression test). Makes me wonder if there is more historical context to this.

TheCharlatan · 2024-10-31T10:11:09Z

Makes me wonder if there is more historical context to this.

Yes, me too. If there are good reasons to keep these checks, then we should document why (and why they are not needed for the other interfaces). I could not come up with one, so I opened this PR, but I may well be missing something.

instagibbs · 2024-11-01T20:50:47Z

my guess is from #10146 this commit ada0caa looks like a covert fix for submitblock with a completely empty block. https://github.com/bitcoin/bitcoin/blob/master/src/rpc/mining.cpp#L1041 shows that it will call:

UpdateUncommittedBlockStructures -> GetWitnessCommitmentIndex which would result in UB, before any PoW checks are made.

mzumsande

Concept ACK

I agree with the general motivation. While this PR can change the error message of submitblock in case more than one thing is wrong with the block, I don't really see why one is more important than the other.

UpdateUncommittedBlockStructures -> GetWitnessCommitmentIndex which would result in UB, before any PoW checks are made.

Nice find!
I think that it would be good to have a test that would trigger the UB if ada0caa was reverted (it requires us to know the header so that UpdateUncommittedBlockStructures() gets called, so the added test for an empty block doesn't trigger it - could make another deepcopy of block instead and then delete the txns):

Fix this by removing the pre-check, but still throwing the same more expressive exception in case a coinbase validation error occurs.

I realize that you want to keep the existing behavior in this PR, but I do wonder if it really makes sense to have other consensus errors return "rejected", and this particular one to throw an exception.

TheCharlatan · 2024-11-07T21:18:33Z

Updated e742d66 -> b83d509 (submitblock_prechecks_0 -> submitblock_prechecks_1, compare)

Addressed @mzumsande's comment, added a small addition to the functional test for checking blocks with no transactions.
Mentioned the commit introducing the patch to GetWitnessCommitmentIndex in the commit message.

I realize that you want to keep the existing behavior in this PR, but I do wonder if it really makes sense to have other consensus errors return "rejected", and this particular one to throw an exception.

Yeah, I also don't think it makes a lot of sense, and even though it looks like the original description in #10146 was used to mask an actual problem, it does still mention the distinct error message as an improvement, so not sure if removing it could be annoying for users.

test/functional/mining_basic.py

TheCharlatan · 2024-11-08T09:30:08Z

Updated b83d509 -> 309bd56 (submitblock_prechecks_1 -> submitblock_prechecks_2, compare)

Removed throw on missing coinbase in submitblock.

mzumsande · 2024-11-18T19:31:49Z

src/rpc/mining.cpp

-        const CBlockIndex* pindex = chainman.m_blockman.LookupBlockIndex(hash);
-        if (pindex) {
-            if (pindex->IsValid(BLOCK_VALID_SCRIPTS)) {
-                return "duplicate";


I think that this will change behavior in the case where we re-submit a previously pruned block with submitblock:

On master, we'd skip early here and return "duplicate" because the index is still BLOCK_VALID_SCRIPTS-valid.
But with his branch, we'd accept the block and save it to disk once more.

I'm really unsure if that is an undesired change in behavior or not - I guess it could also be viewed as a feature.
In any case, it's a behavior change that should be documented if we do go through with it.

Good catch, thank you for taking another look! I'm also not sure what to do in light of this. At the minimum this reason for the duplicate check should be documented. I feel like with this kind of change I would err on the conservative side and not introduce potentially breaking behaviour. Even if this might be a nice way to inject block data into the node, I don't know if this is something anybody needs, even if it now more closely mimics getblockfrompeer.

We could keep the duplicate check and remove the invalid duplicate check, but I feel like requiring a pre-check to handle the pruning and force processing case is not very elegant. At the same time we can't move the check into ProcessNewBlock, since it would break getblockfrompeer as far as I can tell. What do you think?

bitcoin-chainstate currently does not support pruning (though it also sets force processing), so removing it there should not have the same effect.

err on the conservative side and not introduce potentially breaking behaviour

Generally speaking, I don't see reason why we should artificially restrict a user from submitting a previously pruned block via RPC, when they could request that block via getblockfrompeer, and I can't of use cases it would break.

Maybe one way to move forward would be to not remove the duplicate check in this PR (but document why it exists) - and instead remove it in a follow-up PR, together with a release note about the changed behavior.

@Sjors: FYI, since you introduced getblockfrompeer, do you remember any discussions about also allowing to re-submit previously pruned blocks via RPC / do you see a problem with that?

The only danger I can foresee is if someone was somehow relying on them not being able to be committed to disk again. Would there be any performance concerns with commiting+re-pruning or similar?

I decided to add a release note for now. I think the changes in this PR are small enough that we can hash the changes out wholesale and it is also not a particularly pressing change. Still not wholly convinced, but thinking about it some more I don't think somebody was relying on this behaviour beforehand either.

@mzumsande I don't recall such discussions. The only thing that matters for getblockfrompeer is that it can store previously pruned blocks.

That said, I do think it's useful to allow submitblock to store a previously pruned block. It lets a user dump the block on one node and submit it on this node, without having go through the effort of establishing a p2p connection, figuring out the peer id and then calling getblockfrompeer.

@maflcko it's probably useful to briefly reopen #10146 and link to this thread for the likely real reason for that PR.

I'm speculating it was done in a stealthy way because there might be someone running a public service to submit blocks, and it would use that RPC under the hood. Or they were worried that since mining pools use this RPC internally (see e.g. #3658, #5538 (comment)) they might have it exposed to the internet - or at least blindly forward "blocks" to it. And therefore could be attacked.

cc @dergoegge @darosior in case you want to add it to the disclosure overview.

I do not have the context nor the bug report behind this fix, but #10146 is clearly preventing a crash on accessing block->vtx[0] when an empty block is submitted through submitblock. In addition the introduction of the check for a valid coinbase transaction smells like preventing https://gnusha.org/url/?https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2019-February/016697.html but i can't think of how it could be exploited.

Typically you would think of an attack along these lines:

Miner A is exposing submitblock.

Miner B mines a valid block and a malleated, invalid, block with the same hash.

Miner B sends the malleated block to Miner A's submitblock API, which stores it as invalid.

Miner A broadcasts his valid block.

Miner B rejects it. REKT.

But submitblock uses ProcessNewBlock to store the block. And #10146 is after #9765, which makes sure CheckBlock is called (and therefore the coinbase check performed) before persisting the header.

@gmaxwell was there more to #10146 than the crash fix?

TheCharlatan · 2024-11-21T12:27:27Z

309bd56 -> 563278b (submitblock_prechecks_2 -> submitblock_prechecks_3, compare)

Added release notes documenting the submitblock change w.rt. duplicate block handling and pruning.
Split the changes into more incremental commits.

Sjors · 2024-11-21T15:26:00Z

Note that #31196 proposes to drop processNewBlock() from the Mining IPC interface, which straight-forwardly uses ProcessNewBlock. The interface does still use it via submitSolution().

Sjors · 2024-11-21T15:55:46Z

Something I noticed while looking at df7ad92

The release notes of 0.18 "promise" that the RPC never returns duplicate-invalid:

- The `submitblock` RPC previously returned the reason a rejected block
  was invalid the first time it processed that block, but returned a
  generic "duplicate" rejection message on subsequent occasions it
  processed the same block.  It now always returns the fundamental
  reason for rejecting an invalid block and only returns "duplicate" for
  valid blocks it has already accepted.

Strangely however mining_basic.py has two checks for duplicate-invalid. Those were introduced were introduced in the same v0.18 release: commit fa6ab8a of #13983.

Update: the real behaviour seems to be that we give the real reason for early checks, but return duplicate-invalid if later checks failed previously. The change in df7ad92 seems compatible with that.

test/functional/mining_basic.py

Sjors

utACK 563278b

It would be good to test the new pruned node behavior, in a way similar to rpc_getblockfrompeer.py.

doc/release-notes-31175.md

instagibbs · 2024-11-21T17:39:25Z

minimal test case for pruning, feel free to take: https://gist.github.com/instagibbs/cb1f7cfbd0a70e8b5393e457c7a959e6

The coinbase check is repeated again early during ProcessNewBlock. Pre-checking it may also shadow more fundamental problems with a block. In most cases the block header is checked first, before validating the transactions. Checking the coinbase first therefore masks potential issues with the header. Fix this by removing the pre-check. The pre-check was likely introduced on top of ada0caa to fix UB in GetWitnessCommitmentIndex in case a block's transactions are empty. This code path could only be reached because of the call to UpdateUncommittedBlockStructures in submitblock, but cannot be reached through net_processing. Add some functional test cases to cover the previous conditions that lead to a "Block does not start with a coinbase" json rpc error being returned. --- With the introduction of a mining ipc interface and the potential future introduction of a kernel library API it becomes increasingly important to offer common behaviour between them. An example of this is ProcessNewBlock, which is used by ipc, rpc, net_processing and (potentially) the kernel library. Having divergent behaviour on suggested pre-checks and checks for these functions is confusing to both developers and users and is a maintenance burden. The rpc interface for ProcessNewBlock (submitblock) currently pre-checks if the block has a coinbase transaction and whether it has been processed before. While the current example binary for how to use the kernel library, bitcoin-chainstate, imitates these checks, the other interfaces do not.

ProcessNewBlock fails if an invalid duplicate block is passed in through its call to AcceptBlock and AcceptBlockHeader. The failure in AcceptBlockHeader makes AcceptBlock return early. This makes the pre-check in submitblock redundant. --- With the introduction of a mining ipc interface and the potential future introduction of a kernel library API it becomes increasingly important to offer common behaviour between them. An example of this is ProcessNewBlock, which is used by ipc, rpc, net_processing and (potentially) the kernel library. Having divergent behaviour on suggested pre-checks and checks for these functions is confusing to both developers and users and is a maintenance burden. The rpc interface for ProcessNewBlock (submitblock) currently pre-checks if the block has a coinbase transaction and whether it has been processed before. While the current example binary for how to use the kernel library, bitcoin-chainstate, imitates these checks, the other interfaces do not.

The duplicate checks are repeated early in the contextual checks of ProcessNewBlock. If duplicate blocks are detected much of their validation is skipped. Depending on the constitution of the block, validating the merkle root of the block is part of the more intensive workload when validating a block. This could be an argument for moving the pre-checks into block processing. In net_processing this would have a smaller effect however, since the block mutation check, which also validates the merkle root, is done before. A side effect of this change is that a duplicate block is persisted again on disk even when pruning is activated. This is similar to the behaviour with getblockfrompeer. Add a release note for this change in behaviour. Testing spamming a node with valid, but duplicate unrequested blocks seems to exhaust a CPU thread, but does not seem to significantly impact keeping up with the tip. The benefits of adding these checks to net_processing are questionable, especially since there are other ways to trigger the more CPU-intensive checks without submitting a duplicate block. Since these DOS concerns apply even less to the RPC interface, which does not have banning mechanics built in, remove them too. --- With the introduction of a mining ipc interface and the potential future introduction of a kernel library API it becomes increasingly important to offer common behaviour between them. An example of this is ProcessNewBlock, which is used by ipc, rpc, net_processing and (potentially) the kernel library. Having divergent behaviour on suggested pre-checks and checks for these functions is confusing to both developers and users and is a maintenance burden. The rpc interface for ProcessNewBlock (submitblock) currently pre-checks if the block has a coinbase transaction and whether it has been processed before. While the current example binary for how to use the kernel library, bitcoin-chainstate, imitates these checks, the other interfaces do not.

This tests the new submitblock behaviour that is introduced in the previous commit: Submitting a previously pruned block should persist the block's data again.

The behaviour of submitblock was changed in the previous commit, so change it here too.

TheCharlatan · 2024-11-21T21:23:51Z

Thank you for the reviews and the test case @instagibbs,

Updated 563278b -> 73db95c (submitblock_prechecks_3 -> submitblock_prechecks_4, compare)

Addressed @Sjors' comment, improved the logging, but did not split it into its own commit. Should be clear enough with the other changes now.
Addressed @Sjors' comment, fixed typo.
Added suggested patch from @instagibbs in its own commit.

Sjors · 2024-11-22T08:31:26Z

re-utACK 73db95c

I also checked that submitblock in the new test fails with duplicate if you revert 1f7fc73.

instagibbs

ACK 73db95c

Not an expert here but motivation makes a lot of sense, and good to remove such indirect code from past covert fixes

mzumsande

ACK 73db95c
Reviewed the code (didn't look closely at bitcoin-chainstate.cpp) and tested it a little bit.

mzumsande · 2024-11-27T16:29:56Z

src/rpc/mining.cpp

-    uint256 hash = block.GetHash();
-    {
-        LOCK(cs_main);
-        const CBlockIndex* pindex = chainman.m_blockman.LookupBlockIndex(hash);


nit: If, after this PR, we re-submit genesis via submitblock, a different code path will be taken than for non-genesis duplicate blocks:
We won't return early in AcceptBlockHeader, will actually call AddToBlockIndex(), and write an incorrect log message
Saw new header hash=0f9188f13cb7b2c71f2a335e3a4fc328bf5beb436012afca590b1a11466e2206 height=0 for each submitblock call.
Not a real problem though because nothing fails and why would you do that in the first place.

This is also a debug only log, and it otherwise does not seem to be hitting any hot code paths, so I am not too concerned either.

it's unconditional once out of IBD. But allowing untrusted parties access to this rpc is unsafe anyway (can spam the node with low-work blocks since force_processing and min_pow_checked are true for the ProcessNewBlock call).

achow101 · 2024-12-03T22:21:31Z

ACK 73db95c

…90df267df 6090df267df kernel: Add pure kernel bitcoin-chainstate 29e3b874303 kernel: Add functions to get the block hash from a block 97d83063cb6 kernel: Add block index utility functions to C header 76ead0878a3 kernel: Add function to read block undo data from disk to C header 94c215c4212 kernel: Add functions to read block from disk to C header aff05fcbe62 kernel: Add function for copying block data to C header a379fbe15eb kernel: Add functions for the block validation state to C header 81db1665213 kernel: Add validation interface to C header 0ee7a5f58a6 kernel: Add interrupt function to C header f68b3dbf919 kernel: Add import blocks function to C header 503aae9afc5 kernel: Add chainstate load options for in-memory dbs in C header fa1335fd809 kernel: Add options for reindexing in C header 0eb020f9c82 kernel: Add block validation to C header 5f471729674 Kernel: Add chainstate loading to kernel C header 90949cbb09d kernel: Add chainstate manager option for setting worker threads a2021b517c6 kernel: Add chainstate manager object to C header 428ea46909b kernel: Add notifications context option to C header b1f5d450323 kerenl: Add chain params context option to C header 7bb4b412db0 kernel: Add kernel library context object e4b63d7f5d9 kernel: Add logging to kernel library C header 47bb56b243e kernel: Introduce initial kernel C header API ff873a20a7f Merge bitcoin/bitcoin#31313: refactor: Clamp worker threads in ChainstateManager constructor c9a7418a8df Merge bitcoin/bitcoin#31096: Package validation: accept packages of size 1 6f24662eb96 Merge bitcoin/bitcoin#31175: rpc: Remove submitblock pre-checks 3867d2421ae Merge bitcoin/bitcoin#31112: Improve parallel script validation error debug logging 8e02b480591 Merge bitcoin/bitcoin#31284: ci: Skip broken Wine64 tests by default 492e1f09943 [validation] merge all ConnectBlock debug logging code paths b49df703f03 [validation] include all logged information in BlockValidationState 7b267c034fd [validation] Add detailed txin/txout information for script error messages 146a3d54268 [validation] Make script error messages uniform for parallel/single validation 1ac1c33f3f1 [checkqueue] support user-defined return type through std::optional ebe4cac38bf Merge bitcoin/bitcoin#30991: test: enable running independent functional test sub-tests 19276741007 Merge bitcoin/bitcoin#31387: doc: Use more precise anchor link to codesigning docs e043618d44d Merge bitcoin/bitcoin#31396: test: simple reordering to reduce run time a25b892ab1f Merge bitcoin/bitcoin#31386: doc: Use more precise anchor links to Xcode SDK extraction eb646111cdc Merge bitcoin/bitcoin#31383: test: Add missing node.setmocktime(self.mocktime) to p2p_ibd_stalling.py 6cd95de2e02 Merge bitcoin/bitcoin#31395: build: Set shared linker flags in toolchain file abeebccc480 Merge bitcoin/bitcoin#31357: cmake: Improve build script correctness 4c9b13841c4 Merge bitcoin/bitcoin#31402: doc: correct libfuzzer-nosan preset flag da4f4fac8df Merge bitcoin/bitcoin#31361: cmake, qt: Use absolute paths for includes in MOC-generated files 16b140f225a doc: correct libfuzzer-nosan preset flag 097c66f6148 Merge bitcoin/bitcoin#30039: dbwrapper: Bump LevelDB max file size to 32 MiB to avoid system slowdown from high disk cache flush rate 68daaea0e48 Merge bitcoin/bitcoin#31390: Remove `src/config` directory 14f162dc5c8 Merge bitcoin/bitcoin#31399: ci, macos: Install `pkgconf` Homebrew's package e2f2698395c ci, macos: Install `pkgconf` Homebrew's package b73d3319377 dbwrapper: Bump max file size to 32 MiB 62f6d9e1a48 test: simple ordering optimization to reduce runtime a8e04704f93 build: Set shared linker flags in toolchain file dbc8ba12f3b Merge bitcoin/bitcoin#31371: doc, test: more ephemeral dust follow-ups 935973b315f Remove `src/config` directory 19f49c7489d doc: Use more precise anchor link to codesigning docs 8bf1b3039cb doc: Use more precise anchor links to Xcode SDK extraction 7590e93bc73 Merge bitcoin/bitcoin#30986: contrib: skip missing binaries in gen-manpages b2af068825c Merge bitcoin/bitcoin#30708: rpc: add getdescriptoractivity 144f98db85e Merge bitcoin/bitcoin#31337: build: Fix coverage builds faa16ed4b9e test: Add missing node.setmocktime(self.mocktime) to p2p_ibd_stalling.py efdb49afb9e Merge bitcoin/bitcoin#31323: guix: swap `moreutils` for just `sponge` 37a5c5d8366 doc: update descriptors.md for getdescriptoractivity ee3ce6a4f4d test: rpc: add no address case for getdescriptoractivity 811f76f3a51 rpc: add getdescriptoractivity ee6185372fc gen-manpages: Prompt error if no binaries are found 70e20ea024c Merge bitcoin/bitcoin#31172: build: increase minimum supported Windows to 10.0 733317ba943 Merge bitcoin/bitcoin#31364: refactor: Fix remaining clang-tidy performance-unnecessary-copy-initialization errors 5a4bc5c0366 Merge bitcoin/bitcoin#31305: refactor: Fix remaining clang-tidy performance-inefficient-vector errors 28fd0bc7316 Merge bitcoin/bitcoin#31365: interpreter: Use the same type for SignatureHash in the definition 72ab35a6d09 Merge bitcoin/bitcoin#31221: ci: Split out native fuzz jobs for macOS and windows (take 2) 160799d9135 test: refactor: introduce `create_ephemeral_dust_package` helper 61e18dec306 doc: ephemeral policy: add missing closing double quote 32fc59796f7 rpc: Allow single transaction through submitpackage 3305972f7bf refactor: Fix remaining clang-tidy performance-unnecessary-copy-initialization errors 11f3bc229cc refactor: Reserve vectors in fuzz tests 152fefe7a22 refactor: Preallocate PrevectorFillVector(In)Direct without vector resize a774c7a339c refactor: Fix remaining clang-tidy performance-inefficient-vector errors f7144b24be0 Merge bitcoin/bitcoin#31279: policy: ephemeral dust followups c288c790cd9 interpreter: Use the same type for SignatureHash in the definition b031b7910d6 [ci] Split out native fuzz jobs for macOS and windows 6f4128e3a83 cmake, qt: Use absolute paths for includes in MOC-generated files ab5c63edcce cmake: Build `secp256k1` only when required 76a3a540a4c cmake: Ensure script correctness when no targets are specified e8f50c5debe guix: swap moreutils for just sponge 01a7298818d build: Avoid using the `-ffile-prefix-map` compiler option 2638fdb4f93 Merge bitcoin/bitcoin#31338: test: Deduplicate assert_mempool_contents() 73db95c65c1 kernel: Make bitcoin-chainstate's block validation mirror submitblock's bb53ce9bdae tests: Add functional test for submitting a previously pruned block 1f7fc738255 rpc: Remove submitblock duplicate pre-check e62a8abd7df rpc: Remove submitblock invalid-duplicate precheck 36dbebafb9b rpc: Remove submitblock coinbase pre-check 17834bd1976 Merge bitcoin/bitcoin#31333: fuzz: Implement G_TEST_GET_FULL_NAME cf577227888 Merge bitcoin/bitcoin#31335: macOS: swap docs & CI from pkg-config to pkgconf fe3457ccfff ci: note that we should install pkgconf in future a0eafc10f94 functional test: Deduplicate assert_mempool_contents() 8d203480b33 doc: migrate from pkg-config to pkgconf in macOS build docs 466e4df3fb8 assert_mempool_contents: assert not duplicates expected ea5db2f2692 functional: only generate required blocks for test d033acb6083 fuzz: package_eval: let fuzzer run out input in main tx creation loop ba35a570c5d CheckEphemeralSpends: return boolean, and set child state and txid outparams cf0cee1617c func: add note about lack of 1P1C propagation in tree submitpackage 84242903043 unit test: ephemeral_tests is using a dust relay rate, not minrelay d9cfa5fc4eb CheckEphemeralSpends: no need to iterate inputs if no parent dust 87b26e3dc07 func: rename test_free_relay to test_no_minrelay_fee e5709a4a41e func: slight elaboration on submitpackage restriction 08e969bd107 RPC: only enforce dust rules on priority when standardness active ca050d12e76 unit test: adapt to changing MAX_DUST_OUTPUTS_PER_TX 7c3490169c9 fuzz: package_eval: move last_tx inside txn ctor 445eaed182a fuzz: use optional status instead of should_rbf_eph_spend 4dfdf615b9d fuzz: remove unused TransactionsDelta validation interface 09ce926e4a1 func: cleanup reorg test comment 768a0c1889e func: cleanup test_dustrelay comments bedca1cb663 fuzz: Directly place transactions in vector c041ad6eccb fuzz: explain package eval coin tracking better bc0d98ea612 fuzz: remove dangling reference to GetEntry 15b6cbf07f5 unit test: make dust index less magical 5fbcfd12b8f unit test: assert txid returned on CheckEphemeralSpends failures ef94d84b4e4 bench: remove unnecessary CMTxn constructors c5c10fd317c ephemeral policy doxygen cleanup dd9044b8d46 ephemeral policy: IWYU c6859ce2de7 Move+rename GetDustIndexes -> GetDust 22ef95dbe3e Merge bitcoin/bitcoin#31288: Add destroy to BlockTemplate schema 92d3d691f09 fuzz: Implement G_TEST_GET_FULL_NAME f34fe0806a0 Merge bitcoin/bitcoin#31122: cluster mempool: Implement changeset interface for mempool b2d952c0f5b Merge bitcoin/bitcoin#31331: doc: add copyright header to p2p_headers_presync 7d3703dec3d doc: add copyright header to p2p_headers_presync 116b8c55736 Merge bitcoin/bitcoin#31213: fuzz: Fix difficulty target generation in `p2p_headers_presync` 15c1f47a005 Merge bitcoin/bitcoin#31327: doc: Correct PR Review Club frequency from weekly to monthly 1209a1082c8 Merge bitcoin/bitcoin#31315: build: Enable -Wbidi-chars=any ab22726def9 Merge bitcoin/bitcoin#31276: guix: scope pkg-config to Linux only 637f437a164 doc: remove PR Review Club frequency e1223099584 Merge bitcoin/bitcoin#31317: test: Revert to random path element 2666d83da59 Merge bitcoin/bitcoin#30893: test: Introduce ensure_for helper faaaf59f71e test: Make g_rng_temp_path rand, not dependent on SeedRandomForTest 746f93b4f0f Merge bitcoin/bitcoin#31307: build: Temporarily disable compiling `fuzz/utxo_snapshot.cpp` with MSVC 25fe087de59 rpc: move-only: move ScriptPubKeyDoc to utils fa80b08fef0 test: Revert to random path element 8f85d36d68a refactor: Clamp worker threads in ChainstateManager constructor fa7857ccda5 build: Enable -Wbidi-chars=any b2d53610028 build: Temporarily disable compiling `fuzz/utxo_snapshot.cpp` with MSVC 9aa50152c1c Add destroy to BlockTemplate schema ccc2d3abcd3 Merge bitcoin/bitcoin#31287: refactor: Avoid std::string format strings 62016b32300 Use std::ranges for ephemeral policy checks 3ed930a1f41 Have HasDust and PreCheckValidEphemeralTx take CTransaction 04a614bf9a7 Rename CheckValidEphemeralTx to PreCheckEphemeralTx 85bcfeea235 Merge bitcoin/bitcoin#30666: validation: fix m_best_header tracking and BLOCK_FAILED_CHILD assignment 2257c6d68fa Merge bitcoin/bitcoin#30487: ci: skip Github CI on branch pushes for forks 380e1f44e8e Merge bitcoin/bitcoin#30349: benchmark: Improve SipHash_32b accuracy to avoid potential optimization issues 1a8f51e7453 Merge bitcoin/bitcoin#28843: [refactor] Cleanup BlockAssembler mempool usage 2d944e982c4 Merge bitcoin/bitcoin#31285: guix: remove `util-linux` bcd82b13f46 Remove pkgconfig from toolchain file 319a4e82614 depends: drop sqlite pkgconfig file fa1177e3d7c refactor: Avoid std::string format strings a8fe1fd38bf depends: better cleanup after fontconfig 17e79c92607 depends: fully remove libtool archives from Qt build 8ca85651c83 guix: move pkg-config to Linux builds e3e648cf410 depends: drop pkg-config option from Qt build 0d185bd99f9 doc: update depends doc to prefer .cmake outputs e546b4e1a0c Merge bitcoin/bitcoin#31225: doc: Fix grammatical errors in multisig-tutorial.md f44e39c9d0d Merge bitcoin/bitcoin#31174: tinyformat: Add compile-time checking for literal format strings 299e2220e95 gen-manpages: implement --skip-missing-binaries 5736d1ddacc tracing: pass if replaced by tx/pkg to tracepoint a4ec07f1944 doc: add comments for CTxMemPool::ChangeSet 83f814b1d11 Remove m_all_conflicts from SubPackageState d3c8e7dfb63 Ensure that we don't add duplicate transactions in rbf fuzz tests d7dc9fd2f7b Move CalculateChunksForRBF() to the mempool changeset 284a1d33f1d Move prioritisation into changeset 446b08b599b Don't distinguish between direct conflicts and all conflicts when doing cluster-size-2-rbf checks b53041021ab Duplicate transactions are not permitted within a changeset b447416fddc Public mempool removal methods Assume() no changeset is outstanding 2b30f4d36c8 Make RemoveStaged() private 18829194ca6 Enforce that there is only one changeset at a time 7fb62f7db60 Apply mempool changeset transactions directly into the mempool 34b6c5833d1 Clean up FinalizeSubpackage to avoid workspace-specific information 57983b8add7 Move LimitMempoolSize to take place outside FinalizeSubpackage 01e145b9758 Move changeset from workspace to subpackage 802214c0832 Introduce mempool changesets 87d92fa3401 test: Add unit test coverage of package rbf + prioritisetransaction 15d982f91e6 Add package hash to package-rbf log message fa5e7064597 ci: Skip broken Wine64 tests by default 4d668549825 ci: remove util-linux from centos CI cdf34be7c94 guix: remove util-linux cbf1a47d606 CheckEphemeralSpends: only compute txid of tx when needed 111465d72dd test: Remove unused attempts parameter from wait_until 5468a23eb9a test: Add check_interval parameter to wait_until 16c87d91fd4 test: Introduce ensure_for helper a6ca8f32439 fuzz: Fix difficulty target generation in p2p_headers_presync 8610bcef9d0 ci: skip Github CI on branch pushes for forks 409d0d62937 test: enable running individual independent functional test methods ee1128ead84 doc: update stack-clash-protection comment re mingw-w64 bf47448f152 test: drop check for Windows < 10 35b898c47f8 release: target Windows 10 or later 398754e70bc depends: target Windows 10 when building for mingw-w64 ac286e0d1bd doc: Fix grammatical errors in multisig-tutorial.md fa327c77e34 util: Add ConsumeArithUInt256InRange fuzzing helper 42066f45ff5 Refactor SipHash_32b benchmark to improve accuracy and avoid optimization issues fe39acf88ff tinyformat: Add compile-time checking for literal format strings 184f34f2d0f util: Support dynamic width & precision in ConstevalFormatString 192dac1d337 [refactor] Cleanup BlockAssembler mempool usage 0bd53d913c1 test: add test for getchaintips behavior with invalid chains ccd98ea4c88 test: cleanup rpc_getchaintips.py f5149ddb9b7 validation: mark blocks building on an invalid block as BLOCK_FAILED_CHILD 783cb7337f7 validation: call RecalculateBestHeader in InvalidChainFound 9275e9689a4 rpc: call RecalculateBestHeader as part of reconsiderblock a51e91783aa validation: add RecalculateBestHeader() function REVERT: 403c20980ec kernel: Add pure kernel bitcoin-chainstate REVERT: 2e1b262eff6 kernel: Add functions to get the block hash from a block REVERT: f0b56a6052a kernel: Add block index utility functions to C header REVERT: 9393cf98179 kernel: Add function to read block undo data from disk to C header REVERT: e2ccfba0e3e kernel: Add functions to read block from disk to C header REVERT: 0559575861c kernel: Add function for copying block data to C header REVERT: 7b02e52237e kernel: Add functions for the block validation state to C header REVERT: fdebacca7ad kernel: Add validation interface to C header REVERT: f4ea5f49c6d kernel: Add interrupt function to C header REVERT: 5f4b436aad9 kernel: Add import blocks function to C header REVERT: c95a28fd80c kernel: Add chainstate load options for in-memory dbs in C header REVERT: d6360557ef6 kernel: Add options for reindexing in C header REVERT: a125867b9fe kernel: Add block validation to C header REVERT: b2b75a0ef73 Kernel: Add chainstate loading to kernel C header REVERT: d233003ff2a kernel: Add chainstate manager option for setting worker threads REVERT: 3610be3b138 kernel: Add chainstate manager object to C header REVERT: c194bea41f6 kernel: Add notifications context option to C header REVERT: 691d89d846b kerenl: Add chain params context option to C header REVERT: 407ca750cda kernel: Add kernel library context object REVERT: ee3c4ea92cd kernel: Add logging to kernel library C header REVERT: e6c610a7e03 kernel: Introduce initial kernel C header API git-subtree-dir: libbitcoinkernel-sys/bitcoin git-subtree-split: 6090df267dfece6192b567fed6582445aa811e7f

20eec64b5e kernel: Add pure kernel bitcoin-chainstate 1522ee9596 kernel: Add functions to get the block hash from a block c543cadc90 kernel: Add block index utility functions to C header 6b5a4fed43 kernel: Add function to read block undo data from disk to C header 6b53c3ba1a kernel: Add functions to read block from disk to C header 7f9908ad99 kernel: Add function for copying block data to C header 1ab71ac371 kernel: Add functions for the block validation state to C header 508dd4db98 kernel: Add validation interface to C header a6a658e5f8 kernel: Add interrupt function to C header 253c3cd36f kernel: Add import blocks function to C header 3ed633b6c4 kernel: Add chainstate load options for in-memory dbs in C header 08ec37f8ce kernel: Add options for reindexing in C header ad0875e397 kernel: Add block validation to C header 2575018d69 Kernel: Add chainstate loading to kernel C header f5d21c94dc kernel: Add chainstate manager option for setting worker threads 783f56f0a2 kernel: Add chainstate manager object to C header 262039e409 kernel: Add notifications context option to C header dc0d406dd5 kerenl: Add chain params context option to C header b5f84de7ad kernel: Add kernel library context object dad0009c86 kernel: Add logging to kernel library C header 27e25aa941 kernel: Introduce initial kernel C header API ff873a20a7 Merge bitcoin/bitcoin#31313: refactor: Clamp worker threads in ChainstateManager constructor c9a7418a8d Merge bitcoin/bitcoin#31096: Package validation: accept packages of size 1 6f24662eb9 Merge bitcoin/bitcoin#31175: rpc: Remove submitblock pre-checks 3867d2421a Merge bitcoin/bitcoin#31112: Improve parallel script validation error debug logging 8e02b48059 Merge bitcoin/bitcoin#31284: ci: Skip broken Wine64 tests by default 492e1f0994 [validation] merge all ConnectBlock debug logging code paths b49df703f0 [validation] include all logged information in BlockValidationState 7b267c034f [validation] Add detailed txin/txout information for script error messages 146a3d5426 [validation] Make script error messages uniform for parallel/single validation 1ac1c33f3f [checkqueue] support user-defined return type through std::optional ebe4cac38b Merge bitcoin/bitcoin#30991: test: enable running independent functional test sub-tests 1927674100 Merge bitcoin/bitcoin#31387: doc: Use more precise anchor link to codesigning docs e043618d44 Merge bitcoin/bitcoin#31396: test: simple reordering to reduce run time a25b892ab1 Merge bitcoin/bitcoin#31386: doc: Use more precise anchor links to Xcode SDK extraction eb646111cd Merge bitcoin/bitcoin#31383: test: Add missing node.setmocktime(self.mocktime) to p2p_ibd_stalling.py 6cd95de2e0 Merge bitcoin/bitcoin#31395: build: Set shared linker flags in toolchain file abeebccc48 Merge bitcoin/bitcoin#31357: cmake: Improve build script correctness 4c9b13841c Merge bitcoin/bitcoin#31402: doc: correct libfuzzer-nosan preset flag da4f4fac8d Merge bitcoin/bitcoin#31361: cmake, qt: Use absolute paths for includes in MOC-generated files 16b140f225 doc: correct libfuzzer-nosan preset flag 097c66f614 Merge bitcoin/bitcoin#30039: dbwrapper: Bump LevelDB max file size to 32 MiB to avoid system slowdown from high disk cache flush rate 68daaea0e4 Merge bitcoin/bitcoin#31390: Remove `src/config` directory 14f162dc5c Merge bitcoin/bitcoin#31399: ci, macos: Install `pkgconf` Homebrew's package e2f2698395 ci, macos: Install `pkgconf` Homebrew's package b73d331937 dbwrapper: Bump max file size to 32 MiB 62f6d9e1a4 test: simple ordering optimization to reduce runtime a8e04704f9 build: Set shared linker flags in toolchain file dbc8ba12f3 Merge bitcoin/bitcoin#31371: doc, test: more ephemeral dust follow-ups 935973b315 Remove `src/config` directory 19f49c7489 doc: Use more precise anchor link to codesigning docs 8bf1b3039c doc: Use more precise anchor links to Xcode SDK extraction 7590e93bc7 Merge bitcoin/bitcoin#30986: contrib: skip missing binaries in gen-manpages b2af068825 Merge bitcoin/bitcoin#30708: rpc: add getdescriptoractivity 144f98db85 Merge bitcoin/bitcoin#31337: build: Fix coverage builds faa16ed4b9 test: Add missing node.setmocktime(self.mocktime) to p2p_ibd_stalling.py efdb49afb9 Merge bitcoin/bitcoin#31323: guix: swap `moreutils` for just `sponge` 37a5c5d836 doc: update descriptors.md for getdescriptoractivity ee3ce6a4f4 test: rpc: add no address case for getdescriptoractivity 811f76f3a5 rpc: add getdescriptoractivity ee6185372f gen-manpages: Prompt error if no binaries are found 70e20ea024 Merge bitcoin/bitcoin#31172: build: increase minimum supported Windows to 10.0 733317ba94 Merge bitcoin/bitcoin#31364: refactor: Fix remaining clang-tidy performance-unnecessary-copy-initialization errors 5a4bc5c036 Merge bitcoin/bitcoin#31305: refactor: Fix remaining clang-tidy performance-inefficient-vector errors 28fd0bc731 Merge bitcoin/bitcoin#31365: interpreter: Use the same type for SignatureHash in the definition 72ab35a6d0 Merge bitcoin/bitcoin#31221: ci: Split out native fuzz jobs for macOS and windows (take 2) 160799d913 test: refactor: introduce `create_ephemeral_dust_package` helper 61e18dec30 doc: ephemeral policy: add missing closing double quote 32fc59796f rpc: Allow single transaction through submitpackage 3305972f7b refactor: Fix remaining clang-tidy performance-unnecessary-copy-initialization errors 11f3bc229c refactor: Reserve vectors in fuzz tests 152fefe7a2 refactor: Preallocate PrevectorFillVector(In)Direct without vector resize a774c7a339 refactor: Fix remaining clang-tidy performance-inefficient-vector errors f7144b24be Merge bitcoin/bitcoin#31279: policy: ephemeral dust followups c288c790cd interpreter: Use the same type for SignatureHash in the definition b031b7910d [ci] Split out native fuzz jobs for macOS and windows 6f4128e3a8 cmake, qt: Use absolute paths for includes in MOC-generated files ab5c63edcc cmake: Build `secp256k1` only when required 76a3a540a4 cmake: Ensure script correctness when no targets are specified e8f50c5deb guix: swap moreutils for just sponge 01a7298818 build: Avoid using the `-ffile-prefix-map` compiler option 2638fdb4f9 Merge bitcoin/bitcoin#31338: test: Deduplicate assert_mempool_contents() 73db95c65c kernel: Make bitcoin-chainstate's block validation mirror submitblock's bb53ce9bda tests: Add functional test for submitting a previously pruned block 1f7fc73825 rpc: Remove submitblock duplicate pre-check e62a8abd7d rpc: Remove submitblock invalid-duplicate precheck 36dbebafb9 rpc: Remove submitblock coinbase pre-check 17834bd197 Merge bitcoin/bitcoin#31333: fuzz: Implement G_TEST_GET_FULL_NAME cf57722788 Merge bitcoin/bitcoin#31335: macOS: swap docs & CI from pkg-config to pkgconf fe3457ccff ci: note that we should install pkgconf in future a0eafc10f9 functional test: Deduplicate assert_mempool_contents() 8d203480b3 doc: migrate from pkg-config to pkgconf in macOS build docs 466e4df3fb assert_mempool_contents: assert not duplicates expected ea5db2f269 functional: only generate required blocks for test d033acb608 fuzz: package_eval: let fuzzer run out input in main tx creation loop ba35a570c5 CheckEphemeralSpends: return boolean, and set child state and txid outparams cf0cee1617 func: add note about lack of 1P1C propagation in tree submitpackage 8424290304 unit test: ephemeral_tests is using a dust relay rate, not minrelay d9cfa5fc4e CheckEphemeralSpends: no need to iterate inputs if no parent dust 87b26e3dc0 func: rename test_free_relay to test_no_minrelay_fee e5709a4a41 func: slight elaboration on submitpackage restriction 08e969bd10 RPC: only enforce dust rules on priority when standardness active ca050d12e7 unit test: adapt to changing MAX_DUST_OUTPUTS_PER_TX 7c3490169c fuzz: package_eval: move last_tx inside txn ctor 445eaed182 fuzz: use optional status instead of should_rbf_eph_spend 4dfdf615b9 fuzz: remove unused TransactionsDelta validation interface 09ce926e4a func: cleanup reorg test comment 768a0c1889 func: cleanup test_dustrelay comments bedca1cb66 fuzz: Directly place transactions in vector c041ad6ecc fuzz: explain package eval coin tracking better bc0d98ea61 fuzz: remove dangling reference to GetEntry 15b6cbf07f unit test: make dust index less magical 5fbcfd12b8 unit test: assert txid returned on CheckEphemeralSpends failures ef94d84b4e bench: remove unnecessary CMTxn constructors c5c10fd317 ephemeral policy doxygen cleanup dd9044b8d4 ephemeral policy: IWYU c6859ce2de Move+rename GetDustIndexes -> GetDust 22ef95dbe3 Merge bitcoin/bitcoin#31288: Add destroy to BlockTemplate schema 92d3d691f0 fuzz: Implement G_TEST_GET_FULL_NAME f34fe0806a Merge bitcoin/bitcoin#31122: cluster mempool: Implement changeset interface for mempool b2d952c0f5 Merge bitcoin/bitcoin#31331: doc: add copyright header to p2p_headers_presync 7d3703dec3 doc: add copyright header to p2p_headers_presync 116b8c5573 Merge bitcoin/bitcoin#31213: fuzz: Fix difficulty target generation in `p2p_headers_presync` 15c1f47a00 Merge bitcoin/bitcoin#31327: doc: Correct PR Review Club frequency from weekly to monthly 1209a1082c Merge bitcoin/bitcoin#31315: build: Enable -Wbidi-chars=any ab22726def Merge bitcoin/bitcoin#31276: guix: scope pkg-config to Linux only 637f437a16 doc: remove PR Review Club frequency e122309958 Merge bitcoin/bitcoin#31317: test: Revert to random path element 2666d83da5 Merge bitcoin/bitcoin#30893: test: Introduce ensure_for helper faaaf59f71 test: Make g_rng_temp_path rand, not dependent on SeedRandomForTest 746f93b4f0 Merge bitcoin/bitcoin#31307: build: Temporarily disable compiling `fuzz/utxo_snapshot.cpp` with MSVC 25fe087de5 rpc: move-only: move ScriptPubKeyDoc to utils fa80b08fef test: Revert to random path element 8f85d36d68 refactor: Clamp worker threads in ChainstateManager constructor fa7857ccda build: Enable -Wbidi-chars=any b2d5361002 build: Temporarily disable compiling `fuzz/utxo_snapshot.cpp` with MSVC 9aa50152c1 Add destroy to BlockTemplate schema ccc2d3abcd Merge bitcoin/bitcoin#31287: refactor: Avoid std::string format strings 62016b3230 Use std::ranges for ephemeral policy checks 3ed930a1f4 Have HasDust and PreCheckValidEphemeralTx take CTransaction 04a614bf9a Rename CheckValidEphemeralTx to PreCheckEphemeralTx 85bcfeea23 Merge bitcoin/bitcoin#30666: validation: fix m_best_header tracking and BLOCK_FAILED_CHILD assignment 2257c6d68f Merge bitcoin/bitcoin#30487: ci: skip Github CI on branch pushes for forks 380e1f44e8 Merge bitcoin/bitcoin#30349: benchmark: Improve SipHash_32b accuracy to avoid potential optimization issues 1a8f51e745 Merge bitcoin/bitcoin#28843: [refactor] Cleanup BlockAssembler mempool usage 2d944e982c Merge bitcoin/bitcoin#31285: guix: remove `util-linux` bcd82b13f4 Remove pkgconfig from toolchain file 319a4e8261 depends: drop sqlite pkgconfig file fa1177e3d7 refactor: Avoid std::string format strings a8fe1fd38b depends: better cleanup after fontconfig 17e79c9260 depends: fully remove libtool archives from Qt build 8ca85651c8 guix: move pkg-config to Linux builds e3e648cf41 depends: drop pkg-config option from Qt build 0d185bd99f doc: update depends doc to prefer .cmake outputs e546b4e1a0 Merge bitcoin/bitcoin#31225: doc: Fix grammatical errors in multisig-tutorial.md f44e39c9d0 Merge bitcoin/bitcoin#31174: tinyformat: Add compile-time checking for literal format strings 299e2220e9 gen-manpages: implement --skip-missing-binaries 5736d1ddac tracing: pass if replaced by tx/pkg to tracepoint a4ec07f194 doc: add comments for CTxMemPool::ChangeSet 83f814b1d1 Remove m_all_conflicts from SubPackageState d3c8e7dfb6 Ensure that we don't add duplicate transactions in rbf fuzz tests d7dc9fd2f7 Move CalculateChunksForRBF() to the mempool changeset 284a1d33f1 Move prioritisation into changeset 446b08b599 Don't distinguish between direct conflicts and all conflicts when doing cluster-size-2-rbf checks b53041021a Duplicate transactions are not permitted within a changeset b447416fdd Public mempool removal methods Assume() no changeset is outstanding 2b30f4d36c Make RemoveStaged() private 18829194ca Enforce that there is only one changeset at a time 7fb62f7db6 Apply mempool changeset transactions directly into the mempool 34b6c5833d Clean up FinalizeSubpackage to avoid workspace-specific information 57983b8add Move LimitMempoolSize to take place outside FinalizeSubpackage 01e145b975 Move changeset from workspace to subpackage 802214c083 Introduce mempool changesets 87d92fa340 test: Add unit test coverage of package rbf + prioritisetransaction 15d982f91e Add package hash to package-rbf log message fa5e706459 ci: Skip broken Wine64 tests by default 4d66854982 ci: remove util-linux from centos CI cdf34be7c9 guix: remove util-linux cbf1a47d60 CheckEphemeralSpends: only compute txid of tx when needed 111465d72d test: Remove unused attempts parameter from wait_until 5468a23eb9 test: Add check_interval parameter to wait_until 16c87d91fd test: Introduce ensure_for helper a6ca8f3243 fuzz: Fix difficulty target generation in p2p_headers_presync 8610bcef9d ci: skip Github CI on branch pushes for forks 409d0d6293 test: enable running individual independent functional test methods ee1128ead8 doc: update stack-clash-protection comment re mingw-w64 bf47448f15 test: drop check for Windows < 10 35b898c47f release: target Windows 10 or later 398754e70b depends: target Windows 10 when building for mingw-w64 ac286e0d1b doc: Fix grammatical errors in multisig-tutorial.md fa327c77e3 util: Add ConsumeArithUInt256InRange fuzzing helper 42066f45ff Refactor SipHash_32b benchmark to improve accuracy and avoid optimization issues fe39acf88f tinyformat: Add compile-time checking for literal format strings 184f34f2d0 util: Support dynamic width & precision in ConstevalFormatString 192dac1d33 [refactor] Cleanup BlockAssembler mempool usage 0bd53d913c test: add test for getchaintips behavior with invalid chains ccd98ea4c8 test: cleanup rpc_getchaintips.py f5149ddb9b validation: mark blocks building on an invalid block as BLOCK_FAILED_CHILD 783cb7337f validation: call RecalculateBestHeader in InvalidChainFound 9275e9689a rpc: call RecalculateBestHeader as part of reconsiderblock a51e91783a validation: add RecalculateBestHeader() function REVERT: 35f8503285 kernel: Add pure kernel bitcoin-chainstate REVERT: 84eb1f952c kernel: Add functions to get the block hash from a block REVERT: 575cb5a033 kernel: Add block index utility functions to C header REVERT: 4c433defd3 kernel: Add function to read block undo data from disk to C header REVERT: 83e48e021b kernel: Add functions to read block from disk to C header REVERT: a4381c560f kernel: Add function for copying block data to C header REVERT: d3e84ac5a6 kernel: Add functions for the block validation state to C header REVERT: deb5b4a5f5 kernel: Add validation interface to C header REVERT: f4ea5f49c6 kernel: Add interrupt function to C header REVERT: 5f4b436aad kernel: Add import blocks function to C header REVERT: c95a28fd80 kernel: Add chainstate load options for in-memory dbs in C header REVERT: d6360557ef kernel: Add options for reindexing in C header REVERT: a125867b9f kernel: Add block validation to C header REVERT: b2b75a0ef7 Kernel: Add chainstate loading to kernel C header REVERT: d233003ff2 kernel: Add chainstate manager option for setting worker threads REVERT: 3610be3b13 kernel: Add chainstate manager object to C header REVERT: c194bea41f kernel: Add notifications context option to C header REVERT: 691d89d846 kerenl: Add chain params context option to C header REVERT: 407ca750cd kernel: Add kernel library context object REVERT: ee3c4ea92c kernel: Add logging to kernel library C header REVERT: e6c610a7e0 kernel: Introduce initial kernel C header API git-subtree-dir: depend/bitcoin git-subtree-split: 20eec64b5e417cac8c68100826c0adf2152a49eb

DrahtBot added the RPC/REST/ZMQ label Oct 29, 2024

mzumsande reviewed Oct 29, 2024

View reviewed changes

DrahtBot mentioned this pull request Nov 1, 2024

Prune mining interface #31196

Merged

mzumsande reviewed Nov 6, 2024

View reviewed changes

TheCharlatan force-pushed the submitblock_prechecks branch from e742d66 to b83d509 Compare November 7, 2024 21:12

mzumsande reviewed Nov 7, 2024

View reviewed changes

test/functional/mining_basic.py Outdated Show resolved Hide resolved

TheCharlatan force-pushed the submitblock_prechecks branch from b83d509 to a712447 Compare November 7, 2024 22:33

DrahtBot added the CI failed label Nov 7, 2024

TheCharlatan force-pushed the submitblock_prechecks branch from a712447 to 309bd56 Compare November 8, 2024 09:28

DrahtBot removed the CI failed label Nov 8, 2024

mzumsande reviewed Nov 18, 2024

View reviewed changes

TheCharlatan force-pushed the submitblock_prechecks branch from 309bd56 to 563278b Compare November 21, 2024 12:27

Sjors reviewed Nov 21, 2024

View reviewed changes

test/functional/mining_basic.py Outdated Show resolved Hide resolved

Sjors approved these changes Nov 21, 2024

View reviewed changes

doc/release-notes-31175.md Outdated Show resolved Hide resolved

DrahtBot requested a review from mzumsande November 21, 2024 16:32

TheCharlatan and others added 5 commits November 21, 2024 22:16

tests: Add functional test for submitting a previously pruned block

bb53ce9

This tests the new submitblock behaviour that is introduced in the previous commit: Submitting a previously pruned block should persist the block's data again.

kernel: Make bitcoin-chainstate's block validation mirror submitblock's

73db95c

The behaviour of submitblock was changed in the previous commit, so change it here too.

TheCharlatan force-pushed the submitblock_prechecks branch from 563278b to 73db95c Compare November 21, 2024 21:23

instagibbs approved these changes Nov 22, 2024

View reviewed changes

DrahtBot mentioned this pull request Nov 25, 2024

kernel, refactor: Replace goto with RAII in bitcoin-chainstate #31362

Closed

mzumsande reviewed Nov 27, 2024

View reviewed changes

DrahtBot mentioned this pull request Dec 2, 2024

mining: bugfix: Fix duplicate coinbase tx weight reservation #31384

Merged

achow101 merged commit 6f24662 into bitcoin:master Dec 3, 2024
16 checks passed

TheCharlatan mentioned this pull request Dec 4, 2024

kernel: Introduce initial C header API #30595

Open

rpc: Remove submitblock pre-checks #31175

rpc: Remove submitblock pre-checks #31175

Uh oh!

Conversation

TheCharlatan commented Oct 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DrahtBot commented Oct 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage & Benchmarks

Reviews

Conflicts

Uh oh!

mzumsande left a comment

Choose a reason for hiding this comment

Uh oh!

TheCharlatan commented Oct 31, 2024

Uh oh!

instagibbs commented Nov 1, 2024

Uh oh!

mzumsande left a comment

Choose a reason for hiding this comment

Uh oh!

TheCharlatan commented Nov 7, 2024

Uh oh!

Uh oh!

TheCharlatan commented Nov 8, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mzumsande Nov 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Sjors Nov 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TheCharlatan commented Nov 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Sjors commented Nov 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Sjors commented Nov 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Sjors left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

instagibbs commented Nov 21, 2024

Uh oh!

TheCharlatan commented Nov 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Sjors commented Nov 22, 2024

Uh oh!

instagibbs left a comment

Choose a reason for hiding this comment

Uh oh!

mzumsande left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

TheCharlatan commented Oct 29, 2024 •

edited

Loading

DrahtBot commented Oct 29, 2024 •

edited

Loading

mzumsande Nov 20, 2024 •

edited

Loading

Sjors Nov 21, 2024 •

edited

Loading

TheCharlatan commented Nov 21, 2024 •

edited

Loading

Sjors commented Nov 21, 2024 •

edited

Loading

Sjors commented Nov 21, 2024 •

edited

Loading

TheCharlatan commented Nov 21, 2024 •

edited

Loading