guix: Drop unused autotools packages #30752
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
|
What's the reason for separating this from #30664? |
|
|
Yes, I saw, but why not include it in the removal PR - do we expect it to take long time to merge? |
We need to address hebasto#341 first. |
|
My Guix build: |
fanquake
approved these changes
Aug 29, 2024
There was a problem hiding this comment.
ACK 8b355c0
Guix Build (aarch64)
162558bde37d72fe208df3475706774347ca4558daca61f2eccf230f144ecbe6 guix-build-8b355c0bb212/output/aarch64-linux-gnu/SHA256SUMS.part
fe01ee54a0d19ecdee4001d13600332b6304e97a49e62633cf13904add205250 guix-build-8b355c0bb212/output/aarch64-linux-gnu/bitcoin-8b355c0bb212-aarch64-linux-gnu-debug.tar.gz
21303b65ffe66f5521b1e049fb296c27761333add36149e92984fc5a456421fa guix-build-8b355c0bb212/output/aarch64-linux-gnu/bitcoin-8b355c0bb212-aarch64-linux-gnu.tar.gz
97cc03384e1c90c97294205ce013086b1ffc750f4b065775e3d595c8f235b054 guix-build-8b355c0bb212/output/arm-linux-gnueabihf/SHA256SUMS.part
acee06367c912ee2dfc5339a8c61d8093b461a72e922b3db78c89ff315034322 guix-build-8b355c0bb212/output/arm-linux-gnueabihf/bitcoin-8b355c0bb212-arm-linux-gnueabihf-debug.tar.gz
d250b129e8d1abd97ee1167982c41bda3382e8f38ecd9349331ccfb8d6827d96 guix-build-8b355c0bb212/output/arm-linux-gnueabihf/bitcoin-8b355c0bb212-arm-linux-gnueabihf.tar.gz
f1030398774d5daf5bade613271ff1f029127ea796a1d86a3f9b23086976f77b guix-build-8b355c0bb212/output/arm64-apple-darwin/SHA256SUMS.part
de7906780eefee0dd7eb6a40d140792a95c138265043d84501781d6fb46a301a guix-build-8b355c0bb212/output/arm64-apple-darwin/bitcoin-8b355c0bb212-arm64-apple-darwin-unsigned.tar.gz
f3e9f7bca95611bc9043aac81cec2db285f43459172ee8318de9c457c542a370 guix-build-8b355c0bb212/output/arm64-apple-darwin/bitcoin-8b355c0bb212-arm64-apple-darwin-unsigned.zip
545e179a5f93d45c94d296b35a06ed41c176d3d00d926eab03d64a5a27e57957 guix-build-8b355c0bb212/output/arm64-apple-darwin/bitcoin-8b355c0bb212-arm64-apple-darwin.tar.gz
6a3c9a7916f7cdd42ec40a124c611c25858b2377b82b7140248572221442f39f guix-build-8b355c0bb212/output/dist-archive/bitcoin-8b355c0bb212.tar.gz
7d694d18050a96aa9bdbe5214ff559b18fa0a472d927f8e520055ccef64f31d0 guix-build-8b355c0bb212/output/powerpc64-linux-gnu/SHA256SUMS.part
5f5724e99f4da966626be6d62aa7d2b399a7dc57fbda646434073a93dce94d54 guix-build-8b355c0bb212/output/powerpc64-linux-gnu/bitcoin-8b355c0bb212-powerpc64-linux-gnu-debug.tar.gz
1653e58aea479ff820aa7cfabfe729377f555b539602505c06fc9b50004ece5e guix-build-8b355c0bb212/output/powerpc64-linux-gnu/bitcoin-8b355c0bb212-powerpc64-linux-gnu.tar.gz
436b008d782d1c7453082966696ff162c17e7d0924af31d4f2bb718974e5b276 guix-build-8b355c0bb212/output/riscv64-linux-gnu/SHA256SUMS.part
bb07f0b5d3c9765935d6a77772c499dcaee2ed6f38af7d3dc80ae238ea175c4f guix-build-8b355c0bb212/output/riscv64-linux-gnu/bitcoin-8b355c0bb212-riscv64-linux-gnu-debug.tar.gz
9228f20136ebe9292936fa151c25b04cf10af7a7ead3cd65a9b09a75636201a7 guix-build-8b355c0bb212/output/riscv64-linux-gnu/bitcoin-8b355c0bb212-riscv64-linux-gnu.tar.gz
d9e38f2a06e885032b6138205d42e39606ebb5b99ba30e94122264c723152d28 guix-build-8b355c0bb212/output/x86_64-apple-darwin/SHA256SUMS.part
651acd1d68f3d6b64cea39b288131dc3f965ccdc90e686a98eb7ef3b44e2e211 guix-build-8b355c0bb212/output/x86_64-apple-darwin/bitcoin-8b355c0bb212-x86_64-apple-darwin-unsigned.tar.gz
ef4ccc9ca7f0088537e54bbc77ae250e203b582f75dfca65c3aa4c380fe3362f guix-build-8b355c0bb212/output/x86_64-apple-darwin/bitcoin-8b355c0bb212-x86_64-apple-darwin-unsigned.zip
fae467ae55385d7643f37051433e5df41ab5b3585e038b981e074ef1f005f35d guix-build-8b355c0bb212/output/x86_64-apple-darwin/bitcoin-8b355c0bb212-x86_64-apple-darwin.tar.gz
a0e375e56801d037490afa1fe0027ab459b2bccf325d8f6258153ef5949a9ced guix-build-8b355c0bb212/output/x86_64-linux-gnu/SHA256SUMS.part
c4db06dea76707ebbc7503b08094a718785bf0ea5eea0d25d558d910ac67e941 guix-build-8b355c0bb212/output/x86_64-linux-gnu/bitcoin-8b355c0bb212-x86_64-linux-gnu-debug.tar.gz
988d8140fef1f0fcdeeea8fb2ccb171b0154ecf4cccf827fdd3614d0a8c7aba1 guix-build-8b355c0bb212/output/x86_64-linux-gnu/bitcoin-8b355c0bb212-x86_64-linux-gnu.tar.gz
621d35b760ce2ce517c30a75ba6eee95e966d70bdc271e659f39c4531fde5cb2 guix-build-8b355c0bb212/output/x86_64-w64-mingw32/SHA256SUMS.part
42883d8b6527e697103eca9c97482ba8f448a8bb949ecfe8b717e832e289daeb guix-build-8b355c0bb212/output/x86_64-w64-mingw32/bitcoin-8b355c0bb212-win64-debug.zip
e6dfb81cdf910bf77c7642c290abcb748aa7183f290102fd9f5d5d20818f5752 guix-build-8b355c0bb212/output/x86_64-w64-mingw32/bitcoin-8b355c0bb212-win64-setup-unsigned.exe
64cad0e4275b95456c8a681c157ab85fac2d42fad63120a77ecbfc1bd9ef29d7 guix-build-8b355c0bb212/output/x86_64-w64-mingw32/bitcoin-8b355c0bb212-win64-unsigned.tar.gz
c8affd59df0d3823a35adf39591826de00062bb8d52d9c3e90b182a0a6a7038d guix-build-8b355c0bb212/output/x86_64-w64-mingw32/bitcoin-8b355c0bb212-win64.zip|
These Guix builds don't match. |
|
Can you rebase this on master. |
8b355c0 to
0004dcc
Compare
Rebased. |
fanquake
approved these changes
Aug 30, 2024
There was a problem hiding this comment.
ACK 0004dcc
I've done complete rebuilds and they look deterministic:
8ed754df1e92d8ffc60cd407f009f6e352eacb5413f9c094feee6991775acff0 guix-build-0004dcc7b136/output/aarch64-linux-gnu/SHA256SUMS.part
780089965418bdb5fbc37813746f7bf81b16cff7424f0aebe0aeee903a77d0a2 guix-build-0004dcc7b136/output/aarch64-linux-gnu/bitcoin-0004dcc7b136-aarch64-linux-gnu-debug.tar.gz
a5b702a92b8be730836e0b78b58ffdfa83f623087950d2d0396025945e2df5cf guix-build-0004dcc7b136/output/aarch64-linux-gnu/bitcoin-0004dcc7b136-aarch64-linux-gnu.tar.gz
3dd8ac9ecdcc9ac58f50f9fc2fe62a1b84264841566b157c8fdf9b0140b05a27 guix-build-0004dcc7b136/output/arm-linux-gnueabihf/SHA256SUMS.part
db6b7a207f8c3f69b2fda2cf58521de3c4f3f371c7ed87a52fad9b4aa2ff8211 guix-build-0004dcc7b136/output/arm-linux-gnueabihf/bitcoin-0004dcc7b136-arm-linux-gnueabihf-debug.tar.gz
65b7a838e1368006232a424a8c811380a46da2fc650b9059f3423a30f36fee8f guix-build-0004dcc7b136/output/arm-linux-gnueabihf/bitcoin-0004dcc7b136-arm-linux-gnueabihf.tar.gz
718ad3e3526aeb984ca0f01167ea3aa190daa312f134485038fe78453ef16a1d guix-build-0004dcc7b136/output/arm64-apple-darwin/SHA256SUMS.part
6d3b5ef7a04ff98d6e149cbd5adaf40ff8f4ec2afdf52a653414c6a68abb2597 guix-build-0004dcc7b136/output/arm64-apple-darwin/bitcoin-0004dcc7b136-arm64-apple-darwin-unsigned.tar.gz
27b5f4f62107e22499ce3201ea017804cb4f16f6e45c0ad6ff7b04c6aacbfba6 guix-build-0004dcc7b136/output/arm64-apple-darwin/bitcoin-0004dcc7b136-arm64-apple-darwin-unsigned.zip
40a68f09c5bc8d70714038ca21c93eee9836f0d212871b8037ac165b70dd4f62 guix-build-0004dcc7b136/output/arm64-apple-darwin/bitcoin-0004dcc7b136-arm64-apple-darwin.tar.gz
ce9788fda9dc8e6d929a85e982c145adc6c4c169fd13848dfa6558fe9ac8cf18 guix-build-0004dcc7b136/output/dist-archive/bitcoin-0004dcc7b136.tar.gz
b47ffc03c23b3c24f2c736f68c099e7cc7b7aecd36311cc79f5eeb92f62c8b81 guix-build-0004dcc7b136/output/powerpc64-linux-gnu/SHA256SUMS.part
d55667dcdb05665a10fc3e114cf073a163f029f93a806e317d09bf1071e0a8c2 guix-build-0004dcc7b136/output/powerpc64-linux-gnu/bitcoin-0004dcc7b136-powerpc64-linux-gnu-debug.tar.gz
faf57cd1b7150883c4162f905b564799846ca47d6658a652130fa1e579361395 guix-build-0004dcc7b136/output/powerpc64-linux-gnu/bitcoin-0004dcc7b136-powerpc64-linux-gnu.tar.gz
eee73be101aee8843c1316ca6f738ecc8238bda9ac8d90c879a710760c2d5256 guix-build-0004dcc7b136/output/riscv64-linux-gnu/SHA256SUMS.part
07afc1dd58df0d0e5de3f6017a1ec608d1f698bbb36066175b2c7f761adac072 guix-build-0004dcc7b136/output/riscv64-linux-gnu/bitcoin-0004dcc7b136-riscv64-linux-gnu-debug.tar.gz
8c48bfb2ad4484cef33eeb526e9aaa21b60d4f3a43edb134c58af95e9dde491b guix-build-0004dcc7b136/output/riscv64-linux-gnu/bitcoin-0004dcc7b136-riscv64-linux-gnu.tar.gz
7ad09d443be29665ac3c315d6bf384fc94612375c5faa0fef737fa08e02b76d8 guix-build-0004dcc7b136/output/x86_64-apple-darwin/SHA256SUMS.part
9a1c0fbdf2d2ddbefb0aad7f2d1e9598cfce85535943f8d7c6f6caa0d2369db7 guix-build-0004dcc7b136/output/x86_64-apple-darwin/bitcoin-0004dcc7b136-x86_64-apple-darwin-unsigned.tar.gz
4023894c7b5d3fa37a270e1d5cc856ea6bba4148ffc7bcd72ce7a13bcdf0a52c guix-build-0004dcc7b136/output/x86_64-apple-darwin/bitcoin-0004dcc7b136-x86_64-apple-darwin-unsigned.zip
27d6e677d507b87c560769681233690ea13eb3f1de825896b26ca21d1cca8c31 guix-build-0004dcc7b136/output/x86_64-apple-darwin/bitcoin-0004dcc7b136-x86_64-apple-darwin.tar.gz
75c3a91bcf6b23137ea7c2591989174476921fd721b2f39af7691211fc61ff32 guix-build-0004dcc7b136/output/x86_64-linux-gnu/SHA256SUMS.part
ee4b13a7a61e53b650a4ecffedcdf089b6910f87c23d2358b0829c2877e23fc9 guix-build-0004dcc7b136/output/x86_64-linux-gnu/bitcoin-0004dcc7b136-x86_64-linux-gnu-debug.tar.gz
3e7bde371516e6f3088b950f14c1fdcdf63138e5a66d1f23297d2bd0befe01d6 guix-build-0004dcc7b136/output/x86_64-linux-gnu/bitcoin-0004dcc7b136-x86_64-linux-gnu.tar.gz
7ce87abc29f0214765ce367b24dec25f17fc2bedf87e05f9e46fa802accdbdf2 guix-build-0004dcc7b136/output/x86_64-w64-mingw32/SHA256SUMS.part
436873c4b7254b4a9c715659b6b1122de6345da2a80f3edbf4e176d3f28bc4ef guix-build-0004dcc7b136/output/x86_64-w64-mingw32/bitcoin-0004dcc7b136-win64-debug.zip
18e2f244fc2bb48450a933b147ae69045cb5a142310e10f03a67bc0754f9511c guix-build-0004dcc7b136/output/x86_64-w64-mingw32/bitcoin-0004dcc7b136-win64-setup-unsigned.exe
3d509f7d68a1d0e2ddc1370ca90fa94cb392d1ac3e40faafc16063fd128067f8 guix-build-0004dcc7b136/output/x86_64-w64-mingw32/bitcoin-0004dcc7b136-win64-unsigned.tar.gz
6dfc539d2898a53cec88f2ddacc1d08d65e70722fb780fd32a6bc188dad71ee0 guix-build-0004dcc7b136/output/x86_64-w64-mingw32/bitcoin-0004dcc7b136-win64.zip
maflcko
reviewed
Sep 13, 2024
| @@ -511,9 +510,6 @@ inspecting signatures in Mach-O binaries.") | |||
| gcc-toolchain-12 | |||
| cmake-minimal | |||
| gnu-make | |||
| libtool | |||
There was a problem hiding this comment.
If libtool is fine to drop here in guix, which uses depends, why is it not dropped from the depends docs as well, and the CI tasks?
depends/README.md: apt install automake bison cmake curl libtool make patch pkg-config python3 xz-utils
depends/packages.md:In general, the output of a depends package should not contain any libtool
.github/workflows/ci.yml: brew install --quiet automake libtool pkg-config gnu-getopt ccache boost libevent miniupnpc libnatpmp zeromq qt@5 qrencode
ci/test/00_setup_env.sh:export CI_BASE_PACKAGES=${CI_BASE_PACKAGES:-build-essential libtool autotools-dev automake pkg-config curl ca-certificates ccache python3 rsync git procps bison e2fsprogs cmake}
ci/test/00_setup_env_i686_centos.sh:export CI_BASE_PACKAGES="gcc-c++ glibc-devel.x86_64 libstdc++-devel.x86_64 glibc-devel.i686 libstdc++-devel.i686 ccache libtool make git python3 python3-pip which patch lbzip2 xz procps-ng dash rsync coreutils bison util-linux e2fsprogs cmake"
contrib/devtools/check-deps.sh:# Output makefile targets, converting library .a paths to libtool .la targets
There was a problem hiding this comment.
Thanks! Addressed in #30902.
fanquake
added a commit
that referenced
this pull request
Sep 17, 2024
7a8a6a0 doc: Fix comment in `contrib/devtools/check-deps.sh` script (Hennadii Stepanov) 712d105 depends, doc: Do not install Autotools packages (Hennadii Stepanov) b786449 ci: Do not install Autotools packages (Hennadii Stepanov) Pull request description: This PR is a follow-up to #30752 and addresses #30752 (comment). ACKs for top commit: kevkevinpal: ACK [7a8a6a0](7a8a6a0) Tree-SHA512: ac701b34ebf1621be355a5b576032d30a342a5667eff47d858587ac3c60011d77bd469e524d69dae90a932f14269227886e3d170a63a2e855b29ef4fa5b9e5a4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements hebasto#294.
From hebasto#294 (comment):