Skip to content

Conversation

fanquake
Copy link
Member

@fanquake fanquake requested a review from TheCharlatan August 28, 2024 10:55
@DrahtBot
Copy link
Contributor

DrahtBot commented Aug 28, 2024

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK hebasto, TheCharlatan

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #29881 (guix: use GCC 13 to builds releases by fanquake)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

Copy link
Contributor

@TheCharlatan TheCharlatan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guix build (aarch64):

b3506f1628995572aa544429361195e436306a3ad8104db04796889d12d66193  guix-build-60d4398a345c/output/aarch64-linux-gnu/SHA256SUMS.part
60a8c2afdb972ae23d4e2c4a9135a88a983476ea8366c0b07020e0574405399e  guix-build-60d4398a345c/output/aarch64-linux-gnu/bitcoin-60d4398a345c-aarch64-linux-gnu-debug.tar.gz
8e50f840a94b3db48cf7fcfac7a94e06656ae11ac6a70cc23600b5e7a19b0c35  guix-build-60d4398a345c/output/aarch64-linux-gnu/bitcoin-60d4398a345c-aarch64-linux-gnu.tar.gz
55e93e0f363599ec554b3834b94fa0b194b1c14dd6103af8a250d9cfdfae6b2c  guix-build-60d4398a345c/output/arm-linux-gnueabihf/SHA256SUMS.part
f4432f85692e74a42c81517c0b4464910b4b950aa5cccf940593e8a331bab4f7  guix-build-60d4398a345c/output/arm-linux-gnueabihf/bitcoin-60d4398a345c-arm-linux-gnueabihf-debug.tar.gz
69d55117430f6c957b1ca1538d572786bed07a38d90f177f7328b44575a9180c  guix-build-60d4398a345c/output/arm-linux-gnueabihf/bitcoin-60d4398a345c-arm-linux-gnueabihf.tar.gz
1115f41a965275086d4cfbbf321575681eb47efa8ac08ef94c5278e6b3a652c7  guix-build-60d4398a345c/output/arm64-apple-darwin/SHA256SUMS.part
8cf4622eab3c63822b6b452c704d16dd6588bc064d154e6abaa34a8d8f95a292  guix-build-60d4398a345c/output/arm64-apple-darwin/bitcoin-60d4398a345c-arm64-apple-darwin-unsigned.tar.gz
3d83b0a59eda399bd34a7092504d186f6acc62147e8ae067669a799a554b959d  guix-build-60d4398a345c/output/arm64-apple-darwin/bitcoin-60d4398a345c-arm64-apple-darwin-unsigned.zip
ef43dde661dce84eccdacefc7e8c6574c8a350c207cf9d6cdb2822092ed6c817  guix-build-60d4398a345c/output/arm64-apple-darwin/bitcoin-60d4398a345c-arm64-apple-darwin.tar.gz
2d6d47001bf052551048f3b0f682549dc46272a09e6945bf135bef19593c1907  guix-build-60d4398a345c/output/dist-archive/bitcoin-60d4398a345c.tar.gz
0904e29eaf1d8a318e232ebeb51ae6eb2270ae91ff6912ca322b402f8b715916  guix-build-60d4398a345c/output/powerpc64-linux-gnu/SHA256SUMS.part
241820c30f77d2aa8cdadc877b4941367c4d62efb769c33280d7540bc784e66e  guix-build-60d4398a345c/output/powerpc64-linux-gnu/bitcoin-60d4398a345c-powerpc64-linux-gnu-debug.tar.gz
c81a9f50d0b5e1632680c09f34d98f2c27228794424550adfb20ade85c82f3cc  guix-build-60d4398a345c/output/powerpc64-linux-gnu/bitcoin-60d4398a345c-powerpc64-linux-gnu.tar.gz
e32b6198b6facb1b38e19cc97403acb203329a97f5d30ddb45ab7d10f41d8056  guix-build-60d4398a345c/output/riscv64-linux-gnu/SHA256SUMS.part
c939cbc3b0bfea4ad6414074d0f2e0ea0a0059e1cf56d5698b691ba522fb93c6  guix-build-60d4398a345c/output/riscv64-linux-gnu/bitcoin-60d4398a345c-riscv64-linux-gnu-debug.tar.gz
5261c81139c666f08ebdde10696b3b55e7aa316685b66b416b16fc7422216821  guix-build-60d4398a345c/output/riscv64-linux-gnu/bitcoin-60d4398a345c-riscv64-linux-gnu.tar.gz
f28efb572b59739522a4d4c6dda60d051097642e827b0f59296a96c51994aa2b  guix-build-60d4398a345c/output/x86_64-apple-darwin/SHA256SUMS.part
a633802e5150e92e13d34e1520ca450933f580fb9c8b9353d02c2799f8421425  guix-build-60d4398a345c/output/x86_64-apple-darwin/bitcoin-60d4398a345c-x86_64-apple-darwin-unsigned.tar.gz
d583845c3e235ae6e5a78fa15c1e36e265de7fe21c15621fbd979243016b5cd0  guix-build-60d4398a345c/output/x86_64-apple-darwin/bitcoin-60d4398a345c-x86_64-apple-darwin-unsigned.zip
90606c67b5d726f4e10a17323110716094f76bec15d807023fd3efd7071aff66  guix-build-60d4398a345c/output/x86_64-apple-darwin/bitcoin-60d4398a345c-x86_64-apple-darwin.tar.gz
e36e7883a50d95ceb8a3a560f422e325d0fc9b2f02de384085fe25d86409e322  guix-build-60d4398a345c/output/x86_64-linux-gnu/SHA256SUMS.part
7b087c7db80338fcc4abeaecbf488cb759feb49392ee431d7771ee61c01ab496  guix-build-60d4398a345c/output/x86_64-linux-gnu/bitcoin-60d4398a345c-x86_64-linux-gnu-debug.tar.gz
8136fe1043834ce021f30a3dd7291c8b14791ce5c525da9a6950c9c4c6463d6f  guix-build-60d4398a345c/output/x86_64-linux-gnu/bitcoin-60d4398a345c-x86_64-linux-gnu.tar.gz
f8648827919488603bcadffaad2a5a27bffc87c5f1aa619984335f3dc4799423  guix-build-60d4398a345c/output/x86_64-w64-mingw32/SHA256SUMS.part
1f6eba875b69ca7f187af7ad34b8f0872118a642b61f35cf7ad08964625f8e04  guix-build-60d4398a345c/output/x86_64-w64-mingw32/bitcoin-60d4398a345c-win64-debug.zip
7a1e446a0b2e753690cce02ea783813b357929fea2443e401a0de1eaef65d918  guix-build-60d4398a345c/output/x86_64-w64-mingw32/bitcoin-60d4398a345c-win64-setup-unsigned.exe
617022a8e07348995c1271d19ded8ef3ab20433939c1fa549406f5876cd58b9f  guix-build-60d4398a345c/output/x86_64-w64-mingw32/bitcoin-60d4398a345c-win64-unsigned.tar.gz
307da498e6af9c5440d411bd0dad1e65ba1096b9a8913b9f873c189ea342c783  guix-build-60d4398a345c/output/x86_64-w64-mingw32/bitcoin-60d4398a345c-win64.zip

@DrahtBot
Copy link
Contributor

Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]

File commit 2eb358b
(master)
commit 6eaca24
(master and this pull)
SHA256SUMS.part e8f6ecf13fdf7355... d77ee1fe14906ba6...
*-aarch64-linux-gnu-debug.tar.gz e9c1d6379f443848... 1194ddd78109464d...
*-aarch64-linux-gnu.tar.gz c68e67f5c95dab79... 1028b289d1ad5ff2...
*-arm-linux-gnueabihf-debug.tar.gz 5b1019a15913afe2... fd61d36258d18e19...
*-arm-linux-gnueabihf.tar.gz 92223a91c8f4dae0... d5868d1a39ce254a...
*-arm64-apple-darwin-unsigned.tar.gz c21004df569f3204... 4a9edbc4771102ab...
*-arm64-apple-darwin-unsigned.zip 1d40c90e757a376c... a79c0bbf189b40af...
*-arm64-apple-darwin.tar.gz 35176f48396fa660... 16ceaeee334515fb...
*-powerpc64-linux-gnu-debug.tar.gz f2756aaf959fb5f3... daa16b79e8293171...
*-powerpc64-linux-gnu.tar.gz 6be4e7945f4cdd72... 99c6a3360d92f7d4...
*-riscv64-linux-gnu-debug.tar.gz 87f6d9e58755fc6f... da02b1578fd5d8cd...
*-riscv64-linux-gnu.tar.gz caff6e776229fc89... 2fcdf9170ed6a71c...
*-x86_64-apple-darwin-unsigned.tar.gz 3f16e1495c269ad5... 3aa0c0dd930e7c61...
*-x86_64-apple-darwin-unsigned.zip ee3e35bad157338c... 60b35631437e00fd...
*-x86_64-apple-darwin.tar.gz 102ebcb5f4385ca7... 0f804ea71a1800d7...
*-x86_64-linux-gnu-debug.tar.gz e1e0230561496988... 987fd329be76f001...
*-x86_64-linux-gnu.tar.gz eea856d372c7ba09... 4df8bcfc9f811ce5...
*.tar.gz a8774ab55c5bb782... a2fcfb329c843da2...
guix_build.log 5fb05c37c38011d5... 022a208a1f65ff92...
guix_build.log.diff 2b13dc34d031800f...

Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approach ACK 60d4398, changes look correct.

Waiting for my Guix build.

@hebasto
Copy link
Member

hebasto commented Aug 29, 2024

My Guix build:

x86_64
b3506f1628995572aa544429361195e436306a3ad8104db04796889d12d66193  guix-build-60d4398a345c/output/aarch64-linux-gnu/SHA256SUMS.part
60a8c2afdb972ae23d4e2c4a9135a88a983476ea8366c0b07020e0574405399e  guix-build-60d4398a345c/output/aarch64-linux-gnu/bitcoin-60d4398a345c-aarch64-linux-gnu-debug.tar.gz
8e50f840a94b3db48cf7fcfac7a94e06656ae11ac6a70cc23600b5e7a19b0c35  guix-build-60d4398a345c/output/aarch64-linux-gnu/bitcoin-60d4398a345c-aarch64-linux-gnu.tar.gz
55e93e0f363599ec554b3834b94fa0b194b1c14dd6103af8a250d9cfdfae6b2c  guix-build-60d4398a345c/output/arm-linux-gnueabihf/SHA256SUMS.part
f4432f85692e74a42c81517c0b4464910b4b950aa5cccf940593e8a331bab4f7  guix-build-60d4398a345c/output/arm-linux-gnueabihf/bitcoin-60d4398a345c-arm-linux-gnueabihf-debug.tar.gz
69d55117430f6c957b1ca1538d572786bed07a38d90f177f7328b44575a9180c  guix-build-60d4398a345c/output/arm-linux-gnueabihf/bitcoin-60d4398a345c-arm-linux-gnueabihf.tar.gz
1115f41a965275086d4cfbbf321575681eb47efa8ac08ef94c5278e6b3a652c7  guix-build-60d4398a345c/output/arm64-apple-darwin/SHA256SUMS.part
8cf4622eab3c63822b6b452c704d16dd6588bc064d154e6abaa34a8d8f95a292  guix-build-60d4398a345c/output/arm64-apple-darwin/bitcoin-60d4398a345c-arm64-apple-darwin-unsigned.tar.gz
3d83b0a59eda399bd34a7092504d186f6acc62147e8ae067669a799a554b959d  guix-build-60d4398a345c/output/arm64-apple-darwin/bitcoin-60d4398a345c-arm64-apple-darwin-unsigned.zip
ef43dde661dce84eccdacefc7e8c6574c8a350c207cf9d6cdb2822092ed6c817  guix-build-60d4398a345c/output/arm64-apple-darwin/bitcoin-60d4398a345c-arm64-apple-darwin.tar.gz
2d6d47001bf052551048f3b0f682549dc46272a09e6945bf135bef19593c1907  guix-build-60d4398a345c/output/dist-archive/bitcoin-60d4398a345c.tar.gz
0904e29eaf1d8a318e232ebeb51ae6eb2270ae91ff6912ca322b402f8b715916  guix-build-60d4398a345c/output/powerpc64-linux-gnu/SHA256SUMS.part
241820c30f77d2aa8cdadc877b4941367c4d62efb769c33280d7540bc784e66e  guix-build-60d4398a345c/output/powerpc64-linux-gnu/bitcoin-60d4398a345c-powerpc64-linux-gnu-debug.tar.gz
c81a9f50d0b5e1632680c09f34d98f2c27228794424550adfb20ade85c82f3cc  guix-build-60d4398a345c/output/powerpc64-linux-gnu/bitcoin-60d4398a345c-powerpc64-linux-gnu.tar.gz
e32b6198b6facb1b38e19cc97403acb203329a97f5d30ddb45ab7d10f41d8056  guix-build-60d4398a345c/output/riscv64-linux-gnu/SHA256SUMS.part
c939cbc3b0bfea4ad6414074d0f2e0ea0a0059e1cf56d5698b691ba522fb93c6  guix-build-60d4398a345c/output/riscv64-linux-gnu/bitcoin-60d4398a345c-riscv64-linux-gnu-debug.tar.gz
5261c81139c666f08ebdde10696b3b55e7aa316685b66b416b16fc7422216821  guix-build-60d4398a345c/output/riscv64-linux-gnu/bitcoin-60d4398a345c-riscv64-linux-gnu.tar.gz
f28efb572b59739522a4d4c6dda60d051097642e827b0f59296a96c51994aa2b  guix-build-60d4398a345c/output/x86_64-apple-darwin/SHA256SUMS.part
a633802e5150e92e13d34e1520ca450933f580fb9c8b9353d02c2799f8421425  guix-build-60d4398a345c/output/x86_64-apple-darwin/bitcoin-60d4398a345c-x86_64-apple-darwin-unsigned.tar.gz
d583845c3e235ae6e5a78fa15c1e36e265de7fe21c15621fbd979243016b5cd0  guix-build-60d4398a345c/output/x86_64-apple-darwin/bitcoin-60d4398a345c-x86_64-apple-darwin-unsigned.zip
90606c67b5d726f4e10a17323110716094f76bec15d807023fd3efd7071aff66  guix-build-60d4398a345c/output/x86_64-apple-darwin/bitcoin-60d4398a345c-x86_64-apple-darwin.tar.gz
e36e7883a50d95ceb8a3a560f422e325d0fc9b2f02de384085fe25d86409e322  guix-build-60d4398a345c/output/x86_64-linux-gnu/SHA256SUMS.part
7b087c7db80338fcc4abeaecbf488cb759feb49392ee431d7771ee61c01ab496  guix-build-60d4398a345c/output/x86_64-linux-gnu/bitcoin-60d4398a345c-x86_64-linux-gnu-debug.tar.gz
8136fe1043834ce021f30a3dd7291c8b14791ce5c525da9a6950c9c4c6463d6f  guix-build-60d4398a345c/output/x86_64-linux-gnu/bitcoin-60d4398a345c-x86_64-linux-gnu.tar.gz
f8648827919488603bcadffaad2a5a27bffc87c5f1aa619984335f3dc4799423  guix-build-60d4398a345c/output/x86_64-w64-mingw32/SHA256SUMS.part
1f6eba875b69ca7f187af7ad34b8f0872118a642b61f35cf7ad08964625f8e04  guix-build-60d4398a345c/output/x86_64-w64-mingw32/bitcoin-60d4398a345c-win64-debug.zip
7a1e446a0b2e753690cce02ea783813b357929fea2443e401a0de1eaef65d918  guix-build-60d4398a345c/output/x86_64-w64-mingw32/bitcoin-60d4398a345c-win64-setup-unsigned.exe
617022a8e07348995c1271d19ded8ef3ab20433939c1fa549406f5876cd58b9f  guix-build-60d4398a345c/output/x86_64-w64-mingw32/bitcoin-60d4398a345c-win64-unsigned.tar.gz
307da498e6af9c5440d411bd0dad1e65ba1096b9a8913b9f873c189ea342c783  guix-build-60d4398a345c/output/x86_64-w64-mingw32/bitcoin-60d4398a345c-win64.zip

Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 60d4398.

Copy link
Contributor

@TheCharlatan TheCharlatan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 60d4398

@fanquake fanquake merged commit 3ee1521 into bitcoin:master Aug 30, 2024
16 checks passed
@fanquake fanquake deleted the bump_time_machine_gcc_12_4_0 branch August 30, 2024 08:53
Fabcien pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this pull request Dec 2, 2024
Summary:
Backport of [[bitcoin/bitcoin#30730 | core#30730]].

This is more recent than our current commit, so let's bump it.

Depends on D17238.

Test Plan: Run the GUIX builds.

Reviewers: #bitcoin_abc, PiRK

Reviewed By: #bitcoin_abc, PiRK

Differential Revision: https://reviews.bitcoinabc.org/D17239
roqqit pushed a commit to doged-io/doged that referenced this pull request Dec 19, 2024
Summary:
Backport of [[bitcoin/bitcoin#30730 | core#30730]].

This is more recent than our current commit, so let's bump it.

Depends on D17238.

Test Plan: Run the GUIX builds.

Reviewers: #bitcoin_abc, PiRK

Reviewed By: #bitcoin_abc, PiRK

Differential Revision: https://reviews.bitcoinabc.org/D17239
NicolaLS added a commit to NicolaLS/bitcoin that referenced this pull request Feb 17, 2025
Cmake was made a global requirement (bitcoin#29725) and the version used is
derived from guix time-machine recently bumped in bitcoin#30730.
NicolaLS added a commit to NicolaLS/bitcoin that referenced this pull request Feb 18, 2025
CMake was made a global requirement (bitcoin#29725) and the version used is
derived from guix time-machine recently bumped in bitcoin#30730.
NicolaLS added a commit to NicolaLS/bitcoin that referenced this pull request Apr 3, 2025
CMake was made a global requirement (bitcoin#29725) and the version used is
derived from guix time-machine recently bumped in bitcoin#30730.
NicolaLS added a commit to NicolaLS/bitcoin that referenced this pull request Apr 8, 2025
CMake was made a global requirement (bitcoin#29725) and the version used is
derived from guix time-machine recently bumped (bitcoin#30730) to:
https://git.savannah.gnu.org/cgit/guix.git/tree/gnu/packages/cmake.scm?id=53396a22afc04536ddf75d8f82ad2eafa5082725#n169
@bitcoin bitcoin locked and limited conversation to collaborators Sep 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants