Skip to content

Conversation

hebasto
Copy link
Member

@hebasto hebasto commented Aug 26, 2024

The 28.x branching off is scheduled for today, so it's time to fetch the recent translations from Transifex.com using the bitcoin-maintainer-tools/update-translations.py tool.

A similar PR from the previous release cycle: #29546.

@hebasto hebasto added the GUI label Aug 26, 2024
@hebasto hebasto added this to the 28.0 milestone Aug 26, 2024
@DrahtBot
Copy link
Contributor

DrahtBot commented Aug 26, 2024

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK pablomartin4btc, achow101

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

@hebasto
Copy link
Member Author

hebasto commented Aug 26, 2024

Copy link
Member

@pablomartin4btc pablomartin4btc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK a0cdf43

No diff running make -C src translate on this PR.

@achow101
Copy link
Member

ACK a0cdf43

@achow101 achow101 merged commit a05987d into bitcoin:master Aug 26, 2024
16 checks passed
@hebasto hebasto deleted the 240826-tr branch August 27, 2024 08:03
@fanquake
Copy link
Member

See #30897. This has pulled broken strings.

fanquake added a commit that referenced this pull request Mar 12, 2025
9132824 qt: 29.0 translations update (Hennadii Stepanov)

Pull request description:

  This PR follows our [Release Process](https://github.com/bitcoin/bitcoin/blob/bd0ee07310c3dcdd08633c69eac330e2e567b235/doc/release-process.md) and concludes the translation-specific efforts for this release cycle. It follows two previous translation-related PRs, #31809 and bitcoin-core/gui#854.

  It is one of the steps required _before_ branch-off, as scheduled in #31029.

  The previous similar PR: #30715.

  **Notes for reviewers:**
  1. This is the first release process conducted after migrating the build system to CMake. The [bitcoin-maintainer-tools/update-translations.py](https://github.com/bitcoin-core/bitcoin-maintainer-tools/blob/main/update-translations.py) tool, which is used to fetch translations from [Transifex.com](https://www.transifex.com/bitcoin/bitcoin), still generates the no-longer-needed  `src/Makefile.qt_locale.include` file. Please ignore it.
  2. The actual translations on Transifex is a moving target. Therefore, your diff after running [`bitcoin-maintainer-tools/update-translations.py`](https://github.com/bitcoin-core/bitcoin-maintainer-tools/blob/main/update-translations.py) might differ.
  3. The translations for the following languages, which appear to be the result of a mistake or an act of vandalism, have been discarded:
      - Czech (cs)
      - Danish (da)
      - Dutch (nl)
  4. Changes to the Thai (th) translation have been discarded due to multiple unsolicited pronunciation notes.

ACKs for top commit:
  glozow:
    ACK 9132824

Tree-SHA512: 560dbd587eec563fa26f2ff07d950c2e86b89a7768deef7397aee80d527ad4b10c1f17d4abab6ecfcffd143e3a2d2a4e45b453197ad19c1a64087f98ab80ed4d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants