build: Remove unused visibility checks #30590
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
|
Concept ACK on dropping unused staff. |
There was a problem hiding this comment.
ACK bbcba09
The visibility("default") attribute is still used in src/tinyformat.h, but I don't think we need this check for that, since it is already gated.
Yea. I think for our use, that (and related) code could also just be removed entirely. |
There was a problem hiding this comment.
ACK bbcba09
Makes sense to remove this while it's unused.
I did find a usage of HAVE_DEFAULT_VISIBILITY_ATTRIBUTE in my source dir, but it's only present because make distclean does not remove the file src/config/bitcoin-config.h.in (which I don't think is worth tidying with a new build system on the way)
|
Ported to the CMake-based build system in hebasto#307. |
782ba0f fixup! cmake: Add introspection module (Hennadii Stepanov) Pull request description: This PR ports bitcoin#30590. ACKs for top commit: fanquake: ACK 782ba0f Tree-SHA512: 89ec94cf40d2d39b01015e1c3b46e24e687861ce50be19e5fc6c5faa23a3ddfb8e3141caff27111490b79817cc13fc7b8dfd008325856b8436ae7d6f0ade55b1
This reverts commit bbcba09 (bitcoin#30590)
This reverts commit 37c9abd (bitcoin#30590)
This reverts commit bbcba09 (bitcoin#30590)
This reverts commit 37c9abd (bitcoin#30590)
This reverts commit bbcba09 (bitcoin#30590)
This reverts commit 37c9abd (bitcoin#30590)
This reverts commit bbcba09 (bitcoin#30590)
This reverts commit 37c9abd (bitcoin#30590)
This reverts commit bbcba09 (bitcoin#30590)
This reverts commit 37c9abd (bitcoin#30590)
These are unused (since libbitcoinconsensus / #29648), and the current CMake port doesn't quite match behaviour, such that there's no real point in doing the check. So rather than port anything, just remove it. If these are needed again in future (i.e for kernel or similar), they can be revisted, and it might be the case that build-system level checks will not be wanted.