Skip to content

Conversation

fanquake
Copy link
Member

@fanquake fanquake commented Aug 2, 2024

Updates the libsecp256k1 subtree to bitcoin-core/secp256k1@642c885 (which is the tag for the v0.5.1 release).
Includes a handful of changes:

Reverts a057869 given secps default has changed (bitcoin-core/secp256k1#1563):

As a rule of thumb, the default values for configuration options should target standard desktop machines and align with Bitcoin Core's defaults, and the tests should mostly exercise the default configuration (see #1549).

642c885b61 Merge bitcoin-core/secp256k1#1575: release: prepare for 0.5.1
cdf08c1a2b Merge bitcoin-core/secp256k1#1576: doc: mention `needs-changelog` github label in release process
40d87b8e45 release: prepare for 0.5.1
5770226176 changelog: clarify CMake option
759bd4bbc8 doc: mention `needs-changelog` github label in release process
fded437c4c Merge bitcoin-core/secp256k1#1574: Fix compilation when extrakeys module isn't enabled
763d938cf0 ci: only enable extrakeys module when schnorrsig is enabled
af551ab9db tests: do not use functions from extrakeys module
0055b86780 Merge bitcoin-core/secp256k1#1551: Add ellswift usage example
ea2d5f0f17 Merge bitcoin-core/secp256k1#1563: doc: Add convention for defaults
ca06e58b2c Merge bitcoin-core/secp256k1#1564: build, ci: Adjust the default size of the precomputed table for signing
e2af491263 ci: Switch to the new default value of the precomputed table for signing
d94a9273f8 build: Adjust the default size of the precomputed table for signing
fcc5d7381b Merge bitcoin-core/secp256k1#1565: cmake: Bump CMake minimum required version up to 3.16
9420eece24 cmake: Bump CMake minimum required version up to 3.16
16685649d2 doc: Add convention for defaults
a5269373fa Merge bitcoin-core/secp256k1#1555: Fixed O3 replacement
b8fe33332b cmake: Fixed O3 replacement
31f84595c4 Add ellswift usage example
fe4fbaa7f3 examples: fix case typos in secret clearing paragraphs (s/, Or/, or/)

git-subtree-dir: src/secp256k1
git-subtree-split: 642c885b6102725e25623738529895a95addc4f4
@DrahtBot
Copy link
Contributor

DrahtBot commented Aug 2, 2024

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK hebasto

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 9ec776a, I've reproduced the subtree update locally with the zero diff with this PR branch.

@fanquake fanquake merged commit d928f4c into bitcoin:master Aug 6, 2024
16 checks passed
@fanquake fanquake deleted the secp_0_5_1 branch August 6, 2024 09:15
@hebasto
Copy link
Member

hebasto commented Aug 6, 2024

Ported to the CMake-based build system in hebasto#305.

hebasto added a commit to hebasto/bitcoin that referenced this pull request Aug 6, 2024
826dda5 fixup! cmake: Build `secp256k1` subtree (Hennadii Stepanov)
7777723 Update secp256k1 subtree to latest master (fanquake)

Pull request description:

  This PR ports bitcoin#30573.

Top commit has no ACKs.

Tree-SHA512: 2d988ddbe20c2d25ed49db2d1f508e2904bab34866fc339946c8bb73450a38f2631df395439b4edb188ce3023800fa4d19b664f9efdf04c782261cfa009c8d38
@bitcoin bitcoin locked and limited conversation to collaborators Aug 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants