depends: Cleanup postprocess commands after switching to CMake #30506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
|
My Guix build: |
|
Looks good. Want to pull in the additional CMake cleanup here: https://github.com/fanquake/bitcoin/tree/30506_more_cleanup? |
f624854 to
a0314c1
Compare
Thanks! Pulled. |
fanquake
approved these changes
Jul 25, 2024
There was a problem hiding this comment.
ACK a0314c1
Guix build (aarch64):
a35aa8777223dbb7fdb3b9f600067303a5846c26a854d7d5aaa41b5fe12a047f guix-build-a0314c151679/output/aarch64-linux-gnu/SHA256SUMS.part
917c0ebbb4c8cbddc6e314a2f6bcee22d9399356b56ecdecd6fb008882a6eb48 guix-build-a0314c151679/output/aarch64-linux-gnu/bitcoin-a0314c151679-aarch64-linux-gnu-debug.tar.gz
884d1264b2d8bcb2975c61248f5794fba26c60deb445a07f12b69c17db8c4cc6 guix-build-a0314c151679/output/aarch64-linux-gnu/bitcoin-a0314c151679-aarch64-linux-gnu.tar.gz
2626ce875616a7d0e1b7f6c8f81e6f2fcb95a0c2dd17f80281bce6355b56e441 guix-build-a0314c151679/output/arm-linux-gnueabihf/SHA256SUMS.part
bfe6d4c28d895d055226f3c37a60cf323e9bc302f418d6978bc9872cdb5fe47c guix-build-a0314c151679/output/arm-linux-gnueabihf/bitcoin-a0314c151679-arm-linux-gnueabihf-debug.tar.gz
da4eb522e5e224d3dc38bf6a215fdeab37a9f70ec0ee6d3262ca0feba6b67c45 guix-build-a0314c151679/output/arm-linux-gnueabihf/bitcoin-a0314c151679-arm-linux-gnueabihf.tar.gz
e321a506e27acb31d34115095843c136cad8e23f0088e934d29d70baa2933524 guix-build-a0314c151679/output/arm64-apple-darwin/SHA256SUMS.part
ad9c4b213b2b3bacedfc9473b2ccf64e0482b450ddaf19ff27ffde630698c421 guix-build-a0314c151679/output/arm64-apple-darwin/bitcoin-a0314c151679-arm64-apple-darwin-unsigned.tar.gz
e0de8c6f17b89ac6836901819d4012e55106e46ac0591b107032f4d7d3aa199e guix-build-a0314c151679/output/arm64-apple-darwin/bitcoin-a0314c151679-arm64-apple-darwin-unsigned.zip
aab33e2165cb57f7c2ab6c09ee7fc77d639e3542bee5dd37640003fb2ea58f0e guix-build-a0314c151679/output/arm64-apple-darwin/bitcoin-a0314c151679-arm64-apple-darwin.tar.gz
e008683cdd09f41ed7893e638a5693b401e72e195b724b9edac0354e97c10f21 guix-build-a0314c151679/output/dist-archive/bitcoin-a0314c151679.tar.gz
9a153b248716e35acd48a7c7f9b9eb5fcad0a8e98be72d43bfd0ced14ab5e001 guix-build-a0314c151679/output/powerpc64-linux-gnu/SHA256SUMS.part
b5fe52491dcd888cc38e2e77455e7f186d0c3c408c846cf3a4208c0ca113deee guix-build-a0314c151679/output/powerpc64-linux-gnu/bitcoin-a0314c151679-powerpc64-linux-gnu-debug.tar.gz
c211749116804f0b818b8d526c83891b8ec3f89bf344634b7a4773a2e717ece8 guix-build-a0314c151679/output/powerpc64-linux-gnu/bitcoin-a0314c151679-powerpc64-linux-gnu.tar.gz
1c20a8fb29fb19b23c9655f506a0c10c842988885313e342f48cea68360ff6bd guix-build-a0314c151679/output/riscv64-linux-gnu/SHA256SUMS.part
43c537196114d22e8f86d1c8646ecffa8de7cd8ced0a06b523b5c21c86ec2b84 guix-build-a0314c151679/output/riscv64-linux-gnu/bitcoin-a0314c151679-riscv64-linux-gnu-debug.tar.gz
f329b0dd9b7602ecb36e6cc721247e0bfb56b3d3bb87b842b6a36c3d18c41819 guix-build-a0314c151679/output/riscv64-linux-gnu/bitcoin-a0314c151679-riscv64-linux-gnu.tar.gz
b83ff26b772e6d07a4d95da1788bc8dcd1bb3a357b18b351078c58d754c90367 guix-build-a0314c151679/output/x86_64-apple-darwin/SHA256SUMS.part
6c3a8a7b1da14edfe173145b5ab4f22c7a8dfe19ef9b701c94c0748e7bda5c61 guix-build-a0314c151679/output/x86_64-apple-darwin/bitcoin-a0314c151679-x86_64-apple-darwin-unsigned.tar.gz
f560ac98b03660be3ef617cb90041135e970e8ef1c74604b6098659af9123a3f guix-build-a0314c151679/output/x86_64-apple-darwin/bitcoin-a0314c151679-x86_64-apple-darwin-unsigned.zip
ad93b85f9b403c6678df690cdcc63b31db68d3c42c3423f76fd777f42b1513f9 guix-build-a0314c151679/output/x86_64-apple-darwin/bitcoin-a0314c151679-x86_64-apple-darwin.tar.gz
c98f9665ef4e52eadba6026f227ca29857ccb0d5c0919513911061a6b9f165fd guix-build-a0314c151679/output/x86_64-linux-gnu/SHA256SUMS.part
0db8159eefbcc720762847cfcc5002047ad36335a7bd7dbb6122b873fce01efc guix-build-a0314c151679/output/x86_64-linux-gnu/bitcoin-a0314c151679-x86_64-linux-gnu-debug.tar.gz
dda426b52867dfc6ff858b76f41e95bec03a3c48a26eaec22c40208940b116bd guix-build-a0314c151679/output/x86_64-linux-gnu/bitcoin-a0314c151679-x86_64-linux-gnu.tar.gz
f4a66e82e3d6304a77afd13de6d229d72d2f7a05574d97b2aad7e31ac65b2846 guix-build-a0314c151679/output/x86_64-w64-mingw32/SHA256SUMS.part
715477ee3705dd3fee0c6db0afcb5a36d9bebc746ae3cfce94407ec920753397 guix-build-a0314c151679/output/x86_64-w64-mingw32/bitcoin-a0314c151679-win64-debug.zip
c90df5179bafb742e0e9e96033b1cf01f55f3da270bcb7ef324ad0551ab3d4aa guix-build-a0314c151679/output/x86_64-w64-mingw32/bitcoin-a0314c151679-win64-setup-unsigned.exe
82d7f54376fcaeb1ade794c80dcefaf441ec6b61d81f6818a51b5333eb2c9877 guix-build-a0314c151679/output/x86_64-w64-mingw32/bitcoin-a0314c151679-win64-unsigned.tar.gz
6db355c367524724b7c8de4b082ccdc0f3e6ee2defa494184d8dccd9b5306c77 guix-build-a0314c151679/output/x86_64-w64-mingw32/bitcoin-a0314c151679-win64.zip
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Oct 25, 2024
…ching to CMake a0314c1 depends: cleanup after qrencode build (fanquake) 745bf0f depends: cleanup after miniupnpc build (fanquake) 06d4aab depends: Cleanup postprocess commands after switching to CMake (Hennadii Stepanov) Pull request description: I overlooked this while reviewing bitcoin#29723, bitcoin#29835, and bitcoin#29880. ACKs for top commit: fanquake: ACK a0314c1 Tree-SHA512: debeffa7027e6213cc25c0652660ff0f36f51e63f688041d1d6cd6323e2c6cb02936fa0ecea86455b8c9874d6ea665684085189cfa523ca084792c57b0fb7c4e
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Oct 27, 2024
…ching to CMake a0314c1 depends: cleanup after qrencode build (fanquake) 745bf0f depends: cleanup after miniupnpc build (fanquake) 06d4aab depends: Cleanup postprocess commands after switching to CMake (Hennadii Stepanov) Pull request description: I overlooked this while reviewing bitcoin#29723, bitcoin#29835, and bitcoin#29880. ACKs for top commit: fanquake: ACK a0314c1 Tree-SHA512: debeffa7027e6213cc25c0652660ff0f36f51e63f688041d1d6cd6323e2c6cb02936fa0ecea86455b8c9874d6ea665684085189cfa523ca084792c57b0fb7c4e
PastaPastaPasta
added a commit
to dashpay/dash
that referenced
this pull request
Oct 27, 2024
b654479 Merge bitcoin#30705: test: Avoid intermittent block download timeout in p2p_ibd_stalling (merge-script) 745a819 Merge bitcoin#30690: devtools, utxo-snapshot: Fix block height out of range in script (Ava Chow) 01b570e Merge bitcoin#29999: guix: fix suggested fake date for openssl-1.1.1l (Ava Chow) 432f352 Merge bitcoin#30580: doc: Add note about distro's `g++-mingw-w64-x86-64-posix` version (merge-script) 1bd090e Merge bitcoin#30597: doc: Drop no longer needed workaround for WSL (merge-script) 8a12237 Merge bitcoin#30630: doc: Update ccache website link (merge-script) f66547f Merge bitcoin#30588: depends: fix ZMQ CMake getcachesize check (merge-script) ddaec96 Merge bitcoin#30565: depends: Fix `zeromq` build on OpenBSD (merge-script) e4e5605 Merge bitcoin#30552: test: fix constructor of msg_tx (merge-script) df3c239 Merge bitcoin#26950: cleanse: switch to SecureZeroMemory for Windows cross-compile (merge-script) 57945ce Merge bitcoin#30506: depends: Cleanup postprocess commands after switching to CMake (merge-script) e016ffa Merge bitcoin#29878: depends: build expat with CMake (merge-script) 62dcd43 Merge bitcoin#29880: depends: build FreeType with CMake (merge-script) 745addf Merge bitcoin#30245: net: Allow -proxy=[::1] on nodes with IPV6 lo only (Ava Chow) 4e144be Merge bitcoin-core/gui#795: Keep focus on "Hide" while ModalOverlay is visible (Hennadii Stepanov) 69c04b2 Merge bitcoin#30372: util: Use SteadyClock in RandAddSeedPerfmon (merge-script) ebed8af Merge bitcoin#30336: depends: update doc in Qt pwd patch (merge-script) 9793fb1 Merge bitcoin#30340: test: Added coverage to Block not found error using gettxoutsetinfo (Ava Chow) 479cb8b Merge bitcoin#30312: contrib: add R(UN)PATH check to ELF symbol-check (merge-script) ca83773 Merge bitcoin#30283: upnp: fix build with miniupnpc 2.2.8 (merge-script) 63e139d Merge bitcoin#30185: guix: show `*_FLAGS` variables in pre-build output (merge-script) 3be0d3e Merge bitcoin#30097: crypto: disable asan for sha256_sse4 with clang and -O0 (merge-script) 3070c3e Merge bitcoin#30078: depends: set AR & RANLIB for CMake (merge-script) Pull request description: ## Issue being fixed or feature implemented Trivial backports ## What was done? ## How Has This Been Tested? built locally ## Breaking Changes ## Checklist: _Go over all the following points, and put an `x` in all the boxes that apply._ - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_ ACKs for top commit: UdjinM6: utACK b654479 kwvg: utACK b654479 Tree-SHA512: 10b5af4e92c83fa9d6764b20bf066bba8e4c600402966fd5c1d6dad07b0549d8a42151a33f21e2f8263336c12a810a6f3fc2828d90bc98153e09c165d9e5b043
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I overlooked this while reviewing #29723, #29835, and #29880.