Update minisketch subtree to eb37a9b8e79f9e49d73b96a49bf97a96d9eb676c #30270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eb37a9b8e7 Merge bitcoin-core/minisketch#87: Avoid copy in self-assign fe6557642e Merge bitcoin-core/minisketch#88: build: Add `-Wundef` 8ea298bfa7 Avoid copy in self-assign 978a3d8869 build: Add `-Wundef` 3387044179 Merge bitcoin-core/minisketch#86: doc: fix typo in sketch_impl.h 15c2d13b60 doc: fix typo in sketch_impl.h 7be08b8a46 Merge bitcoin-core/minisketch#85: Fixes for integer precision loss 00fb4a4d83 Avoid or make integer precision conversion explicit 9d62a4d27c Avoid the need to cast/convert to size_t for vector operations 19e06cc7af Prevent overflows from large capacity/max_elements git-subtree-dir: src/minisketch git-subtree-split: eb37a9b8e79f9e49d73b96a49bf97a96d9eb676c
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
theuni
approved these changes
Jun 12, 2024
|
utACK 89464ad |
|
Guix Build (aarch64): 043f66f1a8d58b8dcba45fe88bc1fd0e8cd2222d05a678e3f14bcd52c905533e guix-build-89464ad59cf1/output/aarch64-linux-gnu/SHA256SUMS.part
11f73219fdfe67f878aaf9552d30076267e6925cfac82cf1dfd276b4bc416a38 guix-build-89464ad59cf1/output/aarch64-linux-gnu/bitcoin-89464ad59cf1-aarch64-linux-gnu-debug.tar.gz
ac903add0b8fe9fa3eb578e2270a64c6f7ed1ec054069647a40c564d5b6d0c3c guix-build-89464ad59cf1/output/aarch64-linux-gnu/bitcoin-89464ad59cf1-aarch64-linux-gnu.tar.gz
c9ae08ca3c1bf3dfaed4f6ccaf7fef00c2f9e3d28e691ba1f9323b5eaef35853 guix-build-89464ad59cf1/output/arm-linux-gnueabihf/SHA256SUMS.part
a1a4edad41f789ba29bcc02e9ecf092ca3849254be395cea544a7c4cf8c824aa guix-build-89464ad59cf1/output/arm-linux-gnueabihf/bitcoin-89464ad59cf1-arm-linux-gnueabihf-debug.tar.gz
be00312a8986b67d058138c67cb035ffdbd7181becc067040508b920d42c0c92 guix-build-89464ad59cf1/output/arm-linux-gnueabihf/bitcoin-89464ad59cf1-arm-linux-gnueabihf.tar.gz
e602b8b84028bfbaa982b118f1b368387b9f844be9dbd9fcb9767a19a93d5b90 guix-build-89464ad59cf1/output/arm64-apple-darwin/SHA256SUMS.part
4eac7e2901457b05eecf7b0336b81ab7bcf4b2ff300ce7ba4375b383e1a27fc2 guix-build-89464ad59cf1/output/arm64-apple-darwin/bitcoin-89464ad59cf1-arm64-apple-darwin-unsigned.tar.gz
ff9db12c85898e49179621c1faa360ec2a5d34deff2dcc6969cf72517a98fae0 guix-build-89464ad59cf1/output/arm64-apple-darwin/bitcoin-89464ad59cf1-arm64-apple-darwin-unsigned.zip
86865327202af1f5a3e9ddbdaf41528468b1bd1a25c5e144e7aa48a2b054038a guix-build-89464ad59cf1/output/arm64-apple-darwin/bitcoin-89464ad59cf1-arm64-apple-darwin.tar.gz
5a4616646631b80320d204e597d7c1f7cb9ff8cc4bda4d7511b6be8c1aac2223 guix-build-89464ad59cf1/output/dist-archive/bitcoin-89464ad59cf1.tar.gz
916024d95479d1a8b3f17f6775d8c74306b0df78e2ff2f146cf8bbabc7b6579b guix-build-89464ad59cf1/output/powerpc64-linux-gnu/SHA256SUMS.part
7d61eb841b3c64f8a01be40f6973686427bd47b984a62200a970bc01531aeab8 guix-build-89464ad59cf1/output/powerpc64-linux-gnu/bitcoin-89464ad59cf1-powerpc64-linux-gnu-debug.tar.gz
90321dfb5ccafcbf31069eebdee663818bdec313a1244b3bce85430c7c34eccc guix-build-89464ad59cf1/output/powerpc64-linux-gnu/bitcoin-89464ad59cf1-powerpc64-linux-gnu.tar.gz
76a67e0495b7c8cb7c64aa45ce63dd9cb5e12ec5dd30017e11f9a66bd6edfb97 guix-build-89464ad59cf1/output/riscv64-linux-gnu/SHA256SUMS.part
5a810071b0f42d593f8465a4df3365a3925f6fc097db0dea82f80c49cec12e3d guix-build-89464ad59cf1/output/riscv64-linux-gnu/bitcoin-89464ad59cf1-riscv64-linux-gnu-debug.tar.gz
2562baa01fc24bd338a640b240b9df9895c54bd920bd811708f091feef710ad7 guix-build-89464ad59cf1/output/riscv64-linux-gnu/bitcoin-89464ad59cf1-riscv64-linux-gnu.tar.gz
d681cac933906cd53d7481537f4203a3e3aef265e683c37c96efec544f5d7785 guix-build-89464ad59cf1/output/x86_64-apple-darwin/SHA256SUMS.part
68d44980b474b5d0f0f7d9d24536521e46f0bd4d76e706f25b914238fb510e0b guix-build-89464ad59cf1/output/x86_64-apple-darwin/bitcoin-89464ad59cf1-x86_64-apple-darwin-unsigned.tar.gz
4147577809c2f89130ddc7997dee2828615169b4c6fc31e61b070eeefd5e30d0 guix-build-89464ad59cf1/output/x86_64-apple-darwin/bitcoin-89464ad59cf1-x86_64-apple-darwin-unsigned.zip
0000e24d6ece4ff9e7e12d8ab71a4bd85e3805df573575911adf2332e18ca6d4 guix-build-89464ad59cf1/output/x86_64-apple-darwin/bitcoin-89464ad59cf1-x86_64-apple-darwin.tar.gz
ad7281d06e35c157ca536decb3ab420d1403011d9243f42e6623e060a33d9588 guix-build-89464ad59cf1/output/x86_64-linux-gnu/SHA256SUMS.part
b257e5089ca05945d002fd8960accf94938c329009950c706ff92c438eaa1f4e guix-build-89464ad59cf1/output/x86_64-linux-gnu/bitcoin-89464ad59cf1-x86_64-linux-gnu-debug.tar.gz
80872dbe43c753ed1e6b235439580a0dd3f11f53fcfc2a10ca44d3b5afa6dddd guix-build-89464ad59cf1/output/x86_64-linux-gnu/bitcoin-89464ad59cf1-x86_64-linux-gnu.tar.gz
45b282460d32f7c0f4570aa56ab4e080d632ecd8a40ad8899cf238af23f122c0 guix-build-89464ad59cf1/output/x86_64-w64-mingw32/SHA256SUMS.part
88800b2dd2395b7c39ec2a7f288aabd8245e81825ce99244da8d762fe3bb547d guix-build-89464ad59cf1/output/x86_64-w64-mingw32/bitcoin-89464ad59cf1-win64-debug.zip
2d1895791bc1da90575cc76d543ae8bb624c0eb36c7fbe9de1fe7a60de0584a9 guix-build-89464ad59cf1/output/x86_64-w64-mingw32/bitcoin-89464ad59cf1-win64-setup-unsigned.exe
1a4718df87308788dbc1d13e158ceda44b7cf1dc426ca4d09c70eee20f679ac4 guix-build-89464ad59cf1/output/x86_64-w64-mingw32/bitcoin-89464ad59cf1-win64-unsigned.tar.gz
c7889e30d009ef9f317ecb678eb7801b4e6109d0e59a1452110b0b2dac31c19a guix-build-89464ad59cf1/output/x86_64-w64-mingw32/bitcoin-89464ad59cf1-win64.zip |
PastaPastaPasta
added a commit
to dashpay/dash
that referenced
this pull request
Oct 29, 2024
…c/minisketch' to bitcoin-core/minisketch@eb37a9b8) 5e65bb4 merge bitcoin#30270: update subtree to eb37a9b8 (Kittywhiskers Van Gogh) ef10e83 Squashed 'src/minisketch/' changes from 3472e2f5ec..eb37a9b8e7 (Kittywhiskers Van Gogh) 94dca7f merge bitcoin#29823: update subtree to 3472e2f5e (Kittywhiskers Van Gogh) 9540ecb Squashed 'src/minisketch/' changes from a571ba20f9..3472e2f5ec (Kittywhiskers Van Gogh) Pull request description: ## Additional information Unexpected failure was found in UBSan unit test run originating from minisketch tests ([build](https://gitlab.com/dashpay/dash/-/jobs/8206813511#L3512)), resolved in subtree with bitcoin-core/minisketch#81 and updated upstream in bitcoin#29823. This pull request updates the subtree to latest subtree pulls done on upstream `master` (as of this writing, [`da10e0ba`](https://github.com/bitcoin/bitcoin/tree/da10e0bab4a3e98868dd663af02c43b1dc8b7f4a)). Special thanks to knst for reporting this bug! 🎉 ## Breaking Changes None expected. ## Checklist - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas **(note: N/A)** - [x] I have added or updated relevant unit/integration/functional/e2e tests **(note: N/A)** - [x] I have made corresponding changes to the documentation **(note: N/A)** - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_ ACKs for top commit: UdjinM6: utACK 5e65bb4 Tree-SHA512: be3c75436425c8662d6af46641a6fc744d01043a832884b29aa9767dd4b9090cef93bcb31355032131392a6ccf29cbbcb771a5786c654f26f4fa0a2d5f0e8a5f
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes bitcoin-core/minisketch#87 which is used in #30234.
Includes bitcoin-core/minisketch#88 which is used in #29876.