Skip to content

Conversation

hebasto
Copy link
Member

@hebasto hebasto commented Jun 2, 2024

On master branch @ 457e184, building the fuzz binary fails:

$ ./autogen.sh
$ ./configure
$ gmake -C src test/fuzz/fuzz
< snip >
  CXX      test/fuzz/fuzz-http_request.o
test/fuzz/http_request.cpp:13:10: fatal error: event2/buffer.h: No such file or directory
   13 | #include <event2/buffer.h>
      |          ^~~~~~~~~~~~~~~~~
compilation terminated.
gmake: *** [Makefile:17138: test/fuzz/fuzz-http_request.o] Error 1
gmake: Leaving directory '/export/home/hebasto/git/bitcoin/src'

The testing system:

$ uname -a
SunOS openindiana 5.11 illumos-82079dec87 i86pc i386 i86pc

This PR fixes this issue.

@DrahtBot
Copy link
Contributor

DrahtBot commented Jun 2, 2024

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK maflcko

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

@maflcko
Copy link
Member

maflcko commented Jun 3, 2024

ACK 3299abc

@fanquake fanquake merged commit e40df54 into bitcoin:master Jun 3, 2024
@hebasto hebasto deleted the 240602-libevent branch June 3, 2024 12:13
fanquake pushed a commit to fanquake/bitcoin that referenced this pull request Jun 4, 2024
@fanquake fanquake mentioned this pull request Jun 4, 2024
@fanquake
Copy link
Member

fanquake commented Jun 4, 2024

Backported to 27.x in #30222.

fanquake added a commit that referenced this pull request Jun 11, 2024
d756a38 doc: update manual pages for 27.1 (fanquake)
93bb18f build: bump version to v27.1 final (fanquake)
fcf1241 doc: update release notes for v27.1 final (fanquake)
f2e05cd depends: Update Boost download link (Hennadii Stepanov)
ba35920 build: Fix building `fuzz` binary on on SunOS / illumos (Hennadii Stepanov)

Pull request description:

  Backports:
  * #30216
  * #30217

  I don't think either of these changes warrants an `rc2` cycle.

ACKs for top commit:
  stickies-v:
    ACK d756a38
  willcl-ark:
    ACK d756a38

Tree-SHA512: b5662143283a49156403d865dee25f3b6c22741345a4c8ff10f16845ea7a1a6d9d1319a70a44d07f31263bf1a6d85701146e9cc697b82a5a58922c48504a552c
@hebasto
Copy link
Member Author

hebasto commented Jul 14, 2024

There is nothing to port to the CMake staging branch. Deleting the "Needs CMake port" label.

@bitcoin bitcoin locked and limited conversation to collaborators Jul 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants