Skip to content

msvc: Compile test\fuzz\miniscript.cpp #30031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 6, 2024
Merged

msvc: Compile test\fuzz\miniscript.cpp #30031

merged 1 commit into from
May 6, 2024

Conversation

hebasto
Copy link
Member

@hebasto hebasto commented May 3, 2024 •
edited
Loading

This PR resolves the remained point from the #29774 (comment):

What is the issue with the ... miniscript fuzz tests?

From the CI log:

miniscript_script: succeeded against 721 files in 1s.
Run miniscript_script with args ['D:\\a\\bitcoin\\bitcoin\\src\\fuzz.exe', WindowsPath('D:/a/_temp/qa-assets/fuzz_seed_corpus/miniscript_script')]
miniscript_smart: succeeded against 1429 files in 2s.
Run miniscript_smart with args ['D:\\a\\bitcoin\\bitcoin\\src\\fuzz.exe', WindowsPath('D:/a/_temp/qa-assets/fuzz_seed_corpus/miniscript_smart')]
miniscript_stable: succeeded against 1871 files in 2s.
Run miniscript_stable with args ['D:\\a\\bitcoin\\bitcoin\\src\\fuzz.exe', WindowsPath('D:/a/_temp/qa-assets/fuzz_seed_corpus/miniscript_stable')]
miniscript_string: succeeded against 918 files in 3s.
Run miniscript_string with args ['D:\\a\\bitcoin\\bitcoin\\src\\fuzz.exe', WindowsPath('D:/a/_temp/qa-assets/fuzz_seed_corpus/miniscript_string')]

@DrahtBot
Copy link
Contributor

DrahtBot commented May 3, 2024 •
edited
Loading

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK maflcko, TheCharlatan

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

@hebasto hebasto mentioned this pull request May 3, 2024
Merged
@hebasto hebasto force-pushed the 240503-msvc-fuzz-miniscript branch 3 times, most recently from 43141bc to 71ada38 Compare May 3, 2024 12:46
@hebasto hebasto mentioned this pull request May 3, 2024
Merged
@hebasto hebasto closed this May 3, 2024
@hebasto hebasto reopened this May 3, 2024
@hebasto hebasto force-pushed the 240503-msvc-fuzz-miniscript branch from 71ada38 to d2279cc Compare May 3, 2024 15:48
@fanquake
Copy link
Member

fanquake commented May 4, 2024 •
edited
Loading

Based on #28657.

Can be rebased now.

@hebasto hebasto marked this pull request as ready for review May 4, 2024 08:04
@hebasto hebasto force-pushed the 240503-msvc-fuzz-miniscript branch from d2279cc to 9155b73 Compare May 4, 2024 08:05
@hebasto
Copy link
Member Author

hebasto commented May 4, 2024

Based on #28657.

Can be rebased now.

Rebased and undrafted.

@maflcko
Copy link
Member

maflcko commented May 4, 2024

ACK 9155b73

TheCharlatan
TheCharlatan approved these changes May 4, 2024
View reviewed changes
Copy link
Contributor

@TheCharlatan TheCharlatan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 9155b73

@emc99
Copy link

emc99 commented May 4, 2024

There is no file at test/fuzz/miniscript

@hebasto
Copy link
Member Author

hebasto commented May 4, 2024

There is no file at test/fuzz/miniscript

$ file src/test/fuzz/miniscript.cpp
src/test/fuzz/miniscript.cpp: C++ source, ASCII text

@hebasto hebasto mentioned this pull request May 4, 2024
Merged
@hebasto
Copy link
Member Author

hebasto commented May 4, 2024

Ported to the CMake-based build system in hebasto#187.

@emc99
Copy link

emc99 commented May 4, 2024 •
edited
Loading

@hebasto Are you looking for someone to compile this file on msvc?

@DrahtBot DrahtBot removed the CI failed label May 5, 2024
@fanquake fanquake merged commit f7b81c7 into bitcoin:master May 6, 2024
@hebasto hebasto deleted the 240503-msvc-fuzz-miniscript branch May 6, 2024 07:33
hebasto added a commit to hebasto/bitcoin that referenced this pull request May 8, 2024
@hebasto
Merge #187: cmake: Port PR30031 from the master branch
7712606 
5aa5843 fixup! cmake: Add fuzzing options (Hennadii Stepanov)

Pull request description:

  This PR ports bitcoin#30031 after the recent sync/rebase [PR](#186).

Top commit has no ACKs.

Tree-SHA512: b90c3048e22804e520b77e20ed33d8a9cd755b1b6d5e04a6f2922bba9cdd9bc675c8f70bcb13003c4933930328c3e8d2d77cce501a036edf2eca9d1d599c743a
@bitcoin bitcoin locked and limited conversation to collaborators May 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@TheCharlatan TheCharlatan TheCharlatan approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hebasto @DrahtBot @fanquake @maflcko @emc99 @TheCharlatan