Skip to content

Conversation

maflcko
Copy link
Member

@maflcko maflcko commented Dec 24, 2021

Without them, CI and fuzzing is broken

@maflcko
Copy link
Member Author

maflcko commented Dec 24, 2021

#22704 (comment)

@DrahtBot DrahtBot added the Tests label Dec 24, 2021
Copy link
Contributor

@stratospher stratospher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK faaf9da. The changes look good to me.

I wasn't able to reproduce the fuzz crashes before applying this commit locally though.

$ base64 crash-03f91945a7518033b0df73bf35c2caa452126610
9tXRyA==
$ base64 crash-ce471b8e19b31491ff5f4a3669aefa84b1848f06
8goKCj84G/Q=
$ FUZZ=crypto_diff_fuzz_chacha20 src/test/fuzz/fuzz crash-03f91945a7518033b0df73bf35c2caa452126610
INFO: Running with entropic power schedule (0xFF, 100).
INFO: Seed: 4109103340
INFO: Loaded 1 modules   (846038 inline 8-bit counters): 846038 [0x10ea8b318, 0x10eb59bee), 
INFO: Loaded 1 PC tables (846038 PCs): 846038 [0x10eb59bf0,0x10f842950), 
src/test/fuzz/fuzz: Running 1 inputs 1 time(s) each.
Running: crash-03f91945a7518033b0df73bf35c2caa452126610
Executed crash-03f91945a7518033b0df73bf35c2caa452126610 in 1 ms
***
*** NOTE: fuzzing was not performed, you have only
***       executed the target code on a fixed set of inputs.
***
$ FUZZ=crypto_diff_fuzz_chacha20 src/test/fuzz/fuzz crash-ce471b8e19b31491ff5f4a3669aefa84b1848f06
INFO: Running with entropic power schedule (0xFF, 100).
INFO: Seed: 4170518589
INFO: Loaded 1 modules   (846038 inline 8-bit counters): 846038 [0x10bc76318, 0x10bd44bee), 
INFO: Loaded 1 PC tables (846038 PCs): 846038 [0x10bd44bf0,0x10ca2d950), 
src/test/fuzz/fuzz: Running 1 inputs 1 time(s) each.
Running: crash-ce471b8e19b31491ff5f4a3669aefa84b1848f06
Executed crash-ce471b8e19b31491ff5f4a3669aefa84b1848f06 in 1 ms
***
*** NOTE: fuzzing was not performed, you have only
***       executed the target code on a fixed set of inputs.
***

@fanquake fanquake merged commit 0106861 into bitcoin:master Dec 25, 2021
@maflcko maflcko deleted the 2112-testSup branch December 25, 2021 09:56
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Dec 27, 2021
…uzz_chacha20.cpp

faaf9da test: Add missing suppressions for crypto_diff_fuzz_chacha20.cpp (MarcoFalke)

Pull request description:

  Without them, CI and fuzzing is broken

ACKs for top commit:
  stratospher:
    ACK faaf9da. The changes look good to me.

Tree-SHA512: 46604ba1b6eb8ea321e55e043835ca1e7a4f562855007b08cf9cf96d9a7f2a0155009ca1397f34338e478b8cc5b5a6a0dc94e1878a2f00bfab11595ae58bb014
hebasto added a commit to bitcoin-core/gui-qml that referenced this pull request Jan 5, 2022
…a20.cpp

4b0dbda test: Add missing suppressions for crypto_diff_fuzz_chacha20.cpp (MarcoFalke)

Pull request description:

  This is a quick fix of the CI fuzzer task. Cherry-picked from bitcoin/bitcoin#23859, and should be combined with the next sync with the main repo.

ACKs for top commit:
  promag:
    utACK 4b0dbda.

Tree-SHA512: eee8d87f88c70aebfae8f73848ce20bc489e6c1c4ecbe2d63c9cccf6d5d057ec149c69fa2b4f02285d14e387c0d6ccde815070425ad5dcabe611968251dc285c
@bitcoin bitcoin locked and limited conversation to collaborators Dec 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants