doc: Fix -changetype help text #23840
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was forgotten in commit 3ac3805
shaavan
approved these changes
Dec 22, 2021
There was a problem hiding this comment.
ACK fa993d0
The updated docs match the implementation changes done in 3ac3805
The updated docs tell about the default value of -changetype (i.e., legacy).
And all the non-default behavior is implied by “else it is an implementation detail.” I especially like using this phrasing because:
- A non-tech savvy user wouldn’t like (or need) to know all the implementation details.
- A tech-savvy user is pointed in the right direction to find the details.
- Save precious space on the terminal when this text is displayed through –help command.
Tested successfully on Ubuntu 20.04 using the command:
./src/bitcoin –help
| Master | PR |
|---|---|
w0xlt
approved these changes
Dec 23, 2021
josibake
approved these changes
Dec 27, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was forgotten in commit 3ac3805