Skip to content

ci: use GCC 8 when building packages in native_qt5 CI #23845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 23, 2021
Merged

ci: use GCC 8 when building packages in native_qt5 CI #23845

merged 1 commit into from
Dec 23, 2021

Conversation

fanquake
Copy link
Member

Our minimum required GCC is GCC 8, and this change in required for
PRs like #23839 which take advantage of flags introduced in that
version of GCC.

This should have been included as part of 182de7b.

@fanquake
ci: use GCC 8 when building packages in native_qt5 CI
2da97b2 
Our minimum required GCC is GCC 8, and this change in required for
changes like bitcoin#23839 which take advantage of flags introduced in that
version of GCC.

This should have been included as part of
182de7b.
@fanquake fanquake added the Tests label Dec 23, 2021
@fanquake fanquake mentioned this pull request Dec 23, 2021
Merged
@maflcko
Copy link
Member

maflcko commented Dec 23, 2021

cr ACK 2da97b2

hebasto
hebasto approved these changes Dec 23, 2021
View reviewed changes
Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 2da97b2

With NO_QT=1 the #22184 is not a problem.

@maflcko maflcko merged commit 7551ae8 into bitcoin:master Dec 23, 2021
@fanquake fanquake deleted the gcc_8_native_qt5_ci branch December 24, 2021 02:22
@hebasto hebasto mentioned this pull request Dec 24, 2021
Merged
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Dec 27, 2021
Merge bitcoin#23845: ci: use GCC 8 when building packages in native_q…
f8f4484 
…t5 CI
@bitcoin bitcoin locked and limited conversation to collaborators Dec 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hebasto hebasto hebasto approved these changes

Assignees
No one assigned
Labels
Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fanquake @maflcko @hebasto