doc: follow-ups from #23365 (index backwards search) #23777
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maflcko
approved these changes
Dec 15, 2021
These were suggested in review of bitcoin#23365 Co-authored-by: John Newbery <john@johnnewbery.com>
43ccaf6 to
e4a8d56
Compare
|
ACK e4a8d56 |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Dec 16, 2021
…rds search) e4a8d56 doc: add explanations for assert in index and magic numbers in test (Martin Zumsande) Pull request description: This adds two explanations suggested in the review of bitcoin#23365, that I didn't manage to address before that PR was merged: bitcoin#23365 (comment) bitcoin#23365 (comment) ACKs for top commit: jnewbery: ACK e4a8d56 Tree-SHA512: 0500c8abb37bb3e3694463ad5e74b2e1483615ccf1d7529b0d5faa694652ada17d242dc7fda6d995733766c627d54178a2c8fa21a570cdf13292f64ff5425b56
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Apr 5, 2022
Summary: These were suggested in review of #23365 Co-authored-by: John Newbery <john@johnnewbery.com> This is a backport of [[bitcoin/bitcoin#23777 | core#23777]] Depends on D11299 Test Plan: NA - comments only Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D11303
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds two explanations suggested in the review of #23365, that I didn't manage to address before that PR was merged:
#23365 (comment)
#23365 (comment)