test: make feature_init more robust #23737
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2dcd812 to
95aca84
Compare
95aca84 to
2a026e9
Compare
|
Could rebase over commit bf66e25? |
2a026e9 to
0fc6b72
Compare
Rebased and re-enabled the txindex portion of the test. |
|
Thanks, concept ACK |
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
|
Are you still working on this? If not, that is fine, just let us know, so that it can be picked up. |
|
Oh whoops, didn't see the rebase label. |
This part of the test sporadically fails on CI infrastructure. Instead of perturbing a single .ldb file of each type, move all .ldb files of a given type to ensure a bad startup.
This test sporadically fails due to the Python test missing log lines for reasons that are poorly understood. The problem is made worse by the fact that this test does not retain the log files from iteration to iteration. Change the test to do logline detection in a more robust manner (by using `re.search` on the whole log content) in a way that is comparable to the existing `assert_debug_log` utility, and retain all debug.log content from case to case.
Now that bitcoin#23365 is merged.
0fc6b72 to
8904f17
Compare
|
Merging this to unbreak the CI. I am resetting too many CI build manually every day |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Jan 4, 2022
maflcko
reviewed
Jan 6, 2022
| @@ -132,7 +104,8 @@ def check_clean_start(): | |||
| if line: | |||
There was a problem hiding this comment.
line = logfile.readline()
File "/usr/lib/python3.8/codecs.py", line 322, in decode
(result, consumed) = self._buffer_decode(data, self.errors, final)
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xe2 in position 0: unexpected end of data
Closed
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Nov 25, 2022
Summary: This part of the test sporadically fails on CI infrastructure. Instead of perturbing a single .ldb file of each type, move all .ldb files of a given type to ensure a bad startup. This is a partial backport of [[bitcoin/bitcoin#23737 | core#23737]] bitcoin/bitcoin@24fcf6e Depends on D12612 Test Plan: `ninja check-functional` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D12613
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Nov 25, 2022
Summary: > test: introduce TestNode.debug_log_bytes > test: add TestNode.wait_for_debug_log > test: feature_init: retain debug.log and improve detection > > This test sporadically fails due to the Python test missing log lines > for reasons that are poorly understood. The problem is made worse by the > fact that this test does not retain the log files from iteration to > iteration. > > Change the test to do logline detection in a more robust manner (by > using `re.search` on the whole log content) in a way that is comparable > to the existing `assert_debug_log` utility, and retain all debug.log > content from case to case. This is a partial backport of [[bitcoin/bitcoin#23737 | core#23737]] bitcoin/bitcoin@a2fb62b bitcoin/bitcoin@a8ffbc0 bitcoin/bitcoin@93db6d8 Depends on D12613 Test Plan: `ninja check-functional` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D12614
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Nov 25, 2022
Summary: > Now that [[bitcoin/bitcoin#23365 | core#23365]] is merged. [[bitcoin/bitcoin#23365 | core#23365]] was backported in D11299 This concludes backport of [[bitcoin/bitcoin#23737 | core#23737]] bitcoin/bitcoin@8904f17 Depends on D12614 Test Plan: `ninja check-functional` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D12615
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully fixes #23646.
This makes a few changes to feature_init (along the lines of the discussion here: #23289 (comment)). The changes are detailed in the specific commits, but a summary might be: