Skip to content

build, qt: Use Android NDK r23 LTS #23677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 7, 2021
Merged

Conversation

hebasto
Copy link
Member

@hebasto hebasto commented Dec 5, 2021

This is a continuation of #23478, and, thanks to #23489, a oneline patch is only required to be able build the qt package in depends with Android NDK r23 LTS.

@DrahtBot
Copy link
Contributor

DrahtBot commented Dec 7, 2021

Guix builds

File commit ea989de
(master)
commit 346da82
(master and this pull)
SHA256SUMS.part 0968672aa4c56999... 1ccab0a73bd257c0...
*-aarch64-linux-gnu-debug.tar.gz 71a671f389d37087... 30c277463100d5bf...
*-aarch64-linux-gnu.tar.gz 516152c362612a0a... 77922bbdb66cd6ba...
*-arm-linux-gnueabihf-debug.tar.gz 20988c1d424e79e8... 7f17d7b93a248341...
*-arm-linux-gnueabihf.tar.gz 49c7df5d1aad8d7f... 299419a261d454ed...
*-osx-unsigned.dmg 76a655e23992808b... d99d2ad42df7570a...
*-osx-unsigned.tar.gz 26dce6356dd193e6... 640f3db78a3401a8...
*-osx64.tar.gz 1eb240c555392f63... 0cbe0c9502582b7b...
*-powerpc64-linux-gnu-debug.tar.gz 4078f8ac7b6323b8... 4758960d00452c3d...
*-powerpc64-linux-gnu.tar.gz 23fdc62d42b3b122... 259cee9c104b0819...
*-powerpc64le-linux-gnu-debug.tar.gz 6f8c63ed80f19ba5... cb76d3a875a55dce...
*-powerpc64le-linux-gnu.tar.gz 39f128db04cdbba3... ba130836ed9af279...
*-riscv64-linux-gnu-debug.tar.gz 515f36c2ddb861af... d9ee0acc34ada6bd...
*-riscv64-linux-gnu.tar.gz 6ee0a832592f387c... 0e0295e7f9fd491b...
*-win-unsigned.tar.gz 0ec6adecce6f7002... e7edc38922613721...
*-win64-debug.zip 6e0700c8b3f48ffd... b9fb3e08c1c3d7d1...
*-win64-setup-unsigned.exe 7f41144edd8ef579... 53242aec6cffa499...
*-win64.zip 8b61be69899e55a8... 4ece09c3542f54bd...
*-x86_64-linux-gnu-debug.tar.gz 0c1fdd09025172e0... 6a4246f7fd5afe37...
*-x86_64-linux-gnu.tar.gz f19a05e3052a4ed3... b0d481d6f41dfc08...
*.tar.gz edbfdd2bf1950f9f... 93a0df5e05515cd8...
guix_build.log 1c92eade3550beca... 166fdd28164ef719...
guix_build.log.diff 0bc7b291700b04a5...

Copy link
Member

@fanquake fanquake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 78a6bc6

Guix build:

bash-5.1# find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
96196efbfdc520598027dae764c658d1a83c53baaa18322d92e090489385a162  guix-build-78a6bc6919e9/output/aarch64-linux-gnu/SHA256SUMS.part
ba6c89f844da64fb4f32e3ee2dcd82ff182602733db0a3d96c1115d40a8194ae  guix-build-78a6bc6919e9/output/aarch64-linux-gnu/bitcoin-78a6bc6919e9-aarch64-linux-gnu-debug.tar.gz
b7520e12e78618bf1766795f98353c6b17dc6d8a2270c3aa9e5379042a97051d  guix-build-78a6bc6919e9/output/aarch64-linux-gnu/bitcoin-78a6bc6919e9-aarch64-linux-gnu.tar.gz
b15d21e6f34367495096c23e34d728c6309727f429dd8c470487b9c09d256732  guix-build-78a6bc6919e9/output/arm-linux-gnueabihf/SHA256SUMS.part
f41828e0f5afefed56c4964eefeaf890f465941d909a19183c4532adfe261339  guix-build-78a6bc6919e9/output/arm-linux-gnueabihf/bitcoin-78a6bc6919e9-arm-linux-gnueabihf-debug.tar.gz
fd1aebd3278ed264ebc28bd40e5c2d46f36f7ae7199779add3636a66d9aa65c7  guix-build-78a6bc6919e9/output/arm-linux-gnueabihf/bitcoin-78a6bc6919e9-arm-linux-gnueabihf.tar.gz
fc2928a729e01fd9f524670f0bdf6bad49df5baa08481c6060e0b1a7091658cb  guix-build-78a6bc6919e9/output/dist-archive/bitcoin-78a6bc6919e9.tar.gz
aa2b161589560b3f1b636fbc4b4e08fa1257f174ba8df81271bc083e18c16ca5  guix-build-78a6bc6919e9/output/powerpc64-linux-gnu/SHA256SUMS.part
e26c59e60500f4fbd28ed24a2e82e0eae9f3e78ab581badba93559cd986ec072  guix-build-78a6bc6919e9/output/powerpc64-linux-gnu/bitcoin-78a6bc6919e9-powerpc64-linux-gnu-debug.tar.gz
90195a682342cb175b0e969d17e21c226166632be129fb82d01fa007e6fa4ea2  guix-build-78a6bc6919e9/output/powerpc64-linux-gnu/bitcoin-78a6bc6919e9-powerpc64-linux-gnu.tar.gz
3d850bbde65378828b0c6829dcc7fa9ce7516ea98f9843c1a5e761e10c2a08a6  guix-build-78a6bc6919e9/output/powerpc64le-linux-gnu/SHA256SUMS.part
e646c7b7b589b6f30ea57bede54bafa91aac44e1eeffc647cca193309748e703  guix-build-78a6bc6919e9/output/powerpc64le-linux-gnu/bitcoin-78a6bc6919e9-powerpc64le-linux-gnu-debug.tar.gz
f2cdb8773a85a1485582429e42f5192c4ad0755db8c788a149e0c3b1bd8984a4  guix-build-78a6bc6919e9/output/powerpc64le-linux-gnu/bitcoin-78a6bc6919e9-powerpc64le-linux-gnu.tar.gz
2e13a832d050af958dcd9c4e7dd24e47160d4fd2aca6e87cc3a1aad2f683a6af  guix-build-78a6bc6919e9/output/riscv64-linux-gnu/SHA256SUMS.part
abd94f03ba567d40b142f269b28fbea6a9b12bbc387e2a779e904a75da4d4942  guix-build-78a6bc6919e9/output/riscv64-linux-gnu/bitcoin-78a6bc6919e9-riscv64-linux-gnu-debug.tar.gz
390fcdeabffd25b50a5c11b836a07df1724a1d86a829522a540dea8e7eed9e20  guix-build-78a6bc6919e9/output/riscv64-linux-gnu/bitcoin-78a6bc6919e9-riscv64-linux-gnu.tar.gz
a26debb0ef2ad2640d32e1b1c707bdab06b568d88f82f2fe27db32125926b0bd  guix-build-78a6bc6919e9/output/x86_64-apple-darwin19/SHA256SUMS.part
25807653611b16761be456a763044b8e18766ba0735730f02a0512f4ee1fe7cf  guix-build-78a6bc6919e9/output/x86_64-apple-darwin19/bitcoin-78a6bc6919e9-osx-unsigned.dmg
098f9bd57470ddf79fa559c98ac94b9f7367111f1b8ed9398f097d39d659a586  guix-build-78a6bc6919e9/output/x86_64-apple-darwin19/bitcoin-78a6bc6919e9-osx-unsigned.tar.gz
ca2ebf4c1ae845ebe87be70e03f1967077fac1dcfb3b0cfd25add30f695e8c38  guix-build-78a6bc6919e9/output/x86_64-apple-darwin19/bitcoin-78a6bc6919e9-osx64.tar.gz
97df216fe33180fcd5aa7b23e2c95a5036ffe8e2d21cbbca7a2cfd74251f9587  guix-build-78a6bc6919e9/output/x86_64-linux-gnu/SHA256SUMS.part
f91577cff8d69e51b2252ca98cbe44b3873cf516b1220ecc38cc0649bb5eb340  guix-build-78a6bc6919e9/output/x86_64-linux-gnu/bitcoin-78a6bc6919e9-x86_64-linux-gnu-debug.tar.gz
4395fa3d4ce434c3d276cef94b3ee4f6e9736bb2474839b85a30a19f465bd53e  guix-build-78a6bc6919e9/output/x86_64-linux-gnu/bitcoin-78a6bc6919e9-x86_64-linux-gnu.tar.gz
ee6f011732890d672d9a04665415b9d7253c20322a8a2110eda833dd673e70e1  guix-build-78a6bc6919e9/output/x86_64-w64-mingw32/SHA256SUMS.part
e5e840518b738c1ac2541a383fe3b030b5201458a1670b4ef947dc348cc18326  guix-build-78a6bc6919e9/output/x86_64-w64-mingw32/bitcoin-78a6bc6919e9-win-unsigned.tar.gz
18ca2acc783f468bd5c166b429e037543010a868e44fc908208766d63a01dc9a  guix-build-78a6bc6919e9/output/x86_64-w64-mingw32/bitcoin-78a6bc6919e9-win64-debug.zip
3eee8fce1dde9131d66a896af69968f6447264684887e0cf105fc94e2ff2af31  guix-build-78a6bc6919e9/output/x86_64-w64-mingw32/bitcoin-78a6bc6919e9-win64-setup-unsigned.exe
e5debe828ccfdb9854edd2faffd9317c9580e59b725d2c2e2385a3c9f2f2b0f7  guix-build-78a6bc6919e9/output/x86_64-w64-mingw32/bitcoin-78a6bc6919e9-win64.zip

@hebasto
Copy link
Member Author

hebasto commented Dec 7, 2021

cc @icota

@hebasto
Copy link
Member Author

hebasto commented Dec 7, 2021

Guix builds:

$ find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
96196efbfdc520598027dae764c658d1a83c53baaa18322d92e090489385a162  guix-build-78a6bc6919e9/output/aarch64-linux-gnu/SHA256SUMS.part
ba6c89f844da64fb4f32e3ee2dcd82ff182602733db0a3d96c1115d40a8194ae  guix-build-78a6bc6919e9/output/aarch64-linux-gnu/bitcoin-78a6bc6919e9-aarch64-linux-gnu-debug.tar.gz
b7520e12e78618bf1766795f98353c6b17dc6d8a2270c3aa9e5379042a97051d  guix-build-78a6bc6919e9/output/aarch64-linux-gnu/bitcoin-78a6bc6919e9-aarch64-linux-gnu.tar.gz
b15d21e6f34367495096c23e34d728c6309727f429dd8c470487b9c09d256732  guix-build-78a6bc6919e9/output/arm-linux-gnueabihf/SHA256SUMS.part
f41828e0f5afefed56c4964eefeaf890f465941d909a19183c4532adfe261339  guix-build-78a6bc6919e9/output/arm-linux-gnueabihf/bitcoin-78a6bc6919e9-arm-linux-gnueabihf-debug.tar.gz
fd1aebd3278ed264ebc28bd40e5c2d46f36f7ae7199779add3636a66d9aa65c7  guix-build-78a6bc6919e9/output/arm-linux-gnueabihf/bitcoin-78a6bc6919e9-arm-linux-gnueabihf.tar.gz
fc2928a729e01fd9f524670f0bdf6bad49df5baa08481c6060e0b1a7091658cb  guix-build-78a6bc6919e9/output/dist-archive/bitcoin-78a6bc6919e9.tar.gz
aa2b161589560b3f1b636fbc4b4e08fa1257f174ba8df81271bc083e18c16ca5  guix-build-78a6bc6919e9/output/powerpc64-linux-gnu/SHA256SUMS.part
e26c59e60500f4fbd28ed24a2e82e0eae9f3e78ab581badba93559cd986ec072  guix-build-78a6bc6919e9/output/powerpc64-linux-gnu/bitcoin-78a6bc6919e9-powerpc64-linux-gnu-debug.tar.gz
90195a682342cb175b0e969d17e21c226166632be129fb82d01fa007e6fa4ea2  guix-build-78a6bc6919e9/output/powerpc64-linux-gnu/bitcoin-78a6bc6919e9-powerpc64-linux-gnu.tar.gz
3d850bbde65378828b0c6829dcc7fa9ce7516ea98f9843c1a5e761e10c2a08a6  guix-build-78a6bc6919e9/output/powerpc64le-linux-gnu/SHA256SUMS.part
e646c7b7b589b6f30ea57bede54bafa91aac44e1eeffc647cca193309748e703  guix-build-78a6bc6919e9/output/powerpc64le-linux-gnu/bitcoin-78a6bc6919e9-powerpc64le-linux-gnu-debug.tar.gz
f2cdb8773a85a1485582429e42f5192c4ad0755db8c788a149e0c3b1bd8984a4  guix-build-78a6bc6919e9/output/powerpc64le-linux-gnu/bitcoin-78a6bc6919e9-powerpc64le-linux-gnu.tar.gz
2e13a832d050af958dcd9c4e7dd24e47160d4fd2aca6e87cc3a1aad2f683a6af  guix-build-78a6bc6919e9/output/riscv64-linux-gnu/SHA256SUMS.part
abd94f03ba567d40b142f269b28fbea6a9b12bbc387e2a779e904a75da4d4942  guix-build-78a6bc6919e9/output/riscv64-linux-gnu/bitcoin-78a6bc6919e9-riscv64-linux-gnu-debug.tar.gz
390fcdeabffd25b50a5c11b836a07df1724a1d86a829522a540dea8e7eed9e20  guix-build-78a6bc6919e9/output/riscv64-linux-gnu/bitcoin-78a6bc6919e9-riscv64-linux-gnu.tar.gz
a26debb0ef2ad2640d32e1b1c707bdab06b568d88f82f2fe27db32125926b0bd  guix-build-78a6bc6919e9/output/x86_64-apple-darwin19/SHA256SUMS.part
25807653611b16761be456a763044b8e18766ba0735730f02a0512f4ee1fe7cf  guix-build-78a6bc6919e9/output/x86_64-apple-darwin19/bitcoin-78a6bc6919e9-osx-unsigned.dmg
098f9bd57470ddf79fa559c98ac94b9f7367111f1b8ed9398f097d39d659a586  guix-build-78a6bc6919e9/output/x86_64-apple-darwin19/bitcoin-78a6bc6919e9-osx-unsigned.tar.gz
ca2ebf4c1ae845ebe87be70e03f1967077fac1dcfb3b0cfd25add30f695e8c38  guix-build-78a6bc6919e9/output/x86_64-apple-darwin19/bitcoin-78a6bc6919e9-osx64.tar.gz
97df216fe33180fcd5aa7b23e2c95a5036ffe8e2d21cbbca7a2cfd74251f9587  guix-build-78a6bc6919e9/output/x86_64-linux-gnu/SHA256SUMS.part
f91577cff8d69e51b2252ca98cbe44b3873cf516b1220ecc38cc0649bb5eb340  guix-build-78a6bc6919e9/output/x86_64-linux-gnu/bitcoin-78a6bc6919e9-x86_64-linux-gnu-debug.tar.gz
4395fa3d4ce434c3d276cef94b3ee4f6e9736bb2474839b85a30a19f465bd53e  guix-build-78a6bc6919e9/output/x86_64-linux-gnu/bitcoin-78a6bc6919e9-x86_64-linux-gnu.tar.gz
ee6f011732890d672d9a04665415b9d7253c20322a8a2110eda833dd673e70e1  guix-build-78a6bc6919e9/output/x86_64-w64-mingw32/SHA256SUMS.part
e5e840518b738c1ac2541a383fe3b030b5201458a1670b4ef947dc348cc18326  guix-build-78a6bc6919e9/output/x86_64-w64-mingw32/bitcoin-78a6bc6919e9-win-unsigned.tar.gz
18ca2acc783f468bd5c166b429e037543010a868e44fc908208766d63a01dc9a  guix-build-78a6bc6919e9/output/x86_64-w64-mingw32/bitcoin-78a6bc6919e9-win64-debug.zip
3eee8fce1dde9131d66a896af69968f6447264684887e0cf105fc94e2ff2af31  guix-build-78a6bc6919e9/output/x86_64-w64-mingw32/bitcoin-78a6bc6919e9-win64-setup-unsigned.exe
e5debe828ccfdb9854edd2faffd9317c9580e59b725d2c2e2385a3c9f2f2b0f7  guix-build-78a6bc6919e9/output/x86_64-w64-mingw32/bitcoin-78a6bc6919e9-win64.zip

@fanquake fanquake merged commit 6db7e43 into bitcoin:master Dec 7, 2021
@hebasto hebasto deleted the 211204-ndk branch December 7, 2021 11:46
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Dec 7, 2021
RandyMcMillan pushed a commit to RandyMcMillan/mempool-tab that referenced this pull request Dec 23, 2021
8f2bbb0 build, qt: Use Android NDK r23 LTS (Hennadii Stepanov)

Pull request description:

  This is a continuation of bitcoin/bitcoin#23478, and, thanks to bitcoin/bitcoin#23489, a oneline patch is only required to be able build the `qt` package in depends with Android NDK r23 LTS.

ACKs for top commit:
  fanquake:
    ACK 8f2bbb0

Tree-SHA512: 09c6e8739ecbcbf5fdd6c2103577be2676eb448941f97c781f476918056c8405d2531d5cef8f240e4d1205c2d49f879edbba74dd5e77799a887b76a5c76ebe5b
@bitcoin bitcoin locked and limited conversation to collaborators Dec 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants