Add external signer taproot support #23578
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
This was referenced Nov 23, 2021
2467086 to
5095a60
Compare
This was referenced Jan 24, 2022
16 tasks
|
Rebased, but won't work yet. |
7bb5846 to
cfa4d41
Compare
|
Updated the external signer code to also look for fingerprints in |
cfa4d41 to
08abaa6
Compare
08abaa6 to
9b9e4e7
Compare
9b9e4e7 to
796b020
Compare
|
Hooray, #22558 was merged, so this is now just one commit on top of master. |
|
utACK 796b020 |
This was referenced Sep 6, 2022
|
ACK 796b020 |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Oct 27, 2022
796b020 wallet: add taproot support to external signer (Sjors Provoost) Pull request description: Builds on bitcoin#22558 (merged on 2022-06-28). [HWI 2.1.0](https://github.com/bitcoin-core/HWI/releases/tag/2.1.0) or newer is required to import and use taproot descriptors. Older versions will work, but won't import a taproot descriptor. Tested with HWI 2.1.1: * Trezor T (firmware v2.5.1) on Signet: signs, change detection works * Ledger Nano S (firmware 2.1.0, Bitcoin app 2.0.6): signs, change detection works Only the most basic `tr(key)` descriptor is supported, script path spending is completely untested (if it works at all). ACKs for top commit: jb55: utACK 796b020 achow101: ACK 796b020 Tree-SHA512: 6dcb7eeb45421a3bbf2bdabeacd29979867db69077d7bf192bb77faa4bfefe446487b8df07bc40f9457009a88e598bdc09f769e6106fed2833ace7ef205a157a
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #22558 (merged on 2022-06-28).
HWI 2.1.0 or newer is required to import and use taproot descriptors. Older versions will work, but won't import a taproot descriptor.
Tested with HWI 2.1.1:
Only the most basic
tr(key)descriptor is supported, script path spending is completely untested (if it works at all).