Skip to content

Conversation

luke-jr
Copy link
Member

@luke-jr luke-jr commented Nov 18, 2021

Fixes a regression introduced by #22722

(Not entirely sure on the solution)

@maflcko maflcko added this to the 23.0 milestone Nov 18, 2021
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

crACK cd8d156

@benthecarman
Copy link
Contributor

maybe worth for 22.1

@maflcko maflcko removed the Mining label Nov 25, 2021
Copy link
Member

@darosior darosior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arf, good catch..

utACK cd8d156

Copy link
Contributor

@kristapsk kristapsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK cd8d156

@maflcko maflcko merged commit 084c81c into bitcoin:master Dec 7, 2021
@maflcko
Copy link
Member

maflcko commented Dec 7, 2021

A regression test might be nice

sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Dec 7, 2021
…rtfee if smart fee data is unavailable

cd8d156 Bugfix: RPC/mining: Fail properly in estimatesmartfee if smart fee data is unavailable (Luke Dashjr)

Pull request description:

  Fixes a regression introduced by bitcoin#22722

  (Not entirely sure on the solution)

ACKs for top commit:
  prayank23:
    crACK bitcoin@cd8d156
  darosior:
    utACK cd8d156
  kristapsk:
    utACK cd8d156

Tree-SHA512: eb4aa3cc345c69c44ffd5733b51b90eefe1d7854b7a2855e8cbb98268db24d43b7d0ae9fbb0eccf9b6dc01da644d19433cc77fec52ff67bf890be1fc53a67fc4
luke-jr added a commit to bitcoinknots/bitcoin that referenced this pull request Dec 14, 2021
RandyMcMillan pushed a commit to RandyMcMillan/mempool-tab that referenced this pull request Dec 23, 2021
…imatesmartfee if smart fee data is unavailable

9ed340f Bugfix: RPC/mining: Fail properly in estimatesmartfee if smart fee data is unavailable (Luke Dashjr)

Pull request description:

  Fixes a regression introduced by #22722

  (Not entirely sure on the solution)

ACKs for top commit:
  prayank23:
    crACK bitcoin/bitcoin@9ed340f
  darosior:
    utACK 9ed340f
  kristapsk:
    utACK 9ed340f

Tree-SHA512: eb4aa3cc345c69c44ffd5733b51b90eefe1d7854b7a2855e8cbb98268db24d43b7d0ae9fbb0eccf9b6dc01da644d19433cc77fec52ff67bf890be1fc53a67fc4
@bitcoin bitcoin locked and limited conversation to collaborators Dec 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants