Skip to content

ci: Drop --failfast in functional tests on native Windows CI task #23513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 15, 2021
Merged

ci: Drop --failfast in functional tests on native Windows CI task #23513

merged 1 commit into from
Nov 15, 2021

Conversation

hebasto
Copy link
Member

@hebasto hebasto commented Nov 15, 2021

As it was discussed in #22980:

seeing all of the failed tests can give us a useful hint for debugging (was thinking about that while reviewing and testing #23300).

There is a concern about such approach:

If there is a CI failure, it will be good to know the result as early as possible after opening the pull request.

But, OTOH:

the average amount of saved time for such an approach [using --failfast] is less significant than it could appear.

@maflcko
Copy link
Member

maflcko commented Nov 15, 2021

cr ACK 23c3dcb seems fine to give this a try

I haven't measured at how much time is saved or wasted, but it seems likely subjective anyway. This will save people from complaining about issue #23085. Also, it might help debugging.

Can be reverted any time, if it turns out this didn't help.

@DrahtBot DrahtBot added the Tests label Nov 15, 2021
@maflcko maflcko mentioned this pull request Nov 15, 2021
Closed
@maflcko maflcko merged commit 15d1098 into bitcoin:master Nov 15, 2021
@katesalazar
Copy link
Contributor

Concept ACK, suggest not to enable back again.

IMO failfast is for developing on humble local setups and
gives no real advantage used in CI.

sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Nov 16, 2021
Merge bitcoin#23513: ci: Drop --failfast in functional tests on nativ…
c0d1f21 
…e Windo…
@hebasto hebasto deleted the 211115-ff branch November 16, 2021 10:36
@bitcoin bitcoin locked and limited conversation to collaborators Nov 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hebasto @maflcko @katesalazar @DrahtBot