Fix intermittent failure in wallet_send.py and rpc_fundrawtransaction.py #23200
Conversation
|
|
|
Added |
|
ACK 6b1b715 The lack of |
|
ACK 75a9305 |
|
the idea being block processing hasn't finished before the wallet calls are used, even though it's on the same node? |
It is for the benefit of the other node, using the input externally. For example, in |
| @@ -1010,7 +1010,8 @@ def test_external_inputs(self): | |||
|
|
|||
| self.nodes[0].sendtoaddress(addr, 10) | |||
| self.nodes[0].sendtoaddress(wallet.getnewaddress(), 10) | |||
| self.nodes[0].generate(6) | |||
| self.generate(self.nodes[0], 6) | |||
| self.sync_all() | |||
There was a problem hiding this comment.
slight preference for syncing right before the other wallet call rather than sandwiched between nodes[0] calls. This makes spotting gaps easier in the future.
There was a problem hiding this comment.
@instagibbs #22567 will merge these sync_all into the generate calls, so it makes sense to put them together for clarity at the moment IMO
There was a problem hiding this comment.
@instagibbs PR #22741 has more information about the generate* calls
|
Got it.
…On Wed, Oct 6, 2021, 9:34 AM Samuel Dobson ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In test/functional/rpc_fundrawtransaction.py
<#23200 (comment)>:
> @@ -1010,7 +1010,8 @@ def test_external_inputs(self):
self.nodes[0].sendtoaddress(addr, 10)
self.nodes[0].sendtoaddress(wallet.getnewaddress(), 10)
- self.nodes[0].generate(6)
+ self.generate(self.nodes[0], 6)
+ self.sync_all()
@instagibbs <https://github.com/instagibbs> #22567
<#22567> will merge these sync_all
into the generate calls, so it makes sense to put them together for
clarity at the moment IMO
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#23200 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABMAFUZQBXYMSLETRSZI6RDUFORS3ANCNFSM5FM4JY4Q>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
…pc_fundrawtransaction.py 75a9305 Fix intermittent test failures due to missing sync_all (Samuel Dobson) eb02dbb Use self.generate not node.generate throughout tests (Samuel Dobson) Pull request description: After bitcoin#17211 was merged, there have been a few intermittent test failures in `wallet_send.py`, `rpc_fundrawtransaction.py`, and `rpc_psbt.py` I believe all these failures are due to these missing `sync_all()`s ACKs for top commit: achow101: ACK 75a9305 lsilva01: Tested ACK bitcoin@75a9305 on Ubuntu 20.04 Tree-SHA512: 91de5763664046e5a35802eb1a9a28f69a1a27d78d26c9fa0024bcfab4ccb4b7ad4feebea7de4b19e141db9c39270c623c57c47942a48dfe679fdc8cad70df43
After #17211 was merged, there have been a few intermittent test failures in
wallet_send.py,rpc_fundrawtransaction.py, andrpc_psbt.pyI believe all these failures are due to these missing
sync_all()s