Skip to content

test: Add txindex migration test #23046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 15, 2021
Merged

test: Add txindex migration test #23046

merged 1 commit into from
Nov 15, 2021

Conversation

maflcko
Copy link
Member

@maflcko maflcko commented Sep 20, 2021

Test for #22626

@maflcko maflcko force-pushed the 2109-txindexMigrate branch from 4a1db6f to fae339b Compare September 20, 2021 12:26
@fanquake fanquake added the Tests label Sep 20, 2021
@maflcko maflcko force-pushed the 2109-txindexMigrate branch from fae339b to fafecc9 Compare September 20, 2021 14:46
@theStack
Copy link
Contributor

Concept ACK

1 similar comment
@dunxen
Copy link
Contributor

dunxen commented Sep 25, 2021

Concept ACK

@practicalswift
Copy link
Contributor

Concept ACK (obviously :))

@maflcko maflcko force-pushed the 2109-txindexMigrate branch from fafecc9 to fadc4c7 Compare November 9, 2021 11:06
@maflcko
Copy link
Member Author

maflcko commented Nov 9, 2021

Removed now-redundant sync_all.

theStack
theStack approved these changes Nov 10, 2021
View reviewed changes
Copy link
Contributor

@theStack theStack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ACK fadc4c7 🌁
(code-reviewed test, ran it under Debian bookworm/sid, with downloaded binary previous releases v0.16.3 and v0.20.1)

@maflcko maflcko merged commit 41a1b5f into bitcoin:master Nov 15, 2021
@maflcko maflcko deleted the 2109-txindexMigrate branch November 15, 2021 09:05
@hebasto
Copy link
Member

hebasto commented Nov 15, 2021

See #23514.

sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Nov 15, 2021
Merge bitcoin#23046: test: Add txindex migration test
a79ed4f 
fadc4c7 test: Add txindex migration test (MarcoFalke)

Pull request description:

  Test for bitcoin#22626

ACKs for top commit:
  theStack:
    Tested ACK fadc4c7 🌁

Tree-SHA512: fc7133ef52826bf0d4fa2ac72c3f1bed4a185ff7492396552ff2cbf6531b053238039211a710cbb949379c56875cd7715f1ed49a514dd3b3f1b46554e3d4bef5
@bitcoin bitcoin locked and limited conversation to collaborators Nov 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@theStack theStack theStack approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@maflcko @theStack @dunxen @practicalswift @hebasto @fanquake