multiprocess: Add new bitcoin-gui, bitcoin-qt, bitcoin-wallet init implementations #23006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…plementations Add separate init implementations instead of sharing existing bitcoind and bitcoin-node ones, so they can start to be differentiated in upcoming commits with node and wallet code no longer linked into the bitcoin-gui binary and wallet code no longer linked into the bitcoin-node binary.
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
This was referenced Sep 18, 2021
|
Concept ACK. |
2d3d624 to
d5f985e
Compare
ryanofsky
commented
Oct 25, 2021
There was a problem hiding this comment.
Thanks for reviews!
Updated 2d3d624 -> d5f985e (pr/ipc-init.1 -> pr/ipc-init.2, compare) with suggestions
lsilva01
approved these changes
Oct 25, 2021
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Oct 26, 2021
…yscoin-wallet init implementations
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add separate
interfaces::Initsubclasses forbitcoin-wallet,bitcoin-gui, andbitcoin-qtbinaries instead of sharingbitcoindandbitcoin-nodeinit subclasses in different binaries. After this, the new init subclasses can be customized in #10102, so node and wallet code is dropped from thebitcoin-guibinary and wallet code is dropped from into thebitcoin-nodebinary.This PR is part of the process separation project.