multiprocess: Delay wallet client construction #23005
Merged
+23
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Delay wallet client construction until after logging, thread and other init for two reasons: - More responsive multiprocess GUI startup. When bitcoin-gui is started this moves the call from bitcoin-gui to bitcoin-node that spawns bitcoin-wallet off of the GUI event thread and onto the background GUI init executor thread. - Avoids feature_logging.py test failures with bitcoin-node by making bitcoin-wallet logging start after bitcoin-node logging starts, because the tests are not written to handle the bitcoin-wallet logging init code running first. This partially reverts commit b266b3e, moving wallet client creation back to the place it was located before.
ca0704c to
ad085f9
Compare
|
Updated ca0704c -> ad085f9 ( |
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsNo conflicts as of last run. |
This was referenced Sep 18, 2021
|
code review ACK ad085f9 |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Nov 16, 2021
maflcko
reviewed
Nov 16, 2021
| @@ -82,6 +82,9 @@ class CClientUIInterface | |||
| /** Progress message during initialization. */ | |||
| ADD_SIGNALS_DECL_WRAPPER(InitMessage, void, const std::string& message); | |||
|
|
|||
| /** Wallet client created. */ | |||
| ADD_SIGNALS_DECL_WRAPPER(InitWallet, void, ); | |||
There was a problem hiding this comment.
any reason for the trailing comma?
There was a problem hiding this comment.
any reason for the trailing comma?
This is to fix the clang warning ./node/ui_interface.h:86:46: error: must specify at least one argument for '...' parameter of variadic macro [-Werror,-Wgnu-zero-variadic-macro-arguments] ADD_SIGNALS_DECL_WRAPPER(InitWallet, void); https://cirrus-ci.com/task/6303923532201984
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delay wallet client construction until after logging, thread and other init for two reasons:
More responsive multiprocess GUI startup. When bitcoin-gui is started this moves the call from bitcoin-gui to bitcoin-node that spawns bitcoin-wallet off of the GUI event thread and onto the background GUI init executor thread.
Avoids feature_logging.py test failures with bitcoin-node by making bitcoin-wallet logging start after bitcoin-node logging starts,
because the tests are not written to handle the bitcoin-wallet logging init code running first.
This partially reverts commit b266b3e, moving wallet client creation back to the place it was located before.
This PR is part of the process separation project.