[net] Minor cleanups to asmap #22911
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This data member was introduced in ec45646 but never used.
SanityCheckASMap(asmap, bits) simply calls through to SanityCheckASMap(asmap) in util/asmap. Update all callers to simply call that function.
DecopeAsmap is a pure utility function and doesn't have any dependencies on addrman, so move it to util/asmap. Reviewer hint: use: `git diff --color-moved=dimmed-zebra --color-moved-ws=ignore-all-space`
This saves passing around a reference to the asmap std::vector<bool>.
|
Concept ACK |
|
ACK 853c4ed |
|
Concept ACK |
fanquake
approved these changes
Sep 10, 2021
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Sep 11, 2021
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Jan 10, 2022
Summary: This data member was introduced in ec45646de9e but never used. This is a backport of [[bitcoin/bitcoin#22911 | core#22911]] [1/4] bitcoin/bitcoin@07a9ecc Test Plan: `ninja all check-all` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D10779
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Jan 10, 2022
Summary: SanityCheckASMap(asmap, bits) simply calls through to SanityCheckASMap(asmap) in util/asmap. Update all callers to simply call that function. This is a backport of [[bitcoin/bitcoin#22911 | core#22911]] [2/4] bitcoin/bitcoin@bfdf4ef Depends on D10779 Test Plan: `ninja all check-all` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D10780
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Jan 10, 2022
Summary: DecopeAsmap is a pure utility function and doesn't have any dependencies on addrman, so move it to util/asmap. Reviewer hint: use: `git diff --color-moved=dimmed-zebra --color-moved-ws=ignore-all-space` This is a backport of [[bitcoin/bitcoin#22911 | core#22911]] [3/4] bitcoin/bitcoin@9fd5618 Depends on D10780 Test Plan: `ninja all check-all` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D10781
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Jan 10, 2022
Summary: This saves passing around a reference to the asmap std::vector<bool>. This is a backport of [[bitcoin/bitcoin#22911 | core#22911]] [4/4] bitcoin/bitcoin@853c4ed Depends on D10781 Test Plan: `ninja all check-all` Compile and run the fuzzer: ``` cmake -GNinja .. -DCMAKE_C_COMPILER=$AFLPATH/afl-clang -DCMAKE_CXX_COMPILER=$AFLPATH/afl-clang++ ninja bitcoin-fuzzers AFL_I_DONT_CARE_ABOUT_MISSING_CRASHES=1 AFL_SKIP_CPUFREQ=1 ${AFLPATH}/afl-fuzz -i ${DIR_FUZZ_IN}/net -o ${AFLOUT}/net -m250 -- src/test/fuzz/net ``` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Subscribers: Fabien Differential Revision: https://reviews.bitcoinabc.org/D10782
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These small cleanups to the asmap code are the first 4 commits from #22910. They're minor improvements that are independently useful whether or not 22910 is merged.