Skip to content

ci: Enable the gui in the tsan build #22815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 30, 2021
Merged

ci: Enable the gui in the tsan build #22815

merged 1 commit into from
Dec 30, 2021

Conversation

hebasto
Copy link
Member

@hebasto hebasto commented Aug 27, 2021 •
edited
Loading

This PR is a reincarnation of #19162.

@hebasto hebasto mentioned this pull request Aug 27, 2021
Closed
@hebasto hebasto added the Tests label Aug 27, 2021
laanwj
laanwj reviewed Aug 27, 2021
View reviewed changes
@hebasto hebasto mentioned this pull request Aug 27, 2021
Merged
@practicalswift
Copy link
Contributor

Strong Concept ACK

@hebasto hebasto mentioned this pull request Sep 25, 2021
Merged
fanquake added a commit that referenced this pull request Dec 30, 2021
@fanquake
Merge #22814: build: Add ability to build qt in depends with -stdlib=…
de28c34 
…libc++

33796a9 build: Add ability to build qt in depends with -stdlib=libc++ (Hennadii Stepanov)

Pull request description:

  This PR makes possible to build the `qt` package in depends against `libc++` for x86_64 platform.

  Fixes #22344.

  Required for #22815.

  Also this PR [fixes](#23060 (comment)) the `[no wallet] [bionic]` task on CI:
  - on master (a8bbd4c), https://api.cirrus-ci.com/v1/task/5558609250615296/logs/ci.log:
  ```
  Options used to compile and link:
    external signer = yes
    multiprocess    = no
    with libs       = yes
    with wallet     = no
    with gui / qt   = no
  ```
  - this PR, https://api.cirrus-ci.com/v1/task/5502605561430016/logs/ci.log:
  ```
  Options used to compile and link:
    external signer = yes
    multiprocess    = no
    with libs       = yes
    with wallet     = no
    with gui / qt   = yes
  ```

ACKs for top commit:
  fanquake:
    ACK 33796a9 - While this sort of string matching is fragile, I think the risk of this causing any actual issues is low.

Tree-SHA512: 586dde2e9864cec7a49aeb4f2b77fb8c4ae96bd10b51f9c6de0cfe8512ad61db15bb7f8d1b0eb6a5a66fd2deee52ac52218f01eb6be107ac12f1a956190de54b
@fanquake
Copy link
Member

Please rebase this on master.

sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Dec 30, 2021
@fanquake
Merge bitcoin#22814: build: Add ability to build qt in depends with -…
4975b13 
…stdlib=libc++

33796a9 build: Add ability to build qt in depends with -stdlib=libc++ (Hennadii Stepanov)

Pull request description:

  This PR makes possible to build the `qt` package in depends against `libc++` for x86_64 platform.

  Fixes bitcoin#22344.

  Required for bitcoin#22815.

  Also this PR [fixes](bitcoin#23060 (comment)) the `[no wallet] [bionic]` task on CI:
  - on master (a8bbd4c), https://api.cirrus-ci.com/v1/task/5558609250615296/logs/ci.log:
  ```
  Options used to compile and link:
    external signer = yes
    multiprocess    = no
    with libs       = yes
    with wallet     = no
    with gui / qt   = no
  ```
  - this PR, https://api.cirrus-ci.com/v1/task/5502605561430016/logs/ci.log:
  ```
  Options used to compile and link:
    external signer = yes
    multiprocess    = no
    with libs       = yes
    with wallet     = no
    with gui / qt   = yes
  ```

ACKs for top commit:
  fanquake:
    ACK 33796a9 - While this sort of string matching is fragile, I think the risk of this causing any actual issues is low.

Tree-SHA512: 586dde2e9864cec7a49aeb4f2b77fb8c4ae96bd10b51f9c6de0cfe8512ad61db15bb7f8d1b0eb6a5a66fd2deee52ac52218f01eb6be107ac12f1a956190de54b
@hebasto
Copy link
Member Author

hebasto commented Dec 30, 2021

Please rebase this on master.

Rebased.

@maflcko
Copy link
Member

maflcko commented Dec 30, 2021

review ACK ec7b7d4

@maflcko maflcko merged commit 5d91133 into bitcoin:master Dec 30, 2021
@hebasto hebasto deleted the 210827-tsan branch December 30, 2021 11:26
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Dec 30, 2021
Merge bitcoin#22815: ci: Enable the gui in the tsan build
ec6f673
hebasto added a commit to hebasto/bitcoin that referenced this pull request Jan 3, 2022
@hebasto
ci: Update Cirrus CI task name
d04f68d 
Missed in bitcoin#22815.
@hebasto hebasto mentioned this pull request Jan 3, 2022
Merged
fanquake added a commit to bitcoin-core/gui that referenced this pull request Jan 4, 2022
@fanquake
Merge bitcoin/bitcoin#23959: ci: Update Cirrus CI task name
db5f441 
d04f68d ci: Update Cirrus CI task name (Hennadii Stepanov)

Pull request description:

  Missed in bitcoin/bitcoin#22815.

ACKs for top commit:
  fanquake:
    ACK d04f68d

Tree-SHA512: 8c5d4b4ab6967e8ab2f3630216d33297e533eda0bd9e83dd3c8f5b9952bc0865b04af5f4398a3357135d81be99d483864ec710eeb89a149a61e258e92d680a76
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Jan 4, 2022
@fanquake
Merge bitcoin#23959: ci: Update Cirrus CI task name
b7a0fce 
d04f68d ci: Update Cirrus CI task name (Hennadii Stepanov)

Pull request description:

  Missed in bitcoin#22815.

ACKs for top commit:
  fanquake:
    ACK d04f68d

Tree-SHA512: 8c5d4b4ab6967e8ab2f3630216d33297e533eda0bd9e83dd3c8f5b9952bc0865b04af5f4398a3357135d81be99d483864ec710eeb89a149a61e258e92d680a76
mzumsande pushed a commit to mzumsande/bitcoin that referenced this pull request Jan 17, 2022
@hebasto @mzumsande
ci: Update Cirrus CI task name
dc7c357 
Missed in bitcoin#22815.
rebroad pushed a commit to rebroad/bitcoin that referenced this pull request Feb 3, 2022
@hebasto @rebroad
ci: Update Cirrus CI task name
6d2e0e2 
Missed in bitcoin#22815.
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Apr 7, 2022
@fanquake @PastaPastaPasta
Merge bitcoin#22814: build: Add ability to build qt in depends with -…
86c0067 
…stdlib=libc++

33796a9 build: Add ability to build qt in depends with -stdlib=libc++ (Hennadii Stepanov)

Pull request description:

  This PR makes possible to build the `qt` package in depends against `libc++` for x86_64 platform.

  Fixes bitcoin#22344.

  Required for bitcoin#22815.

  Also this PR [fixes](bitcoin#23060 (comment)) the `[no wallet] [bionic]` task on CI:
  - on master (a8bbd4c), https://api.cirrus-ci.com/v1/task/5558609250615296/logs/ci.log:
  ```
  Options used to compile and link:
    external signer = yes
    multiprocess    = no
    with libs       = yes
    with wallet     = no
    with gui / qt   = no
  ```
  - this PR, https://api.cirrus-ci.com/v1/task/5502605561430016/logs/ci.log:
  ```
  Options used to compile and link:
    external signer = yes
    multiprocess    = no
    with libs       = yes
    with wallet     = no
    with gui / qt   = yes
  ```

ACKs for top commit:
  fanquake:
    ACK 33796a9 - While this sort of string matching is fragile, I think the risk of this causing any actual issues is low.

Tree-SHA512: 586dde2e9864cec7a49aeb4f2b77fb8c4ae96bd10b51f9c6de0cfe8512ad61db15bb7f8d1b0eb6a5a66fd2deee52ac52218f01eb6be107ac12f1a956190de54b
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Apr 11, 2022
@fanquake @PastaPastaPasta
Merge bitcoin#22814: build: Add ability to build qt in depends with -…
015034a 
…stdlib=libc++

33796a9 build: Add ability to build qt in depends with -stdlib=libc++ (Hennadii Stepanov)

Pull request description:

  This PR makes possible to build the `qt` package in depends against `libc++` for x86_64 platform.

  Fixes bitcoin#22344.

  Required for bitcoin#22815.

  Also this PR [fixes](bitcoin#23060 (comment)) the `[no wallet] [bionic]` task on CI:
  - on master (a8bbd4c), https://api.cirrus-ci.com/v1/task/5558609250615296/logs/ci.log:
  ```
  Options used to compile and link:
    external signer = yes
    multiprocess    = no
    with libs       = yes
    with wallet     = no
    with gui / qt   = no
  ```
  - this PR, https://api.cirrus-ci.com/v1/task/5502605561430016/logs/ci.log:
  ```
  Options used to compile and link:
    external signer = yes
    multiprocess    = no
    with libs       = yes
    with wallet     = no
    with gui / qt   = yes
  ```

ACKs for top commit:
  fanquake:
    ACK 33796a9 - While this sort of string matching is fragile, I think the risk of this causing any actual issues is low.

Tree-SHA512: 586dde2e9864cec7a49aeb4f2b77fb8c4ae96bd10b51f9c6de0cfe8512ad61db15bb7f8d1b0eb6a5a66fd2deee52ac52218f01eb6be107ac12f1a956190de54b
gades pushed a commit to cosanta/cosanta-core that referenced this pull request May 12, 2022
@fanquake @gades
Merge bitcoin#22814: build: Add ability to build qt in depends with -…
5031959 
…stdlib=libc++

33796a9 build: Add ability to build qt in depends with -stdlib=libc++ (Hennadii Stepanov)

Pull request description:

  This PR makes possible to build the `qt` package in depends against `libc++` for x86_64 platform.

  Fixes bitcoin#22344.

  Required for bitcoin#22815.

  Also this PR [fixes](bitcoin#23060 (comment)) the `[no wallet] [bionic]` task on CI:
  - on master (a8bbd4c), https://api.cirrus-ci.com/v1/task/5558609250615296/logs/ci.log:
  ```
  Options used to compile and link:
    external signer = yes
    multiprocess    = no
    with libs       = yes
    with wallet     = no
    with gui / qt   = no
  ```
  - this PR, https://api.cirrus-ci.com/v1/task/5502605561430016/logs/ci.log:
  ```
  Options used to compile and link:
    external signer = yes
    multiprocess    = no
    with libs       = yes
    with wallet     = no
    with gui / qt   = yes
  ```

ACKs for top commit:
  fanquake:
    ACK 33796a9 - While this sort of string matching is fragile, I think the risk of this causing any actual issues is low.

Tree-SHA512: 586dde2e9864cec7a49aeb4f2b77fb8c4ae96bd10b51f9c6de0cfe8512ad61db15bb7f8d1b0eb6a5a66fd2deee52ac52218f01eb6be107ac12f1a956190de54b
janus pushed a commit to BitgesellOfficial/bitgesell that referenced this pull request Jul 10, 2022
@hebasto @janus
ci: Update Cirrus CI task name
ac200f8 
Missed in bitcoin/bitcoin#22815.
@bitcoin bitcoin locked and limited conversation to collaborators Dec 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@laanwj laanwj laanwj left review comments

Assignees
No one assigned
Labels
Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hebasto @practicalswift @fanquake @maflcko @laanwj