Skip to content

net: use m_client_interface rather than uiInterface #22732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 18, 2021
Merged

net: use m_client_interface rather than uiInterface #22732

merged 2 commits into from
Aug 18, 2021

Conversation

fanquake
Copy link
Member

First commit fixes two cases where we were using uiInterface, rather than clientInterface.
Second commit renames clientInterface to m_client_interface, to match banman.

maflcko
maflcko reviewed Aug 18, 2021
View reviewed changes
@fanquake
net: use clientInterface rather than uiInterface
f68c6ce
@fanquake
scripted-diff: replace clientInterface with m_client_interface in net
d8ba632 
-BEGIN VERIFY SCRIPT-

sed -i -e "s/clientInterface/m_client_interface/g" src/net.cpp src/net.h

-END VERIFY SCRIPT-
@fanquake fanquake force-pushed the use_uiinterface_in_net branch from e378c66 to d8ba632 Compare August 18, 2021 05:55
@DrahtBot DrahtBot added the P2P label Aug 18, 2021
hebasto
hebasto approved these changes Aug 18, 2021
View reviewed changes
Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK d8ba632, verified that uiInterface is replaced in all sites.

Zero-1729
Zero-1729 reviewed Aug 18, 2021
View reviewed changes
Copy link
Contributor

@Zero-1729 Zero-1729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

crACK d8ba632

@fanquake fanquake merged commit e35c4a3 into bitcoin:master Aug 18, 2021
@fanquake fanquake deleted the use_uiinterface_in_net branch August 18, 2021 12:13
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Aug 20, 2021
@fanquake
Merge bitcoin#22732: net: use m_client_interface rather than uiInterface
f621dfd
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hebasto hebasto hebasto approved these changes

+2 more reviewers

@maflcko maflcko maflcko left review comments

@Zero-1729 Zero-1729 Zero-1729 left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
P2P
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fanquake @maflcko @Zero-1729 @hebasto @DrahtBot