[DO NOT MERGE, DEMO] [22.0] ci: Run fuzz tests for the master branch only #22731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
83d7d23 to
e9a7f93
Compare
|
Updated according to #22730 (comment). |
c68e614 to
63c6315
Compare
63c6315 to
085b678
Compare
fanquake
added a commit
that referenced
this pull request
Aug 20, 2021
5a9e255 ci: Run fuzzer task for the master branch only (Hennadii Stepanov) Pull request description: #22629 (comment): > I think we need to decide whether running the fuzzer CI in any branch other than master is something we want to be doing / maintaining. This seems pretty unsustainable unless we at least make changes in regards to the fuzz inputs being used by the different branches. I'm pretty sure Marco has mentioned this before. This PR makes CI ignore fuzz tests by forcing `RUN_FUZZ_TESTS=false` for all cases when it is not the master branch or a PR based on it. See #22731 as a demo for the 22.x branch. ACKs for top commit: MarcoFalke: cr ACK 5a9e255 no opinion on the concept, also didn't test fanquake: ACK 5a9e255 - didn't test other than to look at #22731. Tree-SHA512: 48f8f02f1814d4f15293a8804b76d544a08784ea7acd930b5c6d4608564d30aa5a608b1a511386ffda6975feec700c1bbeb86a30a75a7e48a1c5b167a227dbdd
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Aug 20, 2021
5a9e255 ci: Run fuzzer task for the master branch only (Hennadii Stepanov) Pull request description: bitcoin#22629 (comment): > I think we need to decide whether running the fuzzer CI in any branch other than master is something we want to be doing / maintaining. This seems pretty unsustainable unless we at least make changes in regards to the fuzz inputs being used by the different branches. I'm pretty sure Marco has mentioned this before. This PR makes CI ignore fuzz tests by forcing `RUN_FUZZ_TESTS=false` for all cases when it is not the master branch or a PR based on it. See bitcoin#22731 as a demo for the 22.x branch. ACKs for top commit: MarcoFalke: cr ACK 5a9e255 no opinion on the concept, also didn't test fanquake: ACK 5a9e255 - didn't test other than to look at bitcoin#22731. Tree-SHA512: 48f8f02f1814d4f15293a8804b76d544a08784ea7acd930b5c6d4608564d30aa5a608b1a511386ffda6975feec700c1bbeb86a30a75a7e48a1c5b167a227dbdd
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is a demo for #22730 in the 22.x branch. Fuzz tests must not run here.