-
Notifications
You must be signed in to change notification settings - Fork 37.7k
test: Add temporary sanitizer suppression implicit-signed-integer-truncation:netaddress.cpp #22584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ncation:netaddress.cpp
cr ACK fa86528 |
ACK Potentially a fix in #22586. |
lsilva01
approved these changes
Jul 30, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK fa86528
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Aug 1, 2021
…it-signed-integer-truncation:netaddress.cpp fa86528 test: Add temporary sanitizer suppression implicit-signed-integer-truncation:netaddress.cpp (MarcoFalke) Pull request description: This is required to unbreak the fuzzers while a fix is being worked on. https://cirrus-ci.com/task/4787303177519104?logs=ci#L3020 ``` netaddress.cpp:1190:18: runtime error: implicit conversion from type 'int' of value -1 (32-bit, signed) to type 'uint8_t' (aka 'unsigned char') changed the value to 255 (8-bit, unsigned) ACKs for top commit: practicalswift: cr ACK fa86528 tryphe: untested ACK fa86528 lsilva01: ACK bitcoin@fa86528 Tree-SHA512: 4a54ec68c014c7a4c9ab268c3a04321db5eb9b2857646b41406d8d4908a3d349848b4549e80aea6afd9a0c3639522a48fe578527139519b12439eae9f0c4c46c
Merged
hebasto
pushed a commit
to hebasto/bitcoin
that referenced
this pull request
Aug 6, 2021
…ncation:netaddress.cpp Github-Pull: bitcoin#22584 Rebased-From: fa86528
UPDATE: #22629 (comment) |
hebasto
pushed a commit
to hebasto/bitcoin
that referenced
this pull request
Aug 6, 2021
…ncation:netaddress.cpp Github-Pull: bitcoin#22584 Rebased-From: fa86528
hebasto
pushed a commit
to hebasto/bitcoin
that referenced
this pull request
Aug 6, 2021
…ncation:netaddress.cpp Github-Pull: bitcoin#22584 Rebased-From: fa86528
hebasto
pushed a commit
to hebasto/bitcoin
that referenced
this pull request
Aug 7, 2021
…ncation:netaddress.cpp Github-Pull: bitcoin#22584 Rebased-From: fa86528
hebasto
pushed a commit
to hebasto/bitcoin
that referenced
this pull request
Aug 9, 2021
…ncation:netaddress.cpp Github-Pull: bitcoin#22584 Rebased-From: fa86528
hebasto
pushed a commit
to hebasto/bitcoin
that referenced
this pull request
Aug 9, 2021
…ncation:netaddress.cpp Github-Pull: bitcoin#22584 Rebased-From: fa86528
hebasto
pushed a commit
to hebasto/bitcoin
that referenced
this pull request
Aug 19, 2021
…ncation:netaddress.cpp Github-Pull: bitcoin#22584 Rebased-From: fa86528
hebasto
pushed a commit
to hebasto/bitcoin
that referenced
this pull request
Aug 20, 2021
…ncation:netaddress.cpp Github-Pull: bitcoin#22584 Rebased-From: fa86528
hebasto
pushed a commit
to hebasto/bitcoin
that referenced
this pull request
Aug 20, 2021
…ncation:netaddress.cpp Github-Pull: bitcoin#22584 Rebased-From: fa86528
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required to unbreak the fuzzers while a fix is being worked on.
https://cirrus-ci.com/task/4787303177519104?logs=ci#L3020