Skip to content

Conversation

maflcko
Copy link
Member

@maflcko maflcko commented Jul 29, 2021

This is required to unbreak the fuzzers while a fix is being worked on.

https://cirrus-ci.com/task/4787303177519104?logs=ci#L3020

netaddress.cpp:1190:18: runtime error: implicit conversion from type 'int' of value -1 (32-bit, signed) to type 'uint8_t' (aka 'unsigned char') changed the value to 255 (8-bit, unsigned)

@DrahtBot DrahtBot added the Tests label Jul 29, 2021
@practicalswift
Copy link
Contributor

cr ACK fa86528

@jonatack
Copy link
Member

ACK

Potentially a fix in #22586.

@tryphe
Copy link
Contributor

tryphe commented Jul 29, 2021

untested ACK fa86528

Prefer #22586

Copy link
Contributor

@lsilva01 lsilva01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK fa86528

@maflcko maflcko merged commit 9c9939c into bitcoin:master Jul 30, 2021
@maflcko maflcko deleted the 2107-testSupp branch July 30, 2021 06:32
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Aug 1, 2021
…it-signed-integer-truncation:netaddress.cpp

fa86528 test: Add temporary sanitizer suppression implicit-signed-integer-truncation:netaddress.cpp (MarcoFalke)

Pull request description:

  This is required to unbreak the fuzzers while a fix is being worked on.

  https://cirrus-ci.com/task/4787303177519104?logs=ci#L3020

  ```
  netaddress.cpp:1190:18: runtime error: implicit conversion from type 'int' of value -1 (32-bit, signed) to type 'uint8_t' (aka 'unsigned char') changed the value to 255 (8-bit, unsigned)

ACKs for top commit:
  practicalswift:
    cr ACK fa86528
  tryphe:
    untested ACK fa86528
  lsilva01:
    ACK bitcoin@fa86528

Tree-SHA512: 4a54ec68c014c7a4c9ab268c3a04321db5eb9b2857646b41406d8d4908a3d349848b4549e80aea6afd9a0c3639522a48fe578527139519b12439eae9f0c4c46c
@hebasto hebasto mentioned this pull request Aug 6, 2021
hebasto pushed a commit to hebasto/bitcoin that referenced this pull request Aug 6, 2021
@hebasto
Copy link
Member

hebasto commented Aug 6, 2021

Backported in #22629.

UPDATE: #22629 (comment)

hebasto pushed a commit to hebasto/bitcoin that referenced this pull request Aug 6, 2021
hebasto pushed a commit to hebasto/bitcoin that referenced this pull request Aug 6, 2021
hebasto pushed a commit to hebasto/bitcoin that referenced this pull request Aug 7, 2021
hebasto pushed a commit to hebasto/bitcoin that referenced this pull request Aug 9, 2021
hebasto pushed a commit to hebasto/bitcoin that referenced this pull request Aug 9, 2021
hebasto pushed a commit to hebasto/bitcoin that referenced this pull request Aug 19, 2021
hebasto pushed a commit to hebasto/bitcoin that referenced this pull request Aug 20, 2021
hebasto pushed a commit to hebasto/bitcoin that referenced this pull request Aug 20, 2021
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants